Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) #73309

Merged
merged 4 commits into from
Aug 1, 2020
Merged

[Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) #73309

merged 4 commits into from
Aug 1, 2020

Conversation

clintandrewhall
Copy link
Contributor

Summary

A broken-out PR from #73295

Starts to fix #58289; sub-components still throw errors, but the snapshots work just fine.

This PR completes the "Kill Recompose.pure" series by refactoring Toolbar and related components. The pure HOC from recompose should now be dead and gone...!

It also bridges a gap with the RouterContext decorator in Storybook.

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.10.0 labels Jul 27, 2020
@clintandrewhall clintandrewhall requested a review from a team July 27, 2020 16:17
@clintandrewhall clintandrewhall requested a review from a team as a code owner July 27, 2020 16:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
canvas 1203 -1 1204

async chunks size

id value diff baseline
canvas 1.4MB +1.1KB 1.4MB

page load bundle size

id value diff baseline
canvas 1.4MB +185.0B 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit e8de940 into elastic:master Aug 1, 2020
@clintandrewhall clintandrewhall mentioned this pull request Aug 1, 2020
Merged
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Aug 1, 2020
@clintandrewhall @elasticmachine
[Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (e…
cdfc5cc 
…lastic#73309)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall added a commit that referenced this pull request Aug 1, 2020
@clintandrewhall @elasticmachine
[7.x] [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.…
3fcff1d 
…pure) (#73309) (#74048)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@clintandrewhall clintandrewhall deleted the tech-debt/recompose-toolbar branch May 28, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Unit Tests -Toolbar component storybook tests
5 participants
@clintandrewhall @elasticmachine @kibanamachine @ryankeairns @crob611