Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use ML capabilities canAccessML to enable anomaly detection settings #73998

Closed
ogupte opened this issue Jul 31, 2020 · 1 comment · Fixed by #73999
Closed

[APM] Use ML capabilities canAccessML to enable anomaly detection settings #73998

ogupte opened this issue Jul 31, 2020 · 1 comment · Fixed by #73999
Assignees
@ogupte
Labels
apm:ml Integration between APM and ML bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Jul 31, 2020

As per the feedback (https://github.com/elastic/kibana/pull/73638/files#r463479399), we should be checking the value of canAccessML instead of only checking for the existance of the ML plugin. This will ensure that the user isn't able to use Anomaly detection settings in cases where they don't have ML enabled in the cluster or otherwise don't have access to ML in kibana.
@ogupte ogupte added 7.10.0 apm:ml Integration between APM and ML bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Jul 31, 2020
@ogupte ogupte self-assigned this Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte added a commit to ogupte/kibana that referenced this issue Jul 31, 2020
@ogupte
Closes elastic#73998 by using canAccessML in the ML capabilities AP…
746204b 
…I to

enable anomaly detection settings in APM.
@ogupte ogupte mentioned this issue Jul 31, 2020
Merged
ogupte added a commit that referenced this issue Jul 31, 2020
@ogupte
Closes #73998 by using canAccessML in the ML capabilities API to (#…
6eca0b4 
…73999)

enable anomaly detection settings in APM.
kibanamachine pushed a commit that referenced this issue Jul 31, 2020
@ogupte
Closes #73998 by using canAccessML in the ML capabilities API to (#…
52a354a 
…73999)

enable anomaly detection settings in APM.
@kibanamachine kibanamachine mentioned this issue Jul 31, 2020
Merged
kibanamachine pushed a commit that referenced this issue Jul 31, 2020
@ogupte
Closes #73998 by using canAccessML in the ML capabilities API to (#…
50c11ae 
…73999)

enable anomaly detection settings in APM.
@kibanamachine kibanamachine mentioned this issue Jul 31, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this issue Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
ogupte added a commit that referenced this issue Aug 3, 2020
@kibanamachine @ogupte @elasticmachine
Closes #73998 by using canAccessML in the ML capabilities API to (#…
4ce7122 
…73999) (#74022)

enable anomaly detection settings in APM.

Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ogupte added a commit that referenced this issue Aug 3, 2020
@kibanamachine @ogupte @elasticmachine
Closes #73998 by using canAccessML in the ML capabilities API to (#…
1aad193 
…73999) (#74021)

enable anomaly detection settings in APM.

Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jen-huang jen-huang added v7.9.0 and removed 7.9.0 labels Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:ml Integration between APM and ML bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Fix anomaly detection settings link using the ML capabilities API ogupte/kibana
3 participants
@jen-huang @ogupte @elasticmachine