-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log Explorer] Add Explorer app locator #165962
[Log Explorer] Add Explorer app locator #165962
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…add-log-explorer-app-locator
…add-log-explorer-app-locator
…com/mohamedhamed-ahmed/kibana into 164995-add-log-explorer-app-locator
…add-log-explorer-app-locator
…add-log-explorer-app-locator
/oblt-deploy |
/oblt-deploy-serverless |
/oblt-deploy-serverless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes LGTM, thanks for this work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AO changes LGTM (code review only)
…add-log-explorer-app-locator
…add-log-explorer-app-locator
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
closes elastic#164995 closes elastic#165618 closes elastic#166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](elastic#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](elastic#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
`OBSERVABILITY_ONBOARDING_LOCATOR` and `ObservabilityOnboardingLocatorParams` were removed from `observability_onboarding` plugin in [#165962](#165962) and are now part of `@kbn/deeplinks-observability/locators`. `datsetName` was transformed into an optional variable in the wizard state in [#166654](#166654) which makes sense for first step of custom logs onboarding but it's required in onboarding saved object.
closes #164995
closes #165618
closes #166596
📝 Summary
Observability Log Explorer Locators:
This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented:
With more locators to come in the future depending on the use cases.
Log Explorer Locators:
We also added a log explorer locator that navigates to discover, this can be used in case the Observability Log Explorer plugin is disabled.
Logs Onboarding:
The PR also replaces the temp navigation to the default discover we implemented for 8.10 here with the above new Observability Log Explorer locators.
APM:
After disabling infra plugin in serverless projects, APM links to infra locators in serverless have been replaced to use the above locators.
Observability Landing Page:
The landing page now redirects to the Log Explorer if
logs-*-*
has data in it, otherwise the flow continues as before.Necessary Refactoring:
To avoid the circular dependency between
ObservabilityLogExplorer
&ObservabilityOnboarding
after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in thedeeplinks
package.✅ Testing
Onboarding Wizard in Serverless and Stateful
/app/observabilityOnboarding/
APM links in Serverless
🎥 Demos
apm_serverless.mov
apm_stateful.mov
onboarding_serverless.mov
onboarding_stateful.mov
observability_landing.mov