[Logs onboarding] fixing type issues

[yngrdyn]

OBSERVABILITY_ONBOARDING_LOCATOR and ObservabilityOnboardingLocatorParams were removed from observability_onboarding plugin in #165962 and are now part of @kbn/deeplinks-observability/locators.

datsetName was transformed into an optional variable in the wizard state in #166654 which makes sense for first step of custom logs onboarding but it's required in onboarding saved object.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[achyutjhunjhunwala]

@yngrdyn Did the original change made it to 8.10 ? If yes, then this would require backporting

[yngrdyn]

@yngrdyn Did the original change made it to 8.10 ? If yes, then this would require backporting

No, these changes were introduced last week @achyutjhunjhunwala

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 5ca39ef

Failed CI Steps

• FTR Configs #11
• FTR Configs #22

Test Failures

• [job] [logs] FTR Configs #22 / discover/group1 shared links shared links with state in sessionStorage sharing hashed url shouldn't crash the app
• [job] [logs] FTR Configs #11 / serverless common UI Avatar menu "before all" hook for "is displayed"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
observabilityOnboarding	16	14	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observabilityOnboarding	239.4KB	239.4KB	+23.0B

Unknown metric groups

API count

id	before	after	diff
observabilityOnboarding	17	14	-3

History

• 💚 Build #162634 succeeded 2c465f8
• 💚 Build #162633 succeeded 9ad8279

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream