Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] Explore logs button should have different states #166009

Closed
yngrdyn opened this issue Sep 7, 2023 · 9 comments · Fixed by #167409
Closed

[Logs onboarding] Explore logs button should have different states #166009

yngrdyn opened this issue Sep 7, 2023 · 9 comments · Fixed by #167409
Assignees
@yngrdyn
Labels
Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Sep 7, 2023

Explore Logs button should manage different states

image

If the integration is being installed, the button should be disabled
If the integration was successfully installed, it should redirect to Logs Explorer - [Integration]
If the integration failed, it should redirect to Logs Explorer - all datasets
@yngrdyn yngrdyn added Team:APM All issues that need APM UI Team support apm:logs-onboarding labels Sep 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@yngrdyn yngrdyn mentioned this issue Sep 7, 2023
Closed
@mohamedhamed-ahmed
Copy link
Contributor

@yngrdyn Thanks for quickly creating this.

This is going to affect both, System & Custom logs right?

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Sep 7, 2023

Yes, but I think it's more relevant in System onboarding.

For Custom onboarding, should we proceed to step 2 of the flow if the integration failed? if yes, then it's equally relevant.

@mohamedhamed-ahmed
Copy link
Contributor

Yes, but I think it's more relevant in System onboarding.

I agree.

For Custom onboarding, should we proceed to step 2 of the flow if the integration failed? if yes, then it's equally relevant.

Not sure, maybe @isaclfreire can help here.

@weltenwort
Copy link
Member

@Kerry350 IIRC we don't proceed to step 2 if the integration installation fails, but display the error right in step 2. Is that correct?

If so, we don't need to account for that case for the custom logs case.

@Kerry350
Copy link
Contributor

Kerry350 commented Sep 8, 2023

Correct, an error is displayed and no progression to the next step happens.

@isaclfreire
Copy link

Agreed! I think also the Step itself gets the Danger state if I'm not mistaken, right?

Screenshot 2023-09-08 at 14 24 35

@yngrdyn yngrdyn self-assigned this Sep 14, 2023
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Sep 19, 2023

We need to wait for this PR #165962 in order to proceed with this one.
That PR contains the locators to go to Logs explorer

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Sep 22, 2023 •
edited
Loading

Agreed! I think also the Step itself gets the Danger state if I'm not mistaken, right?

@isaclfreire This doesn't happen because the integration install is detached from the flow, users could continue the flow and navigate to logs explorer and see logs even when the integration is not installed

@yngrdyn yngrdyn mentioned this issue Sep 27, 2023
Merged
yngrdyn added a commit that referenced this issue Oct 2, 2023
@yngrdyn
[Logs onboarding] Explore logs button should have different states (#…
45771ff 
…167409)

Closes #166009.

When system integration is installed successfully we should be able to
redirect the user to logs explorer with the `System integration`
selected


https://github.com/elastic/kibana/assets/1313018/7a1d7457-00e8-4399-9332-3ea7af2b0145

When system integration installation failed we should be able to
redirect the user to logs explorer with `All logs` selected


https://github.com/elastic/kibana/assets/1313018/e13f69ab-adb4-460c-84cf-d9971ce56b9f

When system integration is being installed, Explore Logs button should
be disabled


https://github.com/elastic/kibana/assets/1313018/5dd04859-e75b-49ed-9f47-5ad2120eb9d8

### How to test
1. Log in as `viewer` user
2. Enter [system
logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs)
onboarding flow
3. Verify System integration was not installed
4. Click on `Explore Logs`
5. Verify you are being redirected to Log explorer with `All logs` being
selected
6. Logout and log in again as `admin` user
7. Enter [system
logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs)
onboarding flow
8. Verify system integration was installed successfully
9. Click on `Explore Logs`
10. Verify you are being redirected to Log explorer with `[system]`
being selected
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM All issues that need APM UI Team support apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
7 participants
@Kerry350 @weltenwort @yngrdyn @gbamparop @mohamedhamed-ahmed @elasticmachine @isaclfreire