-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Explore logs button should have different states #166009
Comments
Pinging @elastic/apm-ui (Team:APM) |
@yngrdyn Thanks for quickly creating this. This is going to affect both, |
Yes, but I think it's more relevant in For |
I agree.
Not sure, maybe @isaclfreire can help here. |
@Kerry350 IIRC we don't proceed to step 2 if the integration installation fails, but display the error right in step 2. Is that correct? If so, we don't need to account for that case for the custom logs case. |
Correct, an error is displayed and no progression to the next step happens. |
We need to wait for this PR #165962 in order to proceed with this one. |
@isaclfreire This doesn't happen because the integration install is detached from the flow, users could continue the flow and navigate to logs explorer and see logs even when the integration is not installed |
…167409) Closes #166009. When system integration is installed successfully we should be able to redirect the user to logs explorer with the `System integration` selected https://github.com/elastic/kibana/assets/1313018/7a1d7457-00e8-4399-9332-3ea7af2b0145 When system integration installation failed we should be able to redirect the user to logs explorer with `All logs` selected https://github.com/elastic/kibana/assets/1313018/e13f69ab-adb4-460c-84cf-d9971ce56b9f When system integration is being installed, Explore Logs button should be disabled https://github.com/elastic/kibana/assets/1313018/5dd04859-e75b-49ed-9f47-5ad2120eb9d8 ### How to test 1. Log in as `viewer` user 2. Enter [system logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs) onboarding flow 3. Verify System integration was not installed 4. Click on `Explore Logs` 5. Verify you are being redirected to Log explorer with `All logs` being selected 6. Logout and log in again as `admin` user 7. Enter [system logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs) onboarding flow 8. Verify system integration was installed successfully 9. Click on `Explore Logs` 10. Verify you are being redirected to Log explorer with `[system]` being selected
Explore Logs
button should manage different statesIf the integration is being installed, the button should be
disabled
If the integration was successfully installed, it should redirect to
Logs Explorer - [Integration]
If the integration failed, it should redirect to
Logs Explorer - all datasets
The text was updated successfully, but these errors were encountered: