-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explorer] Ensure APM logs are viewed in the log explorer #165618
Labels
Feature:LogsExplorer
Logs Explorer feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Comments
weltenwort
added
Feature:Logs UI
Logs UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
labels
Sep 4, 2023
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
formgeist
changed the title
[Log Explorer] Ensure APM logs are viewed in the log explorer
[Explorer] Ensure APM logs are viewed in the log explorer
Sep 6, 2023
As discussed with Felix, this ticket is going to affect where |
mohamedhamed-ahmed
added a commit
that referenced
this issue
Sep 20, 2023
closes #164995 closes #165618 closes #166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this issue
Sep 21, 2023
closes elastic#164995 closes elastic#165618 closes elastic#166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](elastic#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](elastic#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
gbamparop
added
Feature:LogsExplorer
Logs Explorer feature
and removed
Feature:Logs UI
Logs UI feature
labels
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:LogsExplorer
Logs Explorer feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
📓 Summary
The "Investigate" menu for APM traces contains links to view logs. These should navigate to the Log Explorer.
✔️ Acceptance criteria
The text was updated successfully, but these errors were encountered: