Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Use collector and symbolizer integrations in the add data page #159481

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[Profiling] Use collector and symbolizer integrations in the add data page #159481

merged 1 commit into from
Jun 13, 2023

Conversation

cauemarcondes
Copy link
Contributor

In this PR:

  • Removed the apm server information from add data page.
  • Fetches Collector host and secret token instead to apm.
  • Fetches Symbolizer host to be used in the Upload symbols tab.
  • Replace apm server URL for collector host.
  • Swap Elastic agent integration and Upload symbols tabs.
Screenshot 2023-06-12 at 2 18 06 PM Screenshot 2023-06-12 at 2 18 13 PM Screenshot 2023-06-12 at 2 18 21 PM

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 12, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner June 12, 2023 13:23
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 288.6KB 288.6KB +46.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 491 495 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jbcrail
jbcrail approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@jbcrail jbcrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@cauemarcondes cauemarcondes merged commit 486c24b into elastic:main Jun 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2023
@cauemarcondes cauemarcondes deleted the profiling-fix-cloud-address branch June 13, 2023 08:45
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 13, 2023
@jloleysens
Merge branch 'main' into do-not-do-version-check-on-serverless
a67fd82 
* main: (199 commits)
  [Lens] Add custom formatter within the Lens editor (elastic#158468)
  [Uptime] Hide app if no data is available (elastic#159118)
  [CodeEditor] Add grok highlighting (elastic#159334)
  Expose decoded cloudId components from the cloud plugin's contract (elastic#159442)
  [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481)
  [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011)
  [APM] Add feature flag for not available apm schema (elastic#158911)
  [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502)
  [api-docs] 2023-06-13 Daily api_docs build (elastic#159536)
  [data views] Use versioned router for REST routes (elastic#158608)
  [maps] fix geo line source not loaded unless maps application is opened (elastic#159432)
  [Enterprise Search][Search application]Fix Create Api key url (elastic#159519)
  [Security Solution] Increase timeout for indexing hosts (elastic#159518)
  dashboard Reset button disable (elastic#159430)
  [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484)
  [Synthetics] adjust alert timing (elastic#159511)
  [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252)
  Revert "Remove unused package (elastic#158597)"
  [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505)
  Remove unused package (elastic#158597)
  ...
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023
@cauemarcondes @saarikabhasi
[Profiling] Use collector and symbolizer integrations in the add data…
cde11e2 
… page (elastic#159481)

In this PR:

- Removed the apm server information from add data page.
- Fetches Collector host and secret token instead to apm.
- Fetches Symbolizer host to be used in the `Upload symbols` tab.
- Replace apm server URL for collector host.
- Swap `Elastic agent integration` and `Upload symbols` tabs.

<img width="1435" alt="Screenshot 2023-06-12 at 2 18 06 PM"
src="https://github.com/elastic/kibana/assets/55978943/a32dfac3-7ab1-4a03-94d1-a9756927e3eb">
<img width="1469" alt="Screenshot 2023-06-12 at 2 18 13 PM"
src="https://github.com/elastic/kibana/assets/55978943/63139e6b-71a5-4d94-a3ea-b51c126a2d19">
<img width="1486" alt="Screenshot 2023-06-12 at 2 18 21 PM"
src="https://github.com/elastic/kibana/assets/55978943/b2811018-337f-46dd-8ad4-43a8f9986bbd">
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023
@cauemarcondes @saarikabhasi
[Profiling] Use collector and symbolizer integrations in the add data…
2f9cf32 
… page (elastic#159481)

In this PR:

- Removed the apm server information from add data page.
- Fetches Collector host and secret token instead to apm.
- Fetches Symbolizer host to be used in the `Upload symbols` tab.
- Replace apm server URL for collector host.
- Swap `Elastic agent integration` and `Upload symbols` tabs.

<img width="1435" alt="Screenshot 2023-06-12 at 2 18 06 PM"
src="https://github.com/elastic/kibana/assets/55978943/a32dfac3-7ab1-4a03-94d1-a9756927e3eb">
<img width="1469" alt="Screenshot 2023-06-12 at 2 18 13 PM"
src="https://github.com/elastic/kibana/assets/55978943/63139e6b-71a5-4d94-a3ea-b51c126a2d19">
<img width="1486" alt="Screenshot 2023-06-12 at 2 18 21 PM"
src="https://github.com/elastic/kibana/assets/55978943/b2811018-337f-46dd-8ad4-43a8f9986bbd">
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 14, 2023
@cauemarcondes @saarikabhasi
[Profiling] Use collector and symbolizer integrations in the add data…
60be072 
… page (elastic#159481)

In this PR:

- Removed the apm server information from add data page.
- Fetches Collector host and secret token instead to apm.
- Fetches Symbolizer host to be used in the `Upload symbols` tab.
- Replace apm server URL for collector host.
- Swap `Elastic agent integration` and `Upload symbols` tabs.

<img width="1435" alt="Screenshot 2023-06-12 at 2 18 06 PM"
src="https://github.com/elastic/kibana/assets/55978943/a32dfac3-7ab1-4a03-94d1-a9756927e3eb">
<img width="1469" alt="Screenshot 2023-06-12 at 2 18 13 PM"
src="https://github.com/elastic/kibana/assets/55978943/63139e6b-71a5-4d94-a3ea-b51c126a2d19">
<img width="1486" alt="Screenshot 2023-06-12 at 2 18 21 PM"
src="https://github.com/elastic/kibana/assets/55978943/b2811018-337f-46dd-8ad4-43a8f9986bbd">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbcrail jbcrail jbcrail approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cauemarcondes @apmmachine @kibana-ci @jbcrail @kibanamachine