[APM] Add feature flag for not available apm schema #158911

MiriamAparicio · 2023-06-02T11:53:54Z

Part of #153776

How to test:

change default value in x-pack/plugins/apm/common/apm_feature_flags.ts

elasticmachine · 2023-06-02T11:53:57Z

Pinging @elastic/apm-ui (Team:APM)

apmmachine · 2023-06-02T11:54:11Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sorenlouv · 2023-06-05T13:25:01Z

x-pack/plugins/apm/server/routes/fleet/route.ts

+function throwNotFoundIfApmSchemaNotAvailable(
+  featureFlags: ApmFeatureFlags
+): void {
+  if (!featureFlags.schemaAvailable) {


I was never fond of the name "schemaAvailable". It seems so vague.

@ogupte Isn't this about fleet migration? Could we call this featureFlags.isFleetMigrationAvailable?

If so, should we also block the other request in x-pack/plugins/apm/server/routes/fleet/route.ts?
@sqren @ogupte

I think we also want to restrict access to POST /internal/apm/fleet/cloud_apm_package_policy if that's the one you mean?

The MigrationToFleetAvailable already exist, should I use this one in this case? I will use the schema for the UI tab then, what do you think?

@ogupte WDYT?

The feature in question is the fleet migration page in settings, which has the title APM Schema (not sure why exactly). i agree that it should use one feature flag like showFleetMigration or something. There's already already a config that exists to enable it but it doesn't hide it from the UI.

MiriamAparicio · 2023-06-06T14:30:18Z

x-pack/plugins/apm/common/apm_feature_flags.ts

@@ -49,7 +49,7 @@ const apmFeatureFlagMap = {
    default: true,
    type: t.boolean,
  },
-  [ApmFeatureFlagName.SchemaAvailable]: {
+  [ApmFeatureFlagName.FleetMigrationAvailable]: {


My mistake I just saw that this already exist
I'll revert the commit

…ration" This reverts commit 87d15bf.

…odifications-part-III

ogupte · 2023-06-12T15:16:06Z

x-pack/plugins/apm/server/routes/fleet/route.ts

should we give the same check (throwNotFoundIfApmSchemaNotAvailable) in GET /internal/apm/fleet/migration_check? It's an API that's call from 2 places:

the settings page which is hidden in this PR

also the tutorial (https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/tutorial/tutorial_fleet_instructions/index.tsx#L52) where it switches an href link between the above settings page (now hidden) or the APM integration page (not available in serverless)

…unction

kibana-ci · 2023-06-12T17:28:36Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 609d162

Failed CI Steps

FTR Configs #39

Test Failures

[job] [logs] FTR Configs #39 / InfraOps App Metrics UI Hosts View #Single host Flyout "after each" hook for "should navigate to APM services after click"
[job] [logs] FTR Configs #39 / InfraOps App Metrics UI Hosts View #Single host Flyout should navigate to APM services after click

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.6MB	3.6MB	+16.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💚 Build #134418 succeeded 0f4d872
💛 Build #133207 was flaky 9da0033
💛 Build #132994 was flaky f168299
💛 Build #132068 was flaky dcd7633

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...

Part of elastic#153776 How to test: - change default value in x-pack/plugins/apm/common/apm_feature_flags.ts

add feature flag for not available apm schema

dcd7633

MiriamAparicio added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 2, 2023

MiriamAparicio requested a review from a team as a code owner June 2, 2023 11:53

sorenlouv reviewed Jun 5, 2023

View reviewed changes

MiriamAparicio mentioned this pull request Jun 5, 2023

[APM] Serverless modifications for APM UI #153776

Closed

10 tasks

add flag to feel endpoint and rename schema flag to flett migration

87d15bf

MiriamAparicio commented Jun 6, 2023

View reviewed changes

MiriamAparicio force-pushed the 153776-serverless-modifications-part-III branch from efb1bed to 974f05e Compare June 6, 2023 14:42

Revert "add flag to feel endpoint and rename schema flag to flett mig…

15e2984

…ration" This reverts commit 87d15bf.

MiriamAparicio force-pushed the 153776-serverless-modifications-part-III branch from 974f05e to 15e2984 Compare June 6, 2023 14:57

MiriamAparicio added 2 commits June 12, 2023 15:50

Merge remote-tracking branch 'upstream/main' into 153776-serverless-m…

872bc40

…odifications-part-III

check migrationtoFleetAvailable feature flag for fleet schema

0f4d872

MiriamAparicio force-pushed the 153776-serverless-modifications-part-III branch from 9da0033 to 0f4d872 Compare June 12, 2023 14:55

ogupte reviewed Jun 12, 2023

View reviewed changes

add not found in GET /internal/apm/fleet/migration_check and rename f…

609d162

…unction

ogupte approved these changes Jun 12, 2023

View reviewed changes

sorenlouv approved these changes Jun 12, 2023

View reviewed changes

MiriamAparicio merged commit bda9a56 into elastic:main Jun 13, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2023

MiriamAparicio deleted the 153776-serverless-modifications-part-III branch June 13, 2023 07:54

MiriamAparicio mentioned this pull request Jun 13, 2023

add feature flags to apm config and serverless.oblt.yml #159136

Merged

saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023

[APM] Add feature flag for not available apm schema (elastic#158911)

42abc2c

Part of elastic#153776 How to test: - change default value in x-pack/plugins/apm/common/apm_feature_flags.ts

saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023

[APM] Add feature flag for not available apm schema (elastic#158911)

c82179c

Part of elastic#153776 How to test: - change default value in x-pack/plugins/apm/common/apm_feature_flags.ts

saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 14, 2023

[APM] Add feature flag for not available apm schema (elastic#158911)

8cef5e8

Part of elastic#153776 How to test: - change default value in x-pack/plugins/apm/common/apm_feature_flags.ts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add feature flag for not available apm schema #158911

[APM] Add feature flag for not available apm schema #158911

MiriamAparicio commented Jun 2, 2023

elasticmachine commented Jun 2, 2023

apmmachine commented Jun 2, 2023

sorenlouv Jun 5, 2023 •

edited

Loading

MiriamAparicio Jun 5, 2023

sorenlouv Jun 6, 2023

MiriamAparicio Jun 6, 2023

sorenlouv Jun 6, 2023

ogupte Jun 7, 2023

MiriamAparicio Jun 6, 2023 •

edited

Loading

ogupte Jun 12, 2023 •

edited

Loading

kibana-ci commented Jun 12, 2023

ESLint disabled line counts

Total ESLint disabled count

[APM] Add feature flag for not available apm schema #158911

[APM] Add feature flag for not available apm schema #158911

Conversation

MiriamAparicio commented Jun 2, 2023

elasticmachine commented Jun 2, 2023

apmmachine commented Jun 2, 2023

🤖 GitHub comments

sorenlouv Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

MiriamAparicio Jun 5, 2023

Choose a reason for hiding this comment

sorenlouv Jun 6, 2023

Choose a reason for hiding this comment

MiriamAparicio Jun 6, 2023

Choose a reason for hiding this comment

sorenlouv Jun 6, 2023

Choose a reason for hiding this comment

ogupte Jun 7, 2023

Choose a reason for hiding this comment

MiriamAparicio Jun 6, 2023 • edited Loading

Choose a reason for hiding this comment

ogupte Jun 12, 2023 • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Jun 12, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

sorenlouv Jun 5, 2023 •

edited

Loading

MiriamAparicio Jun 6, 2023 •

edited

Loading

ogupte Jun 12, 2023 •

edited

Loading