[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011

jennypavlova · 2023-05-08T15:25:31Z

Summary

This PR adds a flag (isAutoRefreshDisabled) to disable the default auto-refresh option in the unified search.

Background

The auto refresh is added by default when using a unified search bar in defaultOnRefreshChange and it appeared on the host view page when currently the auto-refresh option is not supported.

with `isAutoRefreshDisabled` (true)	without `isAutoRefreshDisabled` (false/undefined)

apmmachine · 2023-05-08T15:25:46Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-05-08T16:31:53Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mohamedhamed-ahmed

LGTM!

stratoula · 2023-05-10T13:36:36Z

@jennypavlova can you add a storybook story about this new flag? Thanx

…search-bar-with-auto-refresh-enabled

jennypavlova · 2023-05-11T08:49:28Z

@stratoula Storybook added (also removed a duplicate one):

Off	On

jennypavlova · 2023-05-11T09:12:51Z

@elasticmachine merge upstream

…search-bar-with-auto-refresh-enabled

stratoula · 2023-05-12T11:12:21Z

src/plugins/unified_search/public/search_bar/create_search_bar.tsx

@@ -218,7 +221,7 @@ export function createSearchBar({
            filters={filters}
            query={query}
            onFiltersUpdated={defaultFiltersUpdated(data.query, props.onFiltersUpdated)}
-            onRefreshChange={defaultOnRefreshChange(data.query)}
+            onRefreshChange={defaultOnRefreshChange(data.query, props.isAutoRefreshDisabled)}


I think that there is no need to pass it to the function, just dont run the function if this prop is set to true

I changed it to set undefined there if we have isAutoRefreshDisabled set to true otherwise it will use the function.

I was thinking something like onRefreshChange={!props.isAutoRefreshDisabled ? defaultOnRefreshChange(data.query) : undefined}

Oh I see, this is what you need. This is a nit but can you add the undefined as the else clause? As I have it on my comment?

Sure, thanks for checking that! 🙂 I changed the condition to return the function if we don't have isAutoRefreshDisabled and otherwise to be undefined. Is that what you mean?

…search-bar-with-auto-refresh-enabled

stratoula

Unified search changes LGTM!

kibana-ci · 2023-06-13T06:54:43Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	2.0MB	2.0MB	+25.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`unifiedSearch`	33.9KB	33.9KB	+31.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💚 Build #134221 succeeded 9cc4c8a
💚 Build #128105 succeeded c546885
💛 Build #127099 was flaky ff7a307
💔 Build #127048 failed 9f11729
💚 Build #126260 succeeded 1aaff3d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

stratoula · 2023-06-13T07:15:49Z

@jennypavlova is it necessary to backport to the prev minor?

jennypavlova · 2023-06-13T08:07:39Z

@jennypavlova is it necessary to backport to the prev minor?

@stratoula I added it because there we saw the issue with the hosts view data picker there and the backport will fix it

…enabled (elastic#157011) Closes elastic#156690 ## Summary This PR adds a flag (`isAutoRefreshDisabled`) to disable the default auto-refresh option in the unified search. ## Background The auto refresh is added by default when using a unified search bar in [defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59) and it appeared on the host view page when currently the auto-refresh option is not supported. | with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled` (false/undefined) | | ------------------------------------ | -------------------------------------------------- | | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png"> | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png"> | --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 77d864e)

kibanamachine · 2023-06-13T08:14:26Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…fresh enabled (#157011) (#159543) # Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011)](#157011)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>

* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...

…enabled (elastic#157011) Closes elastic#156690 ## Summary This PR adds a flag (`isAutoRefreshDisabled`) to disable the default auto-refresh option in the unified search. ## Background The auto refresh is added by default when using a unified search bar in [defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59) and it appeared on the host view page when currently the auto-refresh option is not supported. | with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled` (false/undefined) | | ------------------------------------ | -------------------------------------------------- | | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png"> | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png"> | --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>

Add a flag to disable the default auto refresh option in unified search

1aaff3d

jennypavlova self-assigned this May 8, 2023

jennypavlova marked this pull request as ready for review May 8, 2023 16:31

jennypavlova requested review from a team as code owners May 8, 2023 16:31

mohamedhamed-ahmed approved these changes May 9, 2023

View reviewed changes

jennypavlova added 2 commits May 11, 2023 10:38

Add storybook for the default auto refresh interval

1d37894

Merge branch 'main' into 156690-infrastructure-ui-hosts-view-unified-…

9f11729

…search-bar-with-auto-refresh-enabled

Merge branch 'main' into 156690-infrastructure-ui-hosts-view-unified-…

ff7a307

…search-bar-with-auto-refresh-enabled

stratoula reviewed May 12, 2023

View reviewed changes

Set onRefreshChange to undefined if isAutoRefreshDisabled is set

c48c174

jennypavlova requested a review from stratoula May 16, 2023 08:45

jennypavlova and others added 3 commits May 16, 2023 11:09

Change the condition order

c546885

Merge branch 'main' into 156690-infrastructure-ui-hosts-view-unified-…

9cc4c8a

…search-bar-with-auto-refresh-enabled

Merge branch 'main' into 156690-infrastructure-ui-hosts-view-unified-…

cf7e465

…search-bar-with-auto-refresh-enabled

stratoula approved these changes Jun 13, 2023

View reviewed changes

jennypavlova merged commit 77d864e into elastic:main Jun 13, 2023

jennypavlova deleted the 156690-infrastructure-ui-hosts-view-unified-search-bar-with-auto-refresh-enabled branch June 13, 2023 08:08

kibanamachine added the v8.9.0 label Jun 13, 2023

kibanamachine mentioned this pull request Jun 13, 2023

[8.8] [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011) #159543

Merged

kibanamachine added the v8.8.2 label Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011

[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011

jennypavlova commented May 8, 2023 •

edited by kibanamachine

Loading

apmmachine commented May 8, 2023

elasticmachine commented May 8, 2023

mohamedhamed-ahmed left a comment

stratoula commented May 10, 2023

jennypavlova commented May 11, 2023

jennypavlova commented May 11, 2023

stratoula May 12, 2023

jennypavlova May 16, 2023

stratoula May 16, 2023

stratoula May 16, 2023

jennypavlova May 16, 2023

stratoula left a comment

kibana-ci commented Jun 13, 2023

ESLint disabled line counts

Total ESLint disabled count

stratoula commented Jun 13, 2023

jennypavlova commented Jun 13, 2023

kibanamachine commented Jun 13, 2023

[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011

[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011

Conversation

jennypavlova commented May 8, 2023 • edited by kibanamachine Loading

Summary

Background

apmmachine commented May 8, 2023

🤖 GitHub comments

elasticmachine commented May 8, 2023

mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

stratoula commented May 10, 2023

jennypavlova commented May 11, 2023

jennypavlova commented May 11, 2023

stratoula May 12, 2023

Choose a reason for hiding this comment

jennypavlova May 16, 2023

Choose a reason for hiding this comment

stratoula May 16, 2023

Choose a reason for hiding this comment

stratoula May 16, 2023

Choose a reason for hiding this comment

jennypavlova May 16, 2023

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

kibana-ci commented Jun 13, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

stratoula commented Jun 13, 2023

jennypavlova commented Jun 13, 2023

kibanamachine commented Jun 13, 2023

💚 All backports created successfully

Questions ?

jennypavlova commented May 8, 2023 •

edited by kibanamachine

Loading