Remove unused package #158597
Merged
Remove unused package #158597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatkiller
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.9.0
backport:skip
|
Actually I had to revert this in ab29f08 as there is direct invokations to this module into some packages tasks like https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/package.json#L14 |
|
@mistic The Here are the docs: https://www.npmjs.com/package/mochawesome-report-generator Did removing this cause an issue? |
|
@oatkiller the chain of deps looks like |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 13, 2023
* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Jun 14, 2023
## Summary The [marge](https://github.com/Maciek416/marge/tree/master) package is included in `package.json`, but it doesn't appear to be used. note: there is a `marge` binary, but that is provided by https://npm.io/package/@danielkalen/mochawesome-report-generator and is unrelated.
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Jun 14, 2023
This reverts commit ab29f08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The marge package is included in
package.json, but it doesn't appear to be used.note: there is a
margebinary, but that is provided by https://npm.io/package/@danielkalen/mochawesome-report-generator and is unrelated.Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers