Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.10 #165183

Closed
bhavyarm opened this issue Aug 30, 2023 · 3 comments · Fixed by #165326
Closed

[dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.10 #165183

bhavyarm opened this issue Aug 30, 2023 · 3 comments · Fixed by #165326
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.10.0 BC2

Elasticsearch version: 8.10.0 BC2

Server OS version: darwin_aarch

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: When you add a map viz to a dashboard - layers panel takes over more than half of the maps dashboard panel.

Steps to reproduce:

  1. Click on maps and create a map using sample data
  2. Add the map to dashboard - new or existing
  3. Notice layers panel taking over more than half of the maps dashboard panel
  4. You do refresh - display goes back to normal

Screenshots (if relevant):
Screenshot 2023-08-29 at 8 45 25 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jsanz
Copy link
Member

jsanz commented Aug 30, 2023

I could reproduce this with the last 8.10.0-SNAPSHOT docker image and from main branch. Checked both in Firefox and Chromium.

vokoscreenNG-2023-08-30_11-42-59.webm

This happens even not adding any layer at all, just with the basemap.

vokoscreenNG-2023-08-30_11-51-58.webm

@nreese
Copy link
Contributor

nreese commented Aug 30, 2023

regression of #155553 that was fixed in #155554

#161032 removed the fix added by #155554. I thought that we tested for this case but somehow this issue has been re-introduced.

@nreese nreese self-assigned this Aug 31, 2023
@nreese nreese changed the title Layers panel takes over more than half of the maps dashboard panel [dashboard][map] 'by value' map does not fill dashboard panel on initial page load 8.11 Aug 31, 2023
@nreese nreese changed the title [dashboard][map] 'by value' map does not fill dashboard panel on initial page load 8.11 [dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.11 Aug 31, 2023
@nreese nreese changed the title [dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.11 [dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.10 Aug 31, 2023
@nreese nreese mentioned this issue Aug 31, 2023
Merged
nreese added a commit that referenced this issue Aug 31, 2023
@nreese @kibanamachine
[maps] fix 'by value' map does not fill dashboard panel on initial pa…
168412b 
…ge load in 8.10 (#165326)

Fixes #165183

### Test instructions
1) install any sample data set
2) open new dashboard
3) Use "Add panel" buttons to add by-value map with only base map layer
4) Ensure map tiles fill entire map panel in dashboard

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 31, 2023
@nreese
[maps] fix 'by value' map does not fill dashboard panel on initial pa…
293e7a4 
…ge load in 8.10 (elastic#165326)

Fixes elastic#165183

### Test instructions
1) install any sample data set
2) open new dashboard
3) Use "Add panel" buttons to add by-value map with only base map layer
4) Ensure map tiles fill entire map panel in dashboard

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 168412b)
kibanamachine referenced this issue Sep 1, 2023
@kibanamachine @nreese
[8.10] [maps] fix 'by value' map does not fill dashboard panel on ini…
a292464 
…tial page load in 8.10 (#165326) (#165369)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[maps] fix 'by value' map does not fill dashboard panel on initial
page load in 8.10
(#165326)](#165326)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-08-31T16:33:56Z","message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.10.0","v8.11.0"],"number":165326,"url":"https://github.com/elastic/kibana/pull/165326","mergeCommit":{"message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165326","number":165326,"mergeCommit":{"message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[maps] fix 'by value' map does not fill dashboard panel on initial page load in 8.10 nreese/kibana
4 participants
@jsanz @nreese @bhavyarm @elasticmachine