-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] update to maplibre 3.1.0 #161032
[Maps] update to maplibre 3.1.0 #161032
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elasticmachine merge upstream |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested Maps and Vega Maps. Did not test RUM visitor breakdown map. Will leave that up to the codeowners.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maplibre change log https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#310
Breaking changes that required fixes
moveend
is fired without a reason due to resize observer maplibre/maplibre-gl-js#2551). Previously the originalEvent field was the reason of this change, for example it could be a resize event from the browser. Now it is ResizeObserverEntry, see more here.