Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] update to maplibre 3.1.0 #161032

Merged
merged 10 commits into from
Jul 13, 2023
Merged

[Maps] update to maplibre 3.1.0 #161032

merged 10 commits into from
Jul 13, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jun 30, 2023

maplibre change log https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#310

Breaking changes that required fixes

@nreese
Copy link
Contributor Author

nreese commented Jul 6, 2023

@elasticmachine merge upstream

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes Feature:Maps v8.10.0 labels Jul 6, 2023
@nreese nreese marked this pull request as ready for review July 6, 2023 21:49
@nreese nreese requested a review from a team as a code owner July 6, 2023 21:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Jul 10, 2023

@elasticmachine merge upstream

@nickpeihl nickpeihl self-requested a review July 12, 2023 13:18
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Remove deprecated mapboxgl- css classes (use maplibregl- instead) (#1575)

This potentially breaking change may have downstream impacts on Vega and UX RUM.

I think we should update those CSS classes and get reviews from those codeowners. But everything looks good to me.

@nreese
Copy link
Contributor Author

nreese commented Jul 12, 2023

@elasticmachine merge upstream

@nreese nreese requested review from a team as code owners July 12, 2023 18:43
@nreese nreese requested a review from nickpeihl July 12, 2023 18:44
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested Maps and Vega Maps. Did not test RUM visitor breakdown map. Will leave that up to the codeowners.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 991 992 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.8MB +52.1KB
ux 165.8KB 165.8KB +2.0B
visTypeVega 1.7MB 1.8MB +50.4KB
total +102.5KB
Unknown metric groups

API count

id before after diff
@kbn/mapbox-gl 535 582 +47

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

miscellaneous assets size

id before after diff
maps 658.4KB 665.3KB +6.9KB
visTypeVega 496.6KB 503.5KB +6.9KB
total +13.8KB

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit 9509425 into elastic:main Jul 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants