Remove duplicate mapboxgl-css classes

[birkskyum]

These duplicate classes were introduced to bring improved backward compatibility to the 1.x release. This cleanup reverts that, which was intended to happen with the v2 release where we would start looking forward. See #203, #83

[github-actions]

Bundle size report:

Size Change: -927 B
Total Size Before: 205 kB
Total Size After: 204 kB

Output file	Before	After	Change
maplibre-gl.js	195 kB	195 kB	-307 B
maplibre-gl.css	9.65 kB	9.03 kB	-620 B

ℹ️ View Details

No major changes

[HarelM]

Great, I would consider adding to the readme a section where one could use an older version of the css file (form some CDN) in order to keep backwards compatibility, but that this file may not work for future versions.
Your call.
Otherwise looks good.

[HarelM]

Does this require version 3 now?

[birkskyum]

I updated the readme to be a bit more contemporary because for the migration guide it kind of assumed that people were using Mapbox v1 which can't be assumed anymore.

It's arguably already-deprecated classes that we remove, so in that context, I think it's okay to have it in 2.x.

[birkskyum]

I'll go through https://maplibre.org/maplibre-gl-js-docs/plugins/ to assess if any of the plugins need a PR.

[wipfli]

It is a breaking change and requires a major version bump I think.

[HarelM]

I agree. Let's see if we can introduce other breaking changes before releasing a new version so that we do less breaking changes in the future, if possible.

[wipfli]

The unit tests did not seem to cover the mapbox css stuff. Do they cover the maplibre css stuff?

[birkskyum]

Many of our unit tests use the maplibregl- classes to query etc., whereas none of them used the mapboxgl-.

[birkskyum]

But i.e. navigation_control.ts doesn't have unit tests at all right now, and it uses the classes, but the jest coverage report picks up on it now.

[HarelM]

The addition of the mapbox css classes was a mitigation to ease the transition to maplibre. The original state was that we replaced all usages of mapbox with maplibre and only after that we added back the mapbox prefix to the css, so yes, it wasn't tested as this was an after thought basically...