Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] fix 'by value' map does not fill dashboard panel on initial page load in 8.10 #165326

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 31, 2023

Fixes #165183

Test instructions

  1. install any sample data set
  2. open new dashboard
  3. Use "Add panel" buttons to add by-value map with only base map layer
  4. Ensure map tiles fill entire map panel in dashboard

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0 labels Aug 31, 2023
@nreese nreese marked this pull request as ready for review August 31, 2023 12:49
@nreese nreese requested a review from a team as a code owner August 31, 2023 12:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson self-requested a review August 31, 2023 14:09
@nreese
Copy link
Contributor Author

nreese commented Aug 31, 2023

@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and wasn't able to repro the issue. LGTM!

@nreese
Copy link
Contributor Author

nreese commented Aug 31, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 168412b into elastic:main Aug 31, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 31, 2023
…ge load in 8.10 (elastic#165326)

Fixes elastic#165183

### Test instructions
1) install any sample data set
2) open new dashboard
3) Use "Add panel" buttons to add by-value map with only base map layer
4) Ensure map tiles fill entire map panel in dashboard

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 168412b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 1, 2023
…tial page load in 8.10 (#165326) (#165369)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[maps] fix 'by value' map does not fill dashboard panel on initial
page load in 8.10
(#165326)](#165326)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-08-31T16:33:56Z","message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.10.0","v8.11.0"],"number":165326,"url":"https://github.com/elastic/kibana/pull/165326","mergeCommit":{"message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165326","number":165326,"mergeCommit":{"message":"[maps]
fix 'by value' map does not fill dashboard panel on initial page load in
8.10 (#165326)\n\nFixes
https://github.com/elastic/kibana/issues/165183\r\n\r\n### Test
instructions\r\n1) install any sample data set\r\n2) open new
dashboard\r\n3) Use \"Add panel\" buttons to add by-value map with only
base map layer\r\n4) Ensure map tiles fill entire map panel in
dashboard\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"168412ba7b61bde4ed810ef34e2e951d4e68d0fc"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard][map] 'by value' map does not fill dashboard panel on initial page load in 8.10
5 participants