Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard][maps] fix 'by value' map does not fill dashboard panel on initial page load #155554

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[dashboard][maps] fix 'by value' map does not fill dashboard panel on initial page load #155554

merged 1 commit into from
Apr 21, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 21, 2023 •
edited
Loading

Fixes #155553

Following steps in issue now renders map as expected
Screen Shot 2023-04-21 at 1 18 54 PM

@nreese nreese marked this pull request as ready for review April 21, 2023 19:15
@nreese nreese requested a review from a team as a code owner April 21, 2023 19:15
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes Feature:Maps v8.8.0 labels Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +72.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice fix!

@nreese nreese merged commit f0106b1 into elastic:main Apr 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2023
@nreese nreese mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dashboard][map] 'by value' map does not fill dashboard panel on initial page load
5 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine