Fix flags for dev build #31955
Merged
Fix flags for dev build #31955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the flags used when the environmet varialbe DEV=true is set. This allows to generate binaries without code optmisation and debug symbols.
botelastic
bot
added
the
needs_team
belimawr
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
belimawr
requested review from
faec and
leehinman
and removed request for
a team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
cmacknz
reviewed
Jun 16, 2022
cmacknz
approved these changes
Jun 16, 2022
faec
approved these changes
Jun 16, 2022
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz
added a commit
to cmacknz/beats
that referenced
this pull request
Jul 7, 2022
This reverts commit a787169.
cmacknz
added a commit
that referenced
this pull request
Jul 7, 2022
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 7, 2022
…tomation * upstream/main: [main](backport elastic#32235) docs: Prepare Changelog for 8.3.2 (elastic#32253) Revert "Fix flags for dev build (elastic#31955)" (elastic#32250) [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (elastic#32243) x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (elastic#32196) packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows (elastic#32180)
cmacknz
added a commit
to cmacknz/beats
that referenced
this pull request
Jul 8, 2022
…)" This reverts commit ba5d0cb.
cmacknz
added a commit
that referenced
this pull request
Jul 8, 2022
* Force DEV=0 when cross compiling for darwin/amd64. elastic/golang-crossbuild#217 * Revert "Revert "Fix flags for dev build (#31955)" (#32250)" This reverts commit ba5d0cb.
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Fix the flags used when the environmet varialbe DEV=true is set. This allows to generate binaries without code optmisation and debug symbols. Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Force DEV=0 when cross compiling for darwin/amd64. elastic/golang-crossbuild#217 * Revert "Revert "Fix flags for dev build (#31955)" (#32250)" This reverts commit ba5d0cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the flags used when the environmet varialbe DEV=true is set. This
allows to generate binaries without code optmisation and debug
symbols.
Why is it important?
It allows us to easily generate binaries for debugging.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Author's Checklist## How to test this PR locally## Related issues## Use cases## Screenshots## Logs