Skip to content

Commit

Permalink
Fix flags for dev build (#31955)
Browse files Browse the repository at this point in the history
Fix the flags used when the environmet varialbe DEV=true is set. This
allows to generate binaries without code optmisation and debug
symbols.

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
  • Loading branch information
2 people authored and chrisberkhout committed Jun 1, 2023
1 parent 601ffc5 commit 96f1809
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG-developer.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ The list below covers the major changes between 7.0.0-rc2 and main only.
- Avoid panicking in `add_fields` processor when input event.Fields is a nil map. {pull}28219[28219]
- Drop event batch when get HTTP status 413 from Elasticsearch to avoid infinite loop {issue}14350[14350] {pull}29368[29368]
- Allow to use metricbeat for named mssql instances. {issue}24076[24076] {pull}30859[30859]
- Setting DEV=true when running `mage build` now correctly generates binaries without optimisations and with debug symbols {pull}31955[31955]

==== Added

Expand Down
2 changes: 1 addition & 1 deletion dev-tools/mage/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func DefaultBuildArgs() BuildArgs {

if DevBuild {
// Disable optimizations (-N) and inlining (-l) for debugging.
args.ExtraFlags = append(args.ExtraFlags, `-gcflags`, `"all=-N -l"`)
args.ExtraFlags = append(args.ExtraFlags, `-gcflags=all=-N -l`)
} else {
// Strip all debug symbols from binary (does not affect Go stack traces).
args.LDFlags = append(args.LDFlags, "-s")
Expand Down

0 comments on commit 96f1809

Please sign in to comment.