Force DEV=0 when cross-compiling to darwin/amd64 #32274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
added
ci
Team:Automation
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
|
/package |
2 tasks
|
Packaging succeeded (https://beats-ci.elastic.co/job/Beats/job/packaging/job/PR-32274/2/) and the E2E test job is known to be flaky. Merging this to unblock everybody's builds. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Force DEV=0 when cross compiling for darwin/amd64. elastic/golang-crossbuild#217 * Revert "Revert "Fix flags for dev build (#31955)" (#32250)" This reverts commit ba5d0cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work around for elastic/golang-crossbuild#217 where the package target is broken when setting
DEV=1with the Go 1.17.11 crossbuild image.I have also un-reverted the change for #31955 since it was not actually the root cause. It does not cause any issues when tested locally using the Go 1.17.10 image that is known to work.