Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix flags for dev build (#31955)" #32250

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jul 7, 2022

This reverts commit a787169.

This change unexpectedly breaks the packaging step on Mac. Reverting until we can find a cross-platform solution or just make these flags a Linux only option.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 7, 2022
@cmacknz cmacknz self-assigned this Jul 7, 2022
@cmacknz cmacknz requested a review from a team as a code owner July 7, 2022 12:16
@cmacknz cmacknz requested review from faec and leehinman and removed request for a team July 7, 2022 12:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 7, 2022
@cmacknz cmacknz requested a review from belimawr July 7, 2022 12:17
@cmacknz
Copy link
Member Author

cmacknz commented Jul 7, 2022

/package

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-07T12:17:10.123+0000

  • Duration: 97 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 22405
Skipped 1937
Total 24342

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz merged commit ba5d0cb into elastic:main Jul 7, 2022
@cmacknz cmacknz deleted the fix-broken-packaging-step branch July 7, 2022 13:56
v1v added a commit to v1v/beats that referenced this pull request Jul 7, 2022
…tomation

* upstream/main:
  [main](backport elastic#32235) docs: Prepare Changelog for 8.3.2 (elastic#32253)
  Revert "Fix flags for dev build (elastic#31955)" (elastic#32250)
  [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (elastic#32243)
  x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (elastic#32196)
  packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows (elastic#32180)
cmacknz added a commit to cmacknz/beats that referenced this pull request Jul 8, 2022
cmacknz added a commit that referenced this pull request Jul 8, 2022
* Force DEV=0 when cross compiling for darwin/amd64.

elastic/golang-crossbuild#217

* Revert "Revert "Fix flags for dev build (#31955)" (#32250)"

This reverts commit ba5d0cb.
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Force DEV=0 when cross compiling for darwin/amd64.

elastic/golang-crossbuild#217

* Revert "Revert "Fix flags for dev build (#31955)" (#32250)"

This reverts commit ba5d0cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants