-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix flags for dev build (#31955)" #32250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a787169.
cmacknz
added
the
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
label
Jul 7, 2022
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 7, 2022
/package |
belimawr
approved these changes
Jul 7, 2022
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 7, 2022
…tomation * upstream/main: [main](backport elastic#32235) docs: Prepare Changelog for 8.3.2 (elastic#32253) Revert "Fix flags for dev build (elastic#31955)" (elastic#32250) [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (elastic#32243) x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (elastic#32196) packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows (elastic#32180)
cmacknz
added a commit
to cmacknz/beats
that referenced
this pull request
Jul 8, 2022
…)" This reverts commit ba5d0cb.
cmacknz
added a commit
that referenced
this pull request
Jul 8, 2022
* Force DEV=0 when cross compiling for darwin/amd64. elastic/golang-crossbuild#217 * Revert "Revert "Fix flags for dev build (#31955)" (#32250)" This reverts commit ba5d0cb.
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Force DEV=0 when cross compiling for darwin/amd64. elastic/golang-crossbuild#217 * Revert "Revert "Fix flags for dev build (#31955)" (#32250)" This reverts commit ba5d0cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a787169.
This change unexpectedly breaks the packaging step on Mac. Reverting until we can find a cross-platform solution or just make these flags a Linux only option.