Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdms kpi #1942

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Mdms kpi #1942

merged 3 commits into from
Nov 29, 2024

Conversation

ashish-egov
Copy link
Contributor

@ashish-egov ashish-egov commented Nov 29, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced data fetching for microplanning configurations, including DssKpiConfigs.
    • Updated searchDssChartV2 function to include a new configuration parameter for improved chart data retrieval.
  • Improvements

    • Simplified chart filtering logic to include all charts from campaignConfig.
    • Refined state management and error handling in the PlanInbox component for better user experience.
    • Improved session data management in the App component to prevent data leakage.
  • Bug Fixes

    • Adjusted prop formatting in the GenericKpiFromDSS component to enhance readability.

@ashish-egov ashish-egov requested a review from a team as a code owner November 29, 2024 10:53
Copy link
Contributor

coderabbitai bot commented Nov 29, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes involve modifications to the searchDssChartV2 function to include a new required parameter, config, alongside existing parameters. This adjustment necessitated updates in the useKpiDssSearch hook to accommodate the new parameter when invoking the function. Additionally, the PlanInbox component underwent minor formatting changes and enhancements in state management and data fetching logic. The index.js file also saw updates to the useCustomMDMS hook to include a request for DssKpiConfigs, alongside improved session data management.

Changes

File Change Summary
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js - Modified searchDssChartV2 to require a new config parameter.
- Updated input validation and error messages.
- Simplified chart filtering logic to include all charts.
- Maintained error handling and control flow.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js - Added import for useMyContext and retrieved DssKpiConfigs from context.
- Updated searchDssChartV2 call to include config parameter.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js - Adjusted props formatting for GenericKpiFromDSS.
- Enhanced state management and effect hooks for data fetching.
- Maintained existing error handling for API calls.
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js - Modified useCustomMDMS to include a request for DssKpiConfigs.
- Updated useEffect hooks for improved session data management.

Possibly related PRs

  • added new hook for microplans search screen #1587: The useKpiDssSearch hook now includes the config parameter when calling searchDssChartV2, which is directly related to the changes made in the main PR where searchDssChartV2 was updated to require a config parameter.
  • Added action bar for pop inbox screen #1622: The PopInbox component's updates include the use of the searchDssChartV2 function for fetching KPI data, linking it to the changes in the main PR.
  • planInbox console #1623: The PlanInbox component's modifications involve the integration of the searchDssChartV2 function, which is relevant to the main PR's updates.
  • ui fixes #1798: The CSS changes may relate to the visual presentation of KPIs, which are affected by the changes in the main PR.
  • fixed plan inbox issues #1915: The updates in PlanInbox include logic that may interact with the KPI data fetched by searchDssChartV2, connecting it to the main PR.
  • Changes in facility kpis #1939: The modifications to the DssChartConfig directly relate to the functionality of the searchDssChartV2 function, making it relevant to the main PR.

Suggested reviewers

  • nipunarora-eGov

🐇 In the code, we hop and play,
New configs join us on the way!
With charts and hooks, we weave a tale,
In the microplan, we shall not fail.
So let’s embrace this change with cheer,
For better data is finally here! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range comments (4)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js (1)

Line range hint 11-24: Enhance error messages with search criteria

The error messages could be more helpful by including the values that were searched for. This would make debugging easier.

         const moduleConfig = config.find(config => config.module === module);
 
         if (!moduleConfig) {
-            console.error(`No DSS Chart configuration found for module: ${module}`);
+            console.error(`No DSS Chart configuration found for module: "${module}" in ${config.length} available configs`);
             throw new Error(`No DSS Chart configuration found for module: ${module}`);
         }
 
         // Find the configuration for the given campaignType
         const campaignConfig = moduleConfig.kpiConfig.find(kpi => kpi.campaignType === campaignType);
 
         if (!campaignConfig) {
-            console.error(`No DSS Chart configuration found for campaignType: ${campaignType}`);
+            console.error(`No DSS Chart configuration found for campaignType: "${campaignType}" in module: "${module}"`);
             throw new Error(`No DSS Chart configuration found for campaignType: ${campaignType}`);
         }
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (3)

Line range hint 48-67: Optimize state management to reduce complexity and potential re-renders.

Consider the following optimizations:

  1. Combine related state variables into a single object
  2. Use useReducer for complex state updates
  3. Memoize expensive computations
- const [villagesSlected, setVillagesSelected] = useState(0);
- const [showTab, setShowTab] = useState(true);
- const [jurisdiction, setjurisdiction] = useState([]);
- const [censusJurisdiction, setCensusJurisdiction] = useState([]);
- const [hierarchyLevel, setHierarchyLevel] = useState("");
- const [censusData, setCensusData] = useState([]);
- const [boundaries, setBoundaries] = useState([]);

+ const [planState, setPlanState] = useReducer(planReducer, {
+   villagesSelected: 0,
+   showTab: true,
+   jurisdiction: [],
+   censusJurisdiction: [],
+   hierarchyLevel: "",
+   censusData: [],
+   boundaries: [],
+ });

+ // Add a reducer function to handle state updates
+ function planReducer(state, action) {
+   switch (action.type) {
+     case 'SET_VILLAGES':
+       return { ...state, villagesSelected: action.payload };
+     case 'SET_JURISDICTION':
+       return { 
+         ...state, 
+         jurisdiction: action.payload,
+         censusJurisdiction: action.payload 
+       };
+     // Add other cases as needed
+     default:
+       return state;
+   }
+ }

Line range hint 147-187: Enhance error handling and loading state management.

The current error handling could be improved to provide better user feedback and error recovery:

  1. Add error boundaries to isolate failures
  2. Consolidate loading states
  3. Implement retry mechanisms for failed API calls
+ import { ErrorBoundary } from 'react-error-boundary';

+ const ErrorFallback = ({ error, resetErrorBoundary }) => {
+   return (
+     <div role="alert">
+       <p>{t("SOMETHING_WENT_WRONG")}</p>
+       <pre>{error.message}</pre>
+       <button onClick={resetErrorBoundary}>{t("TRY_AGAIN")}</button>
+     </div>
+   );
+ };

+ // Consolidate loading states
+ const isLoading = 
+   isLoadingPlanObject ||
+   isPlanEmpSearchLoading ||
+   isLoadingCampaignObject ||
+   isWorkflowLoading ||
+   isProcessLoading ||
+   mutation.isLoading ||
+   isPlanWithCensusLoading ||
+   isCountPlanWithCensusLoading;

  return (
+   <ErrorBoundary
+     FallbackComponent={ErrorFallback}
+     onReset={() => {
+       refetchPlan();
+       refetchPlanWithCensus();
+     }}
+   >
      {isLoading ? (
        <Loader />
      ) : (
        // Component content
      )}
+   </ErrorBoundary>
  );

Line range hint 1-24: Optimize component performance through code splitting and memoization.

The component is handling too many responsibilities and could benefit from:

  1. Splitting into smaller, focused components
  2. Memoizing expensive computations
  3. Reducing re-renders
+ import { memo, useMemo, useCallback } from 'react';

+ // Extract table columns configuration to a separate component
+ const TableColumns = memo(({ t, handleTimelineClick }) => {
+   return useMemo(() => [
+     // ... column definitions
+   ], [t, handleTimelineClick]);
+ });

+ // Extract filter section to a separate component
+ const FilterSection = memo(({ 
+   activeFilter,
+   onFilter,
+   clearFilters,
+   selectedFilter 
+ }) => {
+   return (
+     <InboxFilterWrapper
+       options={activeFilter}
+       onApplyFilters={onFilter}
+       clearFilters={clearFilters}
+       defaultValue={{ [selectedFilter]: activeFilter[selectedFilter] }}
+     />
+   );
+ });

const PlanInbox = () => {
  // ... existing code
📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 61dd04e and 301f631.

📒 Files selected for processing (4)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js (2 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (1 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1)

Pattern **/*.js: check

📓 Learnings (1)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)
Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.
🔇 Additional comments (7)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (4)

Line range hint 1-24: Overall implementation looks good with minor improvements needed

The changes to include DssKpiConfigs are well-structured and maintain the hook's functionality. The implementation:

  1. ✅ Properly retrieves config from context
  2. ✅ Correctly passes all parameters to searchDssChartV2
  3. ✅ Maintains existing query functionality

Consider the suggested improvements for error handling and caching strategy, but otherwise, the changes look good.


Line range hint 13-18: Enhance error handling and consider caching strategy

  1. The current error handling only logs to console. Consider:
    • Proper error reporting to monitoring systems
    • User-friendly error handling
  2. Setting both cacheTime and staleTime to 0 means no caching. Consider if this is intentional or if some caching would be beneficial.

Let's verify the searchDssChartV2 implementation to ensure it properly handles the new config parameter.

✅ Verification successful

Error handling is appropriate, but caching strategy needs review

The implementation of searchDssChartV2 shows proper error handling with:

  • Input validation with descriptive error messages
  • Configuration validation with specific error messages
  • API error handling with proper error propagation
  • Structured try-catch blocks with error transformation

However, the caching strategy in the React Query setup (cacheTime: 0, staleTime: 0) might need reconsideration as:

  • The implementation makes multiple parallel API calls for visualization codes
  • The API responses could be cached briefly to improve performance
  • The useCache: false in the service implementation reinforces this no-cache approach

Recommendations:

  • Consider setting reasonable cache times (e.g., 30 seconds) to prevent unnecessary API calls
  • Keep error handling as is since it's well implemented
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify searchDssChartV2 implementation
# Expected: Find the implementation and verify it handles the config parameter

# Search for searchDssChartV2 implementation
ast-grep --pattern 'const searchDssChartV2 = $_' || ast-grep --pattern 'function searchDssChartV2($_)'

# Look for related test files
fd "searchDssChartV2.test" --type f

Length of output: 17322


2-2: Verify the context utility implementation

Let's ensure the context utility exists and properly exports the useMyContext hook.

✅ Verification successful

The context utility is properly implemented

The useMyContext hook is correctly exported from ../utils/context.js and provides access to the context state and dispatch function through React's Context API. The implementation follows React best practices for context management.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the context utility implementation
# Expected: Find the useMyContext export in the context utility

# Check if the context utility exists and exports useMyContext
ast-grep --pattern 'export { useMyContext }' || ast-grep --pattern 'export const useMyContext'

# Verify the file exists
fd "context.js" --type f

Length of output: 1007


Script:

#!/bin/bash
# Let's check the content of the context.js file in the microplan module
cat "health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/context.js"

# Also search for any useMyContext definition in the codebase
ast-grep --pattern 'const useMyContext = $_'

Length of output: 1628


6-6: Verify DssKpiConfigs structure and initialization

The code assumes DssKpiConfigs exists in the context state. Let's verify its structure and initialization.

Also applies to: 11-11

✅ Verification successful

Let me gather more information about the context initialization and usage.


Let me try one more search to understand how DssKpiConfigs is being used and initialized.


Let me check one final aspect about the initialization and reducer.


Based on the gathered information, I can now provide the final response:

DssKpiConfigs is properly initialized through MDMS

The code shows that DssKpiConfigs is properly initialized through the MDMS (Master Data Management System) configuration. It is:

  • Loaded as part of the MDMS data fetch in the employee/index.js file
  • Included in the MDMS modules list: { name: "DssKpiConfigs" }
  • Dispatched to the context state through the reducer action "MASTER_DATA"
  • Properly accessed in useKpiDssSearch.js through the context state
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify DssKpiConfigs structure and initialization
# Expected: Find where DssKpiConfigs is defined and initialized in the context

# Search for DssKpiConfigs definition/usage
rg "DssKpiConfigs" -A 5

# Look for MDMS config related to DssKpiConfigs
fd "mdms-config" --type f --exec rg "DssKpiConfigs" {} \;

Length of output: 1733


Script:

#!/bin/bash
# Check the context provider and state initialization
ast-grep --pattern 'const $_ = createContext($$$)'

# Look for dispatch calls related to DssKpiConfigs
rg "dispatch.*DssKpiConfigs" -A 3

# Check the MDMS API call structure
rg "MDMS.search" -A 5

Length of output: 1316


Script:

#!/bin/bash
# Look for the MyContext provider implementation and state initialization
rg -l "MyContext.Provider" | xargs rg "MyContext.Provider" -B 5 -A 5

# Check for MDMS related configuration or initialization
rg "MDMS.*DssKpiConfigs" -B 2 -A 2

# Look for any state updates related to DssKpiConfigs
rg "setState.*DssKpiConfigs|reducer.*DssKpiConfigs" -B 2 -A 2

Length of output: 2432


Script:

#!/bin/bash
# Check the reducer and initial state in the context file
rg -l "initialState.*=|reducer.*=" | xargs rg "initialState.*=|reducer.*=" -B 2 -A 10

# Look for any DssKpiConfigs related action types
rg "type.*DssKpiConfigs" -A 2

# Check the employee index file where DssKpiConfigs is mentioned
cat health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js

Length of output: 31411

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js (2)

Line range hint 1-116: Overall implementation looks good!

The changes maintain good error handling, separation of concerns, and improve flexibility by externally injecting configuration. The code is well-structured and follows good practices.


Line range hint 40-48: Verify removal of active charts filtering

The code no longer filters for active charts. Please confirm if this is intentional and that chart activation is now handled at the configuration level.

✅ Verification successful

Let me gather more information about the chart configuration structure specifically in the microplan module.


Let me try one more search to find any previous versions or related configuration files in the microplan module.


Let me check the DssChartConfig.js file that was found to understand how charts are configured.


Chart activation is handled at configuration level - removal of filtering is correct

After examining the DssChartConfig.js file, I can confirm that chart activation is indeed handled at the configuration level. Each chart in the configuration has an explicit active: true property, making runtime filtering unnecessary. The removal of active charts filtering from the code is correct as the configuration already ensures only active charts are included.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any references to chart activation in the codebase
rg -i "chart.*active|active.*chart" --type js

# Search for the configuration structure to understand where chart activation might be handled
ast-grep --pattern 'const $config = {
  $$$
  charts: [
    $$$
  ]
  $$$
}'

Length of output: 1125


Script:

#!/bin/bash
# Search for chart configuration in microplan module
rg -A 10 "campaignConfig.*charts" --type js

# Look for previous implementation to understand the change
git log -p -- health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/services/searchDssChartV2.js

# Search for any chart filtering logic in microplan
rg "charts.*filter" --type js health/micro-ui/web/micro-ui-internals/packages/modules/microplan/

Length of output: 1686


Script:

#!/bin/bash
# Search for any chart-related configuration files in microplan
fd -e js -e json . health/micro-ui/web/micro-ui-internals/packages/modules/microplan/ --exec rg -l "charts.*:.*\[" {}

# Look for campaign configuration structure
ast-grep --pattern 'const campaignConfig = {
  $$$
  charts: [
    $$$
  ]
  $$$
}'

# Search for any chart activation logic in the configuration
rg -B 5 -A 5 "charts.*=.*\[" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/

Length of output: 401


Script:

#!/bin/bash
# Check the content of the chart configuration file
cat health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/DssChartConfig.js

# Look for any imports of this configuration file
rg -l "DssChartConfig" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/

# Search for any active/inactive chart logic in the configuration
rg -B 2 -A 2 "active.*:.*" health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/DssChartConfig.js

Length of output: 17561

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1)

103-103: LGTM! Verify MDMS configuration exists.

The addition of DssKpiConfigs to the MDMS request follows the existing pattern and is properly integrated with the context state management.

Let's verify the MDMS configuration exists:

…lan/src/hooks/useKpiDssSearch.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 301f631 and 6dbb090.

📒 Files selected for processing (1)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js (2)

2-2: Verify the context file path

The import path seems correct, but let's verify the existence of the context file.

✅ Verification successful

Import path is correct and the context hook exists

The import statement is valid as:

  • The context file exists at the correct relative path: ../utils/context.js
  • The file properly exports the useMyContext hook
  • The hook is implemented as a proper React context consumer
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the context file and its exports
# Expected: Find the context file and verify it exports useMyContext

# Check if the context file exists relative to this file's location
fd -p "utils/context.{js,jsx,ts,tsx}" "health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src"

# Verify the export of useMyContext
ast-grep --pattern 'export { $$ useMyContext $$ }'

Length of output: 493


Script:

#!/bin/bash
# Let's try a different approach to verify the context file and its exports

# First, let's find the context file using simpler fd command
fd context "health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils"

# Then let's check for useMyContext export using ripgrep
rg "export.*useMyContext" "health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils" -l

# Also search for any definition of useMyContext
rg "useMyContext" "health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils" -A 2

Length of output: 797


Line range hint 13-17: Verify if zero cache settings are intentional

Setting both cacheTime and staleTime to 0 means React Query won't cache the results at all. This could lead to unnecessary API calls and potential performance issues.

✅ Verification successful

Zero cache settings are intentional and consistent with the module's pattern

Looking at the codebase, setting both cacheTime and staleTime to 0 is a deliberate pattern used consistently across the microplan and campaign-manager modules for real-time data requirements. Specifically:

  • The same pattern (cacheTime: 0, staleTime: 0) is used in related hooks:
    • useSavedMicroplans.js
    • useSavedMicroplansWithCampaign.js
    • useGenerateIdCampaign.js
    • Various campaign-manager components

This indicates a deliberate design choice to always fetch fresh data for these analytics and campaign-related queries, which is reasonable given the real-time nature of the data being displayed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Look for similar query patterns in the codebase
# Expected: Find other react-query usages to understand the caching strategy

# Search for react-query cache settings
rg -A 2 "useQuery.*cacheTime.*staleTime" --type js

Length of output: 52


Script:

#!/bin/bash
# Let's try a broader search for useQuery patterns to understand the caching strategy
rg "useQuery.*{" --type js -A 5

# Also search specifically for cacheTime and staleTime separately
rg "cacheTime:|staleTime:" --type js -A 2

Length of output: 23144

@ashish-egov ashish-egov merged commit b53f239 into console Nov 29, 2024
3 checks passed
@ashish-egov ashish-egov deleted the mdmsKpi branch November 29, 2024 11:00
jagankumar-egov added a commit that referenced this pull request Dec 9, 2024
* fixed assumption audit fixes (#1758)

* fixed draft issue of Setup campaign (#1757)

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* Summary css fix (#1755)

* updated css for summary screen

* removed log

* added null check

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Breadcrumb for usermanagement (#1761)

* Breadcrumb changes

* console.log removed

* indentations

* Finalised microplan download (#1762)

* Feat : Added download button for finalised microplans

* Added Todo

* fixed HCMPRE-776 and removed updated old validation (#1763)

* fixed HCMPRE-776 and removed updated old validation

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/MapView.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update MyCampaign.js

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignDates.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update CampaignDates.js

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update SetupCampaign.js

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix key (#1764)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Fixed UiCustomisation Digit issue (#1766)

Checking UisCustomisation

* Fixed double selection of boundaries (#1765)

Update MultiSelectDropdown.js

* Fixed loader,breadcrumb,table cells css and added placeholder text fo… (#1769)

Fixed loader,breadcrumb,table cells css and added placeholder text for assumption fields

* fixed targetvalidation and added no results in boundary (#1768)

* Dynamic column pop inbox (#1770)

* Added dynamic column inside pop inbox

* updated status to action in status logs

* updated status log

* added comment logs for edit population

* updated css version

* updated code rabbit comment and css version

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Feature/bug (#1773)

* z-index and camapaign-name in preview

* ui-ux-demo-review

* version updates

* ver

* Update ViewHierarchy.js

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* Updated the search dropdown (#1776)

updated the search dropdown

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Info ToolTip added (#1775)

* Added info icon on formula and assumptions

* Incremented CSS version

* Vesrion update (#1778)

* updated react-components version to fix icon issues in inbox screen

* updated versions everywhere

* myMicroplanFixes (#1777)

* My microplan data fixes, localisation fixes

* setup response screen fixes, breadcrumb localisation code correctify

* search bar fix

* fixes

* ADD NEW LOCALE

* roletable fixes for mobile number search, qa issue fix

* FIXES

* quickfixes

* quick fixes/ Tagging UI UX fixes

* fix

* added locale

* census table assignee issue fixes

* role table pop up css fix and my microplan click fix

* fixes and stepper click enable for back

* added user tag fixes

* UserAccessfixes

* Custom Assumption - Custom Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Updated date formate (#1779)

* updated date formate and css

* updated css

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Fix for cycle draft ::changes for the draft flow (#1780)

* Fixed assumption form multi save (#1781)

Update SetupMicroplan.js

* user tagging fixes (#1782)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Usermanagement row on click redirect (#1783)

* Changes to usermanagement redirext on row click

* changes to onRow click in userManagement

* console removed

* changes

* null check

* changes

* removing extra mdms call

* changing useState

* removed var

* changes

* changes

* Plan and Pop inbox changes (#1784)

* removed popup for facilitya and population upload

* updated plan inbox

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Feature/bugs (#1785)

* bug/boundary

* changed field name

* added something

* Update checklistSearchConfig.js

* Update ViewHierarchy.js

* fixes

* fixes1

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewHierarchy.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fixed order in boundary details and changed hierarchy master (#1786)

* added the checks for the update campaign flow (#1788)

* Open Boundary Management ui Info pending changes  (#1789)

* pending changes

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useBoundaryHome.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/GeoPode.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/GeoPode.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Reverted action in assign to all, updated the column heading with pro… (#1790)

* reverted action in assign to all, updated the column heading with projecttype

* removed logs

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Usermanagement css and boundaryScreen css (#1791)

Changes to userManagement, css for boundary

* Vehicle Change Assumptions & Formula (#1787)

* user tagging fixes

* Vehicle Assumptions and Vehicle Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* yarn

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* css fixes (#1792)

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* LCOALISATION FIXES (#1793)

* user tagging fixes

* Vehicle Assumptions and Vehicle Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* yarn

* locaisaton code fixes

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* some-ui-fixes (#1794)

* some-ui-fixes

* version updates

* fixed boundary selection dropdown issue (#1796)

* fixed boundary selection dropdown issue

* fixed search juridiction dropdown

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Allowed to update the name of microplan (#1795)

* Allowed to update the name of microplan

* changed hardcoded date to 30 from 100

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* demo issue fixes (#1797)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* ui fixes (#1798)

* Added retry of failed campaign

* stepper rvert back (#1799)

* ESTIMATION & FORMULA FIXES (#1804)

* user tagging fixes

* Vehicle Assumptions and Vehicle Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* yarn

* locaisaton code fixes

* estimationa and formula fixes

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* error toast and checklist updates (#1805)

error taost and cehcklist updates

* HCMPRE 1131 (#1807)

* user tagging fixes

* Vehicle Assumptions and Vehicle Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* yarn

* locaisaton code fixes

* estimationa and formula fixes

* my microplan fix

* fixes

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Updated sidebar for microplan (#1802)

* Updated sidebar for microplan

* Update index.scss

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>
Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* style change of toolTip (#1806)

* toast and minor ui (#1809)

* ui/ux fixes (#1810)

* Changes to AssummptionList and stepper disable in setupConfig (#1811)

* Changes to assumptions list

* setupCompleted changes

* Formula View, and Select Acitivity Screen CSS changes (#1803)

* select-activity-commit

* Hover over formulaConfigView

* margin adjust

* removed console

* css changes

* package update

* changes to css

* package css update

* Revert "Allowed to update the name of microplan (#1795)" (#1812)

This reverts commit e32aad6.

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* updated message for header and label and added validation for max length (#1813)

* Cleaned up boundary Management code and add some validations

* redirect and ui (#1814)

* Assumptionlist fix (#1815)

changes

* changes in the delivery type and selection of boundary (#1816)

* to be picked (#1819)

* to be picked

* checklist and other changes

* role table fixes, drop down fix, pop up fix, use tag fix (#1820)

* user tagging fixes

* Vehicle Assumptions and Vehicle Formula

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* yarn

* locaisaton code fixes

* estimationa and formula fixes

* my microplan fix

* fixes

* pull fixes

* user tag changes

* fixes

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fetch data type from mdms (#1822)

* fixed app delivery condition (#1825)

* not selected added in single value list (#1824)

* not selected added in single value list

* isActive added

* one more fix

* Facility dropdown (#1817)

* Added single dropdown in facilityCatchment

* tenantId fix

* Hierarchies fix

* Microplan name update (#1821)

* updated start date for campaign

* added update microplan name changes

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Internal demo fixes (#1827)

* disabled the viewer card

* updated suggested microplan name formate

* updated assignee to assigner in timeline wrapper

* updated button side in my microplan screen

* updated sucurity and accessibility edit buttons

* commented tranportation mode from accessibility details

* added assignee next to village updated comment

* updated plan inbox

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* tenant logo css fix (#1828)

* Facility data fix (#1829)

FacilityData Fix

* Added boundary manager access to the home card

* Updated activity selection screen to have view also (#1830)

updated activity selection screen to have view also

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Added confirmation pop up to finalise actions (#1832)

added confimation pop up to finalize actions

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Popup for userAccess boundary area and toast message for assign unassign (#1831)

* Changed localization

* Loc

* Changes for popup in userAccess

* changes

* My MICROPLAN fixes, formula fixes (#1835)

* Hcmpre 1290 (#1834)

* fixed app delivery condition

* added my microplan screen

* changes in the url

* changes

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* Inbox (#1838)

* fixed app delivery condition

* fixed hover issue on search screen

* demo review changes in boudnary management (#1836)

* demo review changes in boudnary management

* different download template for hierarchy from geopode and completely new

* info cards added

* code clean

* Update searchSavedPlansWithCampaign.js (#1839)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Space (#1840)

* fixed app delivery condition

* added space

* fixed miner issues (#1837)

* fixed miner issues

* fixed pop inbox issue

* fixed status log issue

* Update PopInbox.js

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>
Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Update searchSavedPlansWithCampaign.js (#1841)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Gepspatial map view (#1842)

* added minor css changes and basic logic for geospatial view

* updated css version

* updated chooseactivity screen

* fixed syntax issue

* PO finding fixes (#1843)

* Fix campaign Type in draft (#1846)

* Plan Inbox patch fix (#1847)

* added workflow for toast message

* updated workflow button color

* added count for assign to me and all tabs

* added back button

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Go Back button and microplan name quotes fix (#1844)

* Updated the core and other component version for landing page card  override

* Po finding fixes2 (#1845)

* added tooltip for residing boundary

* registered hierarchy tooltip inside component

* added different workflow message and alert header

* updated button color for workflow actions

* added info icons in select activity card

* added back button

* fixed action for facility

* updated css version

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Summary user role tagging and Response Screen (#1852)

* Changes ro userAccessTableWrapper

* Response Screen

* comment removed

* minor updates (#1853)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* toast localistaion (#1855)

* updated core component & css version

* updating the module versions

* Reverting the libraries version update

* Updated all the core component version from 1.8.3 to 1.8.10

* PO fixes (#1857)

* reverted column freeze as it was causing issues (#1858)

reverted column fix as it was causing issues

* Added column in sorted way, added assignee, added total pop (#1859)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* added serving facility (#1860)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* updated code (#1861)

* Formcomposer action bar fixes (#1862)

* added serving facility

* form composer action bar fix

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Updated few localisation messages

* added loader screen to ftech data from microplan integration screen

* Updated UI Customizations file

* Approved microplan integration

* Added toast & success for api response

* plan inbox assignee fix (#1863)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* formula and assumption refresh issue (#1864)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* minor changes (#1866)

* Action bar fixes, session fixes (#1867)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

* action bar hidden fixes, session fixes

* Update index.js

* Update index.js

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Download Button  (#1865)

* Loc changes to popInbox

* Loc

* Changes

* UICust update

* css package update

* Changes

* changes

* Update UICustomizations.js

* Name of file

* For Download update

* UI cust changes

* added return in UI

* Changes

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* User Role being displayed in Pop, Plan and Fac (#1854)

* changes localizations

* Adding userName and their roles

* resolved conflict

* css package update

* UIcustomization dropdown changes

* pop-inbox changes

* package update

* loc added

* loc changes

* dropdown options changed

* UICust making same as in example

* UnassignPopup

* comments

* loc

* Loader added

* changes

* changes to roletablecomposer for unassign popup

* changes

* Facility Catchment

* reverted facility popup

* Changes

* KPI Card

* package update

* Facility data keys

* changes according to comments

* Changes

* rowOn click redirection

* Dummy Data removed

* removed import

* removed for residing boundary

* removed 5000

* package update for css

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* fixes (#1869)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

* action bar hidden fixes, session fixes

* fixes

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* patch fix (#1868)

* route back to home on back

* fixed refresh issue for pop inbox

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* polling fix (#1870)

* polling fix

* Update TimelineComponent.js

* assumptions fixes (#1871)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Facility pop up fix (#1872)

* Localizations and Actions being cut (#1874)

* Changes

* Package update

* Disabled updating security and accessibility details after finalize  … (#1873)

Disabled updating security and accessibility details after finalize  facility catchment

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Update PopInbox.js (#1875)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* scroll (#1876)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Update FacilityPopup.js (#1877)

* qquickfix (#1878)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

* action bar hidden fixes, session fixes

* fixes

* fix

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Updated the microplan integration piece

* adhoc changes (#1879)

* some fixes

* Update PlanInbox.js

* added checklist redirection (#1880)

* added checklist redirection

* removed console

* Updated workbench module version

* Plan and Pop inbox fix (#1881)

* fixed pop inbox boundary getting empty issue

* fixed back button issue

* updated search juridiction component

* fixed facility pop up boundary refresh

* removed pending for approval from status filter

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* updated table and other fixes (#1882)

* updated table and other fixes

* fixed table issue

* Latest KPI values and Heading change (#1883)

* Popup changed to alert type

* UserName to name

* userName to name

* changes to heading font wieght

* css package
update

* Removed i icon

* changes

* removed comments

* removed comments

* changes

* isLoading removed

* updated css

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Added count of villages and facilities in confirmation messages (#1885)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Update UserUpload.js (#1886)

* fixed localization issue (#1888)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Removed  Core HRMS and updated the timeout of fetch from microplan

* changed residing-boundary to multiselect dropdown, fixed table scroll… (#1889)

* changed residing-boundary to multiselect dropdown, fixed table scroll styles, made boundary selection popup dropdown searcheable

* fixed dropdown alignment

* fixed validation in boundary create and timeline button in the summary (#1890)

* fixed validation in boundary create and timeline button in the summary

* changed localisation condition

* Added missing the translation

* Added list of assignee for pop and plan inbox (#1887)

* added list of assignee for pop and plan inbox

* updated comments

* updated assignee for plan inbox

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Re render assumption fix, atleast one mdms check, blank custom name check, (#1884)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

* action bar hidden fixes, session fixes

* fixes

* fix

* action bar fix, formula next back issue

* assumption and formula one mdms check and refetch blank label check

* remove status log column

* fix

* adhoc fix

* fix

* fix

* del session

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* fixed validation cond for app (#1891)

* fixed filestore call issue (#1895)

* toast fix, user tagging table dropdown fix and added comment toast (#1896)

* FIXES (#1893)

* added serving facility

* form composer action bar fix

* plan inbox assignee fix

* formula and assumption refresh issue

* action bar hidden fixes, session fixes

* fixes

* fix

* action bar fix, formula next back issue

* assumption and formula one mdms check and refetch blank label check

* remove status log column

* fix

* adhoc fix

* fix

* fix

* del session

* FIXES
1. After clicking on nextin vehicle after addinginvalid valu3 it redirects me to 1st assumption page
2. yes no buttton ki jagah same rakho na dono pop up me in formula and assumption pop up
3. User can add same duplicate text assumption and same value comess. similary for same dropdowns can be selected multiple times(in vehicle). Applies for formula and assumption
4. cache issue in pop of add new in assumption and formula. Entered value is not reset if they close and reopen the popup. Applies for formula and assumption
5. need different loc code for description for vehicle assumption and vehicle estimation

* revert

* a

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* ui fixes. (#1897)

* ui fixes.

* review changes

* review changes1

* Fetch microplan related changes (#1898)

* mychange

* added changes for fetch from microplan screen

* updated packege

* added back button, redirected checklist success and fixed null issue … (#1894)

added back button, redirected checklist success and fixed null issue for app

* fixed finalized button issue (#1899)

* added fixes for the campaign update and fetch from mp

* added timeout cleaned up & fetch will start after the data template download

* Employee search fix (#1892)

* button change

* Changes

* Formula name validation

* Changes

* console log removed

* changes

* changes

* changes

* Original formula config

* Formula config change for toast

* Update FormulaConfiguration.js

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Bug fix (#1900)

* fixed decimal issue and total not getting validated issue

* fixed user tagging multiselect dropdown issue

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Added few extra waiting steps for templates

* KPI card fix, and css change (#1903)

* Heading added

* changes to query, for kpi card

* css change

* css package update

* update to inbox codes (#1904)

updates

* Added dynamic columns in facility screen (#1902)

* Added dynamic columns in facility screen

* changed the filter condition

* Update FacilityPopup.js

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>
Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* validations done for assumptions and formula (#1906)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* localisation and error codes (#1905)

* Added fixes for timeout and redirection for fetch microplan (#1901)

* Added fixes for timeout and redirection for fetch microplan

* Update useFetchFromMicroplan.js

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/fetchFromMicroplan.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/fetchFromMicroplan.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Added fixes for the template generation

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/fetchFromMicroplan.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/fetchFromMicroplan.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* updated

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* wait and retry message (#1909)

* Updated toast wran to warning message toast type

* checking popup issue in facility screen (#1910)

Co-authored-by: Swathi-eGov <swathi.chatrathi@egovernments.org>

* Adhoc fixes 91 (#1912)

* updates to validation

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* updated regex

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Pop inbox Pagination fix (#1907)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Facility Pagination Fix (#1908)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Feature/er (#1914)

* wait and retry message

* type of structure changed for irs

* fixed plan inbox issues (#1915)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Table changes (#1913)

* a lot of changes

* small change

* changes

* loc

* removed

* added fixes for sort, view summary issue, no results in dropdown (#1916)

added fixes

* fixed facility catchment pop up issue (#1917)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Fixed Audit issues (#1918)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* removed alphanumeric valiadtion (#1922)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* updated the loader screen loader styles as per ux audit

* Kpis integrate (#1919)

* Kpis integration

* Some style changes

* Some validations

* Remove console

* Removed merged changes

* Data null handled

* Data null handled

* Assumption Toast Validation and Irs removed 1 (#1921)

* changes

* changes

* changes

* Fixed accessibility dropdown issue (#1923)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Added extra steps and styles updated

* Added toast and changes primary, seccondary in Assumption,Formula (#1924)

* changes

* changes

* changes

* changes

* Changed hierarchy schema for microplan (#1925)

* Changed hierarchy schema for microplan

* Update UserUpload.js

* removed duplicate campaignId

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Fixed small issues (#1927)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Audit fixes main (#1926)

* audit fixes

* fixed campaign details css issue

* Update health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* updated core, react-components,ui-components and releated css versions

* added icon for download and changed primary to secondary for action button

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* width fix for module card (#1929)

* Formula Checking Fix (#1930)

* small changes

* changes

* changes

* Edit Size button changed (#1931)

changes

* Update HypothesisWrapper.js (#1932)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Feature/fixes (#1928)

* microplan hover and campign fixes with checklist minor improvements

* bottom margin below add levels

* review changes

* Updates to formula (#1933)

* Update HypothesisWrapper.js

* Update FormulaConfigWrapper.js

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* fixed pop issue (#1934)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* css fix on card comp (#1935)

* Updated the campaign Card for the roles mapping

* Fixed screen breaking issue (#1936)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* validation update (#1937)

Update HypothesisWrapper.js

* Fixed assignee count for pop and plan inbox (#1938)

* Fixed assignee count for pop and plan inbox

* fixed back button issue in plan inbox

* removed logs

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Changes in facility kpis (#1939)

* Changes in facility kpis

* Some changes

* fixed product chip and summary issue (#1941)

fixed productchip and summary issue

* Mdms kpi (#1942)

* Kpis from mdms

* Some optimizations

* Update health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/hooks/useKpiDssSearch.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Dropdown popup fixes (#1943)

* removed custom loader, updated dropdown styles inside popup,fixed action drodpown css

* updated css version

* Added inline validations (#1944)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Added refetch (#1945)

* Assumption formula fixes (#1946)

* added a toast on back button

* updated formula source to CUSTOM when any custom assumption is used in

---------

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Update createUpdatePlanProject.js (#1948)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Fixed back button and edit population error message logic (#1949)

* fixed back button and edit population error message logic

* updated back button in facility screen

* added show on ui conditions on fields

* added translation function

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* localizations for user management and user tag (#1950)

* Loc in userManagement

* Changes to user tag loc

* added status filters (#1952)

* additional validations on assumptions + showing formulas in plan inbox based on show on estimation dashboard (#1953)

additional validations

* Updated Bread crumbs (#1954)

* fixed back button and edit population error message logic

* Updated breadcrumbs

* removed unused import

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* sort issue fix, title for buttons, actionbar fix (#1955)

* Patch fix (#1956)

* added list of roles for assigner

* added null check

---------

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Popup fix (#1958)

* fixed popup scroll issue

* updated versions

* Changes for kpis (#1960)

* Fixed toast issue + fixed invalidation of assumption and formula (#1963)

Co-authored-by: Nipun Arora <aroranipun1@gmail.com>

* Updated the loader text, updated the icon information, change log updated

* fixed error message issue (#1964)

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* Adhoc fixes 13: Fixed formula custom cascading changes + validations  (#1966)

* updated toast error in formulas

* Update createUpdatePlanProject.js

* updated mdms paths (#1968)

* Update searchDssChartV2.js (#1969)

* fixed resources,delivery screen issue and added campaign name (#1965)

* fixed resources,delivery screen issue and added campaign name

* added classname

* Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BoundarySummary.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* removed logs

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* bug bash bug of download popup openinng again and again (#1961)

* bug bash bug of download popup openinng again and again

* review changes

* Update UploadData.js

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* changes from count to quantity (#1970)

* changes from count to quantity

* removed logs

* Feature/time (#1971)

* timeline fix for microplan

* ui

* Update campaign.scss

---------

Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* added campaign name in update (#1973)

* Updated loc codes (#1976)

Update Module.js

* Revert module changes for localisation (#1977)

Revert "Updated loc codes (#1976)"

This reverts commit cf596aa.

* Added fix for the buil issue for trying out the optional deepndency #1974 (#1978)

Added fix for the buil issue for trying out the optional deepndency

* Some handlings (#1980)

* Updated hrms path (#1979)

updated hrms path

Co-authored-by: rachana-egov <rachana.singh@egovernment.org>

* removed commented code

* fixed usermanagement toast issue (#1982)

* removed commented code

* Added core ui build to check performance

* Fixed error issue (#1983)

* updated the package version of campaign manager modules

* adding utils and remove hardcoding module name (#1984)

* adding utils and remove hardcoding module name

* Update UICustomizations.js

* Update index.js

---------

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: Jagankumar <53823168+jagankumar-egov@users.noreply.github.com>

* added title for all buttons (#1985)

* updated package versions

* filtering fixes (#1986)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* Updated the config for the core app

* updated directory

* Feature/hcmpre1418 (#1988)

rounding off to nearest integer in attributes

* formatted

* Update health/micro-ui/web/core/install-deps.sh

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update health/micro-ui/web/core/install-deps.sh

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* updated changeQueryName for planfacilityserach as residingBoundaries … (#1989)

* updated changeQueryName for planfacilityserach as residingBoundaries is changed to multiselect dropdown

* fixed length change issue

* fixed page responsiveness issue for formula configuration screen (#1990)

* clearing console (#1991)

Co-authored-by: NabeelAyubee <nayubi7@gmail.com>

* fixed rerendering of summary screen in update dates (#1992)

---------

Co-authored-by: Swathi-eGov <137176788+Swathi-eGov@users.noreply.github.com>
Co-authored-by: Bhavya-egov <137176879+Bhavya-egov@users.noreply.github.com>
Co-authored-by: rachana-egov <137176770+rachana-egov@users.noreply.github.com>
Co-authored-by: rachana-egov <rachana.singh@egovernment.org>
Co-authored-by: abishekTa-egov <abishek.t@egovernments.org>
Co-authored-by: ashish-egov <137176738+ashish-egov@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: nabeelmd-eGov <nabeel.md@egovernments.org>
Co-authored-by: NabeelAyubee <nayubi7@gmail.com>
Co-authored-by: suryansh-egov <suryansh.singh@egovernments.org>
Co-authored-by: Nipun Arora <aroranipun1@gmail.com>
Co-authored-by: Swathi-eGov <swathi.chatrathi@egovernments.org>
Co-authored-by: Shashwat Mishra <71879793+shashwat-egov@users.noreply.github.com>
Co-authored-by: Anuraj <154124191+anuraj-egov@users.noreply.github.com>
Co-authored-by: Bhavya-egov <bhavya.mangal@egovernments.org>
@nabeelmd-eGov nabeelmd-eGov mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants