fixed localization issue

[rachana-egov]

Summary by CodeRabbit

• New Features

  • Enhanced error handling in the PlanInbox and PopInbox components for better user notifications.
  • Improved clarity of alert messages using template literals across multiple components.

• Bug Fixes

  • Refined pagination and selection logic in the PlanInbox component to ensure accurate data display.

• Refactor

  • Updated message construction methods in the ConfirmationPopUp component for improved readability and maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on modifying the alertMessage prop of the ConfirmationPopUp component across three files: FacilityCatchmentMapping.js, PlanInbox.js, and PopInbox.js. The updates transition from string concatenation to template literals for constructing alert messages, enhancing code readability and maintainability. Additionally, improvements were made to error handling and state management related to user interactions and data fetching, ensuring a more robust user experience without altering the core functionality of the components.

Changes

File	Change Summary
.../FacilityCatchmentMapping.js	Updated alertMessage prop to use template literals instead of string concatenation for improved readability.
.../PlanInbox.js	Modified alertMessage to use template literals. Enhanced error handling in fetchStatusCount and refined pagination logic for better state management.
.../PopInbox.js	Changed alertMessage to use template literals. Improved error handling and streamlined logic for user roles and data fetching.

Possibly related PRs

• Added action bar for pop inbox screen #1622: Updates to PopInbox.js include changes to the alertMessage in the ConfirmationPopUp, similar to the main PR.
• Finalise Action for Facility Catchment + Validations #1642: Modifications in WorkflowCommentPopUp.js involve changes to error handling logic, aligning with the main PR's focus on clarity.
• Added confirmation pop up to finalise actions #1832: Introduction of the ConfirmationPopUp component relates directly to changes in PopInbox.js, indicating a shift in handling confirmation messages.
• Added count of villages and facilities in confirmation messages #1885: Updates in PopInbox.js to include counts in the alertMessage reflect the same intent to enhance user feedback as seen in the main PR.

Suggested reviewers

• nipunarora-eGov

Poem

🐰 In the code where messages flow,
Template literals now brightly glow.
Readability’s charm, we celebrate,
With clearer alerts, we elevate!
Errors handled with grace anew,
A smoother path for me and you! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🧹 Outside diff range comments (6)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (3)

Line range hint 1-24: Consider breaking down the component for better maintainability.

The component handles multiple responsibilities and could benefit from being split into smaller, more focused components. Consider extracting:

1. Workflow management logic into a custom hook
2. Table and filtering logic into a separate component
3. Action handling logic into a custom hook

This would improve code organization, testability, and maintainability.

Also applies to: 751-751

---

Line range hint 42-107: Consider consolidating error handling patterns.

The error handling is scattered across different callbacks with varying patterns. Consider creating a consistent error handling utility:

+ const handleError = (error) => {
+   setShowToast({ 
+     key: "error", 
+     label: t(error?.response?.data?.Errors?.[0]?.code)
+   });
+ };

  const fetchStatusCount = async () => {
    if (planObject) {
      try {
        await mutation.mutateAsync(
          {
            body: {
              CensusSearchCriteria: {
                tenantId: tenantId,
                source: microplanId,
                ...(isRootApprover ? {} : { jurisdiction: jurisdiction }),
              },
            }
          },
-           {
-             onError: (error) => {
-               setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
-             }
-           }
+           { onError: handleError }
        );
      } catch (error) {
-       setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+       handleError(error);
      }
    }
  };

---

Line range hint 108-196: Consider extracting data fetching logic into custom hooks.

The component contains multiple data fetching operations with complex configurations. Consider extracting these into custom hooks for better reusability and separation of concerns:

const useCensusData = (microplanId, censusJurisdiction, selectedFilter, limitAndOffset, activeLink) => {
  // Extract census data fetching logic here
};

const useEmployeeData = (assigneeUuids) => {
  // Extract employee data fetching logic here
};

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (3)

Line range hint 1-924: Consider decomposing the component for better maintainability

The PlanInbox component has grown quite large and handles multiple responsibilities. Consider breaking it down into smaller, more focused components:

1. Extract table configuration logic into a separate hook (e.g., usePlanTableConfig)
2. Move workflow management logic into a dedicated component
3. Create a separate component for filter management

This would improve maintainability, testability, and reusability.

---

Line range hint 1-924: Enhance error handling and state management

1. Error handling could be more consistent and specific:

   • Consider creating a custom error boundary
   • Add retry mechanisms for failed API calls
   • Provide more specific error messages

2. State management could be simplified:

   • Consider using useReducer for complex state logic
   • Group related state variables
   • Consider using a state management library for complex state interactions

---

Line range hint 1-924: Optimize component performance

Consider implementing these performance improvements:

1. Memoize expensive computations:

   • Use useMemo for table columns configuration
   • Use useCallback for event handlers
   • Memoize filter transformations

2. Optimize useEffect dependencies:

   • Review and minimize dependency arrays
   • Consider using useRef for values that don't need to trigger re-renders

3. Implement virtual scrolling for the data table to handle large datasets more efficiently.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between bfbe14c and 432079f.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/FacilityCatchmentMapping.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/FacilityCatchmentMapping.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

📓 Learnings (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (2)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1832
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:592-594
Timestamp: 2024-11-14T12:48:23.024Z
Learning: In `PopInbox.js`, when integrating the `ConfirmationPopUp` component, error handling for API failures is managed internally within the component, so explicitly passing an `onError` prop is not necessary.

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1837
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:559-561
Timestamp: 2024-11-15T10:15:57.370Z
Learning: In `PopInbox.js`, error handling for the `onError` callback in `WorkflowCommentPopUp` is handled within the component, so explicit error handling in the parent component is unnecessary.

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

751-751: LGTM! Improved string interpolation for localization.

The template literal usage enhances readability while maintaining proper localization support.