Re render assumption fix, atleast one mdms check, blank custom name check,

[nabeelmd-eGov]

• added serving facility
• form composer action bar fix
• plan inbox assignee fix
• formula and assumption refresh issue
• action bar hidden fixes, session fixes
• fixes
• fix
• action bar fix, formula next back issue
• assumption and formula one mdms check and refetch blank label check

Choose the appropriate template for your PR:

• Feature PR
• Bugfix PR
• Release PR

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced validation for formula and assumption entries, ensuring users receive immediate feedback on invalid inputs.
  • Added toast notifications for missing required formulas and assumptions sourced from "MDMS".
  • Improved initialization of formula and assumption values to reflect the latest configurations.
  • Streamlined URL parameter handling and introduced data refreshing after resource updates.

• Bug Fixes

  • Improved state management for formulas and assumptions, ensuring accurate tracking and removal of deleted items.
  • Enhanced error handling for data fetching and state updates, providing clearer user notifications.
  • Refined rendering logic for data tables, improving user experience during interactions.

These updates enhance the overall usability and reliability of the application, providing users with clearer guidance and improved data integrity.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request focus on enhancing error handling and validation processes across several components related to formula and assumption management. Key updates include the introduction of new validation checks for formulas and assumptions, ensuring that users receive immediate feedback for invalid inputs. Additionally, modifications to state management and the integration of session storage improve the consistency and reliability of user interactions. The control flow has been adjusted to ensure that all necessary validations occur before advancing in the user interface.

Changes

File	Change Summary
.../FormulaConfigWrapper.js	Updated handleNext to check for MDMS formulas and trigger a toast if none are found. Improved session storage handling.
.../FormulaConfiguration.js	Added validation checks for new formulas (name presence, validity, length) with error messages displayed via toast.
.../Hypothesis.js	Enhanced validation in addNewAssumption to check name length and selection before adding assumptions.
.../HypothesisWrapper.js	Introduced validation for MDMS assumptions in handleNext, refined state management for deleted assumptions.
.../SetupMicroplan.js	Modified handleUrlChange logic for setting state variables based on internalKey. Added refetchPlan() after updates.
.../PlanInbox.js	Updated fetchStatusCount for better error handling, refined onSearch for empty selections, and enhanced rendering logic.

Possibly related PRs

• Formula Screen #1599: Introduces context management which is relevant to the state management changes in the main PR.
• myMicroplanFixes #1777: Enhances formula management, which is relevant to the changes in the main PR regarding validation logic.

Suggested reviewers

• nipunarora-eGov

Poem

🐰 In the garden of code, where formulas bloom,
New checks and validations chase away gloom.
With toasts that remind us to fill every field,
Our assumptions are safe, and errors are sealed.
So hop through the logic, let no flaw remain,
For in this bright patch, we’ll code with no pain! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 14

🧹 Outside diff range comments (9)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js (1)

Line range hint 325-374: Consider extracting validation logic into a separate function

The validation logic could be extracted into a separate function for better maintainability and testability.

+const validateAssumption = (selectedDeletedAssumption) => {
+  if (selectedDeletedAssumption?.name?.length > 100) {
+    return {
+      isValid: false,
+      error: "SELECT_ASSUMPTION_NAME_LONG_THAN_100"
+    };
+  }
+
+  if (!selectedDeletedAssumption) {
+    return {
+      isValid: false,
+      error: "PLS_SELECT_ASSUMPTION"
+    };
+  }
+
+  if (selectedDeletedAssumption?.code === "NEW_ASSUMPTION" && 
+      (!selectedDeletedAssumption?.name || selectedDeletedAssumption?.name?.trim()?.length === 0)) {
+    return {
+      isValid: false,
+      error: "INVALID_ASSUMPTION_NAME"
+    };
+  }
+
+  return { isValid: true };
+}

// In the onClick handler:
-if (selectedDeletedAssumption?.name?.length > 100) {
-  setShowToast({...})
-  return;
-}
-// ... other validations ...
+const validation = validateAssumption(selectedDeletedAssumption);
+if (!validation.isValid) {
+  setShowToast({
+    key: "error",
+    label: t(validation.error),
+    transitionTime: 3000,
+    style: {
+      zIndex: 1000000,
+    },
+  });
+  return;
+}

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 472-489: Enhance error handling in workflow updates

The workflow update logic should include proper error boundaries and fallback handling.

 const updateWorkflowForSelectedRows = () => {
+  try {
     const updatedRows = selectedRows?.map(({ original }) => ({
       ...original,
       workflow: {
         ...original.workflow,
         action: workFlowPopUp,
       },
     }));
     return updatedRows;
+  } catch (error) {
+    console.error('Error updating workflow:', error);
+    throw new Error(t('WORKFLOW_UPDATE_ERROR'));
+  }
 };

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (7)

Line range hint 96-96: Correct the misspelled variable name defautFormula

The variable defautFormula appears to be misspelled. It should be defaultFormula. This will improve code readability and prevent confusion.

Apply this diff to fix the spelling:

- const [defautFormula, setDefaultFormula] = useState(["NEW_FORMULA"]);
+ const [defaultFormula, setDefaultFormula] = useState(["NEW_FORMULA"]);

Also, update all references to defautFormula throughout the code.

---

Line range hint 206-212: Unreachable code due to return statement

There is a return statement on line 205, which causes the rest of the code in the handleNext function to be unreachable. This means that the code from lines 206 onwards will never execute.

Consider removing the return statement if the subsequent code is necessary, or remove the unreachable code if it is not needed.

---

Line range hint 266-271: Include navigateBack in useEffect dependencies

In the useEffect hook on lines 266-271, navigateBack is used but not included in the dependencies array. Omitting it may cause issues if navigateBack changes.

Apply this diff to include navigateBack:

  useEffect(() => {
    window.addEventListener("verticalStepper", navigateBack);
    return () => {
      window.removeEventListener("verticalStepper", navigateBack);
    };
- }, [formulaInternalKey]);
+ }, [formulaInternalKey, navigateBack]);

---

Line range hint 284-288: Add dependencies to useEffect to prevent unnecessary renders

The useEffect hook on lines 284-288 lacks a dependencies array, causing it to run on every render. This may lead to performance issues.

Specify dependencies to control when the effect runs:

  useEffect(() => {
    if (executionCount < 5) {
      onSelect(customProps.name, { formulaConfigValues });
      setExecutionCount((prevCount) => prevCount + 1);
    }
- });
+ }, [executionCount, formulaConfigValues, onSelect, customProps.name]);

---

Line range hint 290-297: Include ruleConfigurationCategories in useEffect dependencies

The useEffect hook on lines 290-297 uses ruleConfigurationCategories but does not include it in the dependencies array. This could lead to stale data if ruleConfigurationCategories changes.

Update the dependencies array:

  useEffect(() => {
    if (formulaInternalKey === ruleConfigurationCategories?.length) {
      Digit.Utils.microplanv1.updateUrlParams({ isFormulaLastVerticalStep: true });
    } else {
      // Assuming 1 is the first step
      Digit.Utils.microplanv1.updateUrlParams({ isFormulaLastVerticalStep: false });
    }
- }, [formulaInternalKey]);
+ }, [formulaInternalKey, ruleConfigurationCategories]);

---

Line range hint 248-254: Include currentCategory in useEffect dependencies

In the useEffect hook on lines 248-254, currentCategory is used within the effect but not included in the dependencies array. Adding it ensures the effect runs when currentCategory changes.

Modify the dependencies array:

  useEffect(() => {
    setFilteredFormulas(
      currentCategoryRuleConfigurations?.map((row) => {
        return {
          ...row,
          category: currentCategory,
        };
      })
    );
- }, [currentCategoryRuleConfigurations]);
+ }, [currentCategoryRuleConfigurations, currentCategory]);

---

Line range hint 372-377: Ensure cleanup function in useEffect is properly defined

In the useEffect hook on lines 372-377, the cleanup function removes event listeners and updates URL parameters. However, the cleanup function should not contain additional logic unrelated to cleanup.

Consider separating the URL parameter update from the cleanup function:

  useEffect(() => {
    window.addEventListener("isFormulaLastStep", isFormulaLastStep);
    return () => {
+     Digit.Utils.microplanv1.updateUrlParams({ isFormulaLastVerticalStep: null });
+     Digit.Utils.microplanv1.updateUrlParams({ formulaInternalKey: null });
      window.removeEventListener("isFormulaLastStep", isFormulaLastStep);
    };
- }, []);
+ }, []);

Alternatively, handle the URL parameter update in a separate useEffect.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between fc83566 and 7314d8b.

📒 Files selected for processing (6)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (5 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (2 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js

[error] 438-438: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/Hypothesis.js (1)

338-348: LGTM! Proper validation for assumption selection

The validation ensures that users must select an assumption before proceeding, with clear error feedback.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 7314d8b and 5343037.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (5 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js

[error] 438-438: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

🔇 Additional comments (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (4)

80-80: Initialization of assumptionValues is appropriate

Setting assumptionValues using curr ensures that the state is properly initialized from session storage.

---

169-177: Variable naming might be misleading

The variable atleastOneMDMS is set to true when there are no MDMS assumptions, which could be confusing. Consider renaming it to noMDMSAssumptions or inverting the logic for better clarity.

---

386-386: Dependency array update is appropriate

Including filteredAssumptions, isLoadingPlanObject, and internalKey in the dependency array ensures the useEffect hook responds to relevant changes.

---

438-438: Unsafe optional chaining with spread operator

Using optional chaining with the spread operator can lead to a TypeError if the left-hand side evaluates to undefined, as the spread operator expects an iterable. This issue was previously noted and remains valid.

🧰 Tools

🪛 Biome (1.9.4)

[error] 438-438: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 5343037 and 12d97e9.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (5 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js

[error] 439-439: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

[coderabbitai]

Actionable comments posted: 3

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Line range hint 1-24: Consider architectural improvements for better maintainability

The component has grown complex with multiple responsibilities:

• URL parameter management
• State management with multiple side effects
• Form handling and validation
• Resource updates and data fetching

Consider breaking it down into smaller, focused components:

• MicroplanUrlManager: Handle URL-related logic
• MicroplanFormHandler: Handle form state and validation
• MicroplanResourceManager: Handle resource updates and data fetching

This would improve:

• Code organization and maintainability
• Testing and debugging
• Reusability of individual components

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 12d97e9 and 60f44b9.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (7 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js

[error] 439-439: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

🔇 Additional comments (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

228-228: 🛠️ Refactor suggestion

Optimize plan refetch operation

The unconditional plan refetch after every resource update could be inefficient. Consider implementing conditional refetching and error handling.

As previously suggested, consider applying this optimization:

-        refetchPlan();
+        try {
+          // Only refetch if the update affected plan data
+          if (data?.planUpdated) {
+            await refetchPlan();
+          }
+        } catch (error) {
+          console.error('Failed to refresh plan data:', error);
+          setShowToast({
+            key: "warning",
+            label: t("PLAN_REFRESH_FAILED"),
+          });
+        }

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (2)

61-61: Include dependencies in useEffect to ensure up-to-date state

In the useEffect hook starting at line 60, the dependencies array is empty []. Since you're using setFormulaParams and setFormulaConfigValues, consider adding them to the dependencies array to ensure the effect runs when these functions change.

---

198-205: Typo in operator name "SUBSTRACTION" may cause conditional logic to fail

In the condition i.operatorName === "SUBSTRACTION" on line 205, "SUBSTRACTION" appears to be a typo. The correct spelling is "SUBTRACTION". This typo may prevent the condition from evaluating as intended.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range comments (7)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (7)

Line range hint 178-190: Remove Duplicate useEffect Hooks

The useEffect hook that updates activeLink and showTab based on selectedFilter is duplicated at lines 178-190 and 285-297. This duplication can lead to maintenance issues and should be refactored into a single hook to avoid redundant code.

Apply this diff to remove the duplicate and consolidate the logic:

/* Remove the duplicate useEffect hook at lines 285-297 */

- useEffect(() => {
-   if (selectedFilter === "VALIDATED") {
-     setActiveLink({ code: "", name: "" });
-     setShowTab(false);
-   } else {
-     if (!showTab) {
-       setActiveLink({
-         code: "ASSIGNED_TO_ME",
-         name: "ASSIGNED_TO_ME",
-       });
-       setShowTab(true);
-     }
-   }
- }, [selectedFilter]);

Also applies to: 285-297

---

Line range hint 459-479: Add Null Checks to Prevent Potential Errors

In the getResourceColumns function, you're accessing planWithCensus?.planData?.[0]?.resources without verifying if planWithCensus?.planData has elements. If planWithCensus?.planData is empty, this could result in undefined access, leading to runtime errors.

Modify the code to include a null check before accessing the first element:

- const resources = planWithCensus?.planData?.[0]?.resources || [];
+ const resources = planWithCensus?.planData?.length > 0 ? planWithCensus.planData[0]?.resources || [] : [];

---

Line range hint 392-402: Simplify User Role Determination Logic

The logic for determining the userRole can be simplified for better readability and efficiency. Instead of using forEach, consider using array methods like find or some to streamline the role assignment.

Refactor the code as follows:

- const roles=Digit.UserService.getUser().info.roles;
- const userName=Digit.UserService.getUser().info.name;
- let userRole = "";
- roles.forEach(role => {
-   if (role.code === "ROOT_PLAN_ESTIMATION_APPROVER") {
-     userRole = "ROOT_PLAN_ESTIMATION_APPROVER";
-   } else if (userRole!== "ROOT_PLAN_ESTIMATION_APPROVER" && role.code === "PLAN_ESTIMATION_APPROVER") {
-     userRole = "PLAN_ESTIMATION_APPROVER";
-   }
- });
+ const { roles } = Digit.UserService.getUser().info;
+ const userName = Digit.UserService.getUser().info.name;
+ let userRole = "";
+ if (roles.some(role => role.code === "ROOT_PLAN_ESTIMATION_APPROVER")) {
+   userRole = "ROOT_PLAN_ESTIMATION_APPROVER";
+ } else if (roles.some(role => role.code === "PLAN_ESTIMATION_APPROVER")) {
+   userRole = "PLAN_ESTIMATION_APPROVER";
+ }

---

Line range hint 876-887: Clarify Logical Conditions with Parentheses

In the conditional rendering at lines 876-887, the combination of && and || operators without explicit parentheses may lead to unintended logic due to operator precedence.

Add parentheses to ensure the condition evaluates as intended:

- {(!isRootApprover && isStatusConditionMet(totalStatusCount) && planObject?.status === "RESOURCE_ESTIMATION_IN_PROGRESS") || disabledAction && (
+ {((!isRootApprover && isStatusConditionMet(totalStatusCount) && planObject?.status === "RESOURCE_ESTIMATION_IN_PROGRESS") || disabledAction) && (

---

Line range hint 201-212: Handle Potential Empty Array in onSearch Function

In the onSearch function, you're not returning or stopping execution after showing the warning toast when selectedBoundaries.length === 0. This means the subsequent code will still execute, which might not be the intended behavior.

Consider adding a return statement to prevent the function from proceeding when there are no selected boundaries:

  const onSearch = (selectedBoundaries, selectedHierarchy) => {
    if (selectedBoundaries.length === 0) {
      setShowToast({ key: "warning", label: t("MICROPLAN_BOUNDARY_IS_EMPTY_WARNING"), transitionTime: 5000 });
+     return;
    } else {

      setActiveLink({
        code: "ASSIGNED_TO_ME",
        name: "ASSIGNED_TO_ME"
      });

---

Line range hint 662-669: Add Null Check for selectedRows Before Mapping

In the updateWorkflowForSelectedRows function, you're calling selectedRows?.map. If selectedRows is null or undefined, this will result in a TypeError. While the optional chaining operator prevents this, it's good practice to handle such cases explicitly.

Consider adding a default empty array to ensure map is called on an array:

- const updatedRows = selectedRows?.map(({ original }) => ({
+ const updatedRows = (selectedRows || []).map(({ original }) => ({

---

Line range hint 534-538: Remove Unused Commented Code

There's a commented-out code block related to villageTransportMode in the columns array. Keeping commented code can clutter the codebase and may cause confusion for future maintenance.

Consider removing the commented code if it's no longer needed:

        // {
        //   name: t(`HCM_MICROPLAN_VILLAGE_TRANSPORTATION_MODE_LABEL`),
        //   cell: (row) => t(row?.villageTransportMode) || "NA",
        //   sortable: true,
        //   width: "180px",
        // },

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 60f44b9 and e343818.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 95-105: Handle Missing planObject in fetchStatusCount

In the fetchStatusCount function, you rely on planObject being available. However, if planObject is null or undefined, the function might not behave as expected. Although you check for planObject before calling fetchStatusCount, it's safer to ensure that the function handles such cases gracefully.

Ensure that planObject is always defined when fetchStatusCount is called, or add a null check within the function.

  const fetchStatusCount = async () => {
-   if (planObject) {
+   if (planObject) {
      try {
        await mutation.mutateAsync(

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (2)

Line range hint 614-632: Improve error handling in workflow updates

The workflow update function should include error handling for edge cases.

 const updateWorkflowForSelectedRows = () => {
+  if (!selectedRows?.length) {
+    console.error('No rows selected for workflow update');
+    return [];
+  }
+
   const updatedRows = selectedRows?.map(({ original }) => {
+    if (!original) {
+      console.warn('Row data is missing');
+      return null;
+    }
     return {
       ...original,
       workflow: {
         ...original.workflow,
         action: workFlowPopUp,
       },
     };
   });
-  return updatedRows;
+  return updatedRows.filter(Boolean);
 };

---

Line range hint 92-116: Standardize error handling across API calls

The error handling in fetchStatusCount could be more consistent with other API calls in the codebase.

 const fetchStatusCount = async () => {
   if (planObject) {
     try {
       await mutation.mutateAsync(
         {
           body: {
             PlanSearchCriteria: {
               tenantId: tenantId,
               planConfigurationId: microplanId,
               ...(isRootApprover
                 ? {}
                 : { jurisdiction: jurisdiction }),
             },
           }
         },
         {
           onSuccess: (data) => {
             setTotalStatusCount(data?.StatusCount);
           },
           onError: (error) => {
-            setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+            const errorCode = error?.response?.data?.Errors?.[0]?.code || 'UNKNOWN_ERROR';
+            setShowToast({ 
+              key: "error", 
+              label: t(errorCode),
+              transitionTime: 5000
+            });
+            console.error('Error fetching status count:', error);
           }
         }
       );
     } catch (error) {
-      setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+      const errorCode = error?.response?.data?.Errors?.[0]?.code || 'UNKNOWN_ERROR';
+      setShowToast({ 
+        key: "error", 
+        label: t(errorCode),
+        transitionTime: 5000
+      });
+      console.error('Error in fetchStatusCount:', error);
     }
   }
 };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between e343818 and 9665aca.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

216-217: LGTM! Session storage cleanup is properly implemented.

The explicit deletion of session storage items for hypothesis and formula data ensures clean state management during form invalidation.