Fixed assignee count for pop and plan inbox

[rachana-egov]

Summary by CodeRabbit

• New Features

  • Introduced a custom hook in the Plan Inbox for fetching the count of plans assigned to users, enhancing data retrieval.
  • Added a custom hook in the Pop Inbox to fetch the count of assigned items based on selected filters and jurisdictions.

• Bug Fixes

  • Improved error handling in data fetching processes to enhance reliability.
  • Updated button disabling logic in the Workflow Comment Pop-Up and Confirmation Pop-Up for better user interaction during submission and loading states.

• Documentation

  • Updated comments in the code to clarify changes and improve understanding of button states and data fetching logic.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request involve updates to four JavaScript files related to user interface components in a micro-planning application. Key modifications include enhancements to button disabling logic in WorkflowCommentPopUp.js and ConfirmationPopUp.js, the introduction of new custom hooks in PlanInbox.js and PopInbox.js for fetching user-specific counts, and improvements in error handling and loading states. These changes enhance the control flow during asynchronous operations and improve user interactions across the components.

Changes

File	Change Summary
.../WorkflowCommentPopUp.js	Updated button disabling logic to include mutation.isLoading state; comments clarified regarding button states.
.../PlanInbox.js	Added usePlanSearchWithCensus custom hook for fetching plan counts; modified existing hook for additional parameters; enhanced error handling and loading state checks.
.../PopInbox.js	Introduced a new custom hook for fetching assigned item counts; updated existing hook for clarity; expanded loading state checks and rendering logic.
.../ConfirmationPopUp.js	Updated button disabling logic to include mutation.isLoading state; comments retained clarifying button states.

Possibly related PRs

• added new hook for microplans search screen #1587: The addition of a new hook for microplans search screen may relate to the changes in WorkflowCommentPopUp.js as both involve user interactions and state management during asynchronous operations.
• Facility mapper #1590: The changes to button states during submission in ConfirmationPopUp relate to the updates in ConfirmationPopUp.js, enhancing user experience during API submissions.
• Component for bulk comment update workflow #1612: The introduction of the WorkflowCommentPopUp component directly relates to the changes made in WorkflowCommentPopUp.js, as they both involve the same component and its functionality.
• Finalise Action for Facility Catchment + Validations #1642: The modifications in error handling within the WorkflowCommentPopUp component may connect with the changes in WorkflowCommentPopUp.js, enhancing user feedback mechanisms.
• Added count of villages and facilities in confirmation messages #1885: The addition of counts in confirmation messages may connect with the changes in ConfirmationPopUp.js, as both involve user feedback and interaction.
• Pop inbox Pagination fix #1907: The changes in PopInbox.js regarding pagination and state management are relevant to the user experience improvements discussed in the main PR.
• Fixed small issues #1927: The modifications in ConfirmationPopUp.js regarding button functionalities are relevant to the changes in the main PR, which also focuses on user interactions during comment submissions.

Suggested reviewers

• nipunarora-eGov

🐰 In the meadow, changes bloom,
Buttons now won't lead to gloom.
Fetching counts, oh what a sight,
User flows are now just right!
With hooks and states, we hop along,
In our code, we all belong! 🌼

Warning

Rate limit exceeded

@rachana-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 799aa24 and 3731546.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 799aa24 and 3731546.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (8 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js

[error] 178-178: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (2)

170-170: Simplify null checks on selectedFilter in status parameter

Since selectedFilter is always defined in this context, the null checks are unnecessary and can be removed to simplify the code.

Apply this diff to simplify the code:

-            status: selectedFilter !== null && selectedFilter !== undefined ? selectedFilter : "",
+            status: selectedFilter,

---

178-178: Simplify enabled condition by removing unnecessary ternary operator

The condition censusJurisdiction?.length > 0 ? true : false can be simplified to censusJurisdiction?.length > 0 as it already returns a boolean value.

Apply this diff to simplify the condition:

-          enabled: censusJurisdiction?.length > 0 ? true : false,
+          enabled: censusJurisdiction?.length > 0,

🧰 Tools

🪛 Biome (1.9.4)

[error] 178-178: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1)

Line range hint 1-170: Consider architectural improvements for better maintainability.

The component could benefit from several architectural improvements:

1. The mutation hook's loading state could be used more effectively by removing the redundant isSubmitting state
2. Error handling could be more robust with proper error boundaries
3. Comment validation logic could be extracted to a separate utility
4. Consider adding TypeScript for better type safety

Here's a suggested refactor for the submission logic:

-const [isSubmitting, setIsSubmitting] = useState(false);

 const handleSave = async () => {
-    setIsSubmitting(true);
     const updatedPayload = setCommentInPayloadForList({ ...requestPayload }, commentPath, comment);
     
     await mutation.mutate(
         {
             body: updatedPayload
         },
         {
             onSuccess: (data) => {
                 onSuccess && onSuccess(data);
             },
             onError: (error) => {
-                setShowToast({ key: "error", label: t(error?.response?.data?.Errors?.[0]?.code) });
+                const errorMessage = error?.response?.data?.Errors?.[0]?.code || 'HCM_UNKNOWN_ERROR';
+                setShowToast({ key: "error", label: t(errorMessage) });
                 onError && onError(error);
             }
         }
     );
-    setIsSubmitting(false);
 };

And extract the comment validation:

// utils/commentValidation.js
export const validateComment = (comment) => {
  if (!comment) return true;
  return comment.length <= 140;
};

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between d986b65 and 68dd704.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (4 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js

[error] 177-177: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js

[error] 322-322: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

587-587: LGTM! Loading state handling is comprehensive

The loading check correctly includes all relevant loading states, including the new isCountLoading state.

[coderabbitai]

Actionable comments posted: 3

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (1)

Line range hint 12-24: Consider adding cleanup for mutation state

The component should clean up the mutation state when unmounting to prevent memory leaks and state inconsistencies.

    const [isSubmitting, setIsSubmitting] = useState(false);

+   useEffect(() => {
+       return () => {
+           mutation.reset();  // Clean up mutation state on unmount
+       };
+   }, []);

    // Mutation hook for updating via a dynamic URL

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 68dd704 and 799aa24.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (9 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ConfirmationPopUp.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1847
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js:308-314
Timestamp: 2024-11-18T04:35:51.535Z
Learning: In `PlanInbox.js`, the variable `planWithCensus?.StatusCount[selectedFilter]` is always defined in the given context, so null checks are unnecessary.

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js

[error] 178-178: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (2)

170-170: 🛠️ Refactor suggestion

Simplify null checks on selectedFilter

Since selectedFilter is always defined in this context, you can simplify the expression by removing unnecessary null checks.

Apply this diff to simplify the expression:

-            status: selectedFilter !== null && selectedFilter !== undefined ? selectedFilter : "",
+            status: selectedFilter,

---

178-178: 🛠️ Refactor suggestion

Simplify enabled condition by removing unnecessary ternary operator

The condition censusJurisdiction?.length > 0 ? true : false can be simplified to censusJurisdiction?.length > 0 since it already returns a boolean value.

Apply this diff to simplify the condition:

-          enabled: censusJurisdiction?.length > 0 ? true : false,
+          enabled: censusJurisdiction?.length > 0,

🧰 Tools

🪛 Biome (1.9.4)

[error] 178-178: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)