Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig.json too benevolent #758

Closed
14 tasks done
relu91 opened this issue May 16, 2022 · 5 comments · Fixed by #1073
Closed
14 tasks done

tsconfig.json too benevolent #758

relu91 opened this issue May 16, 2022 · 5 comments · Fixed by #1073
Labels
binding-http Issues related to http protocol binding bug Something isn't working core Issues with the core library

Comments

@relu91
Copy link
Member

relu91 commented May 16, 2022 •
edited
Loading

This comment got me suspicious #748 (comment). tsc should be able to identify such trivial cases pretty well, so I further investigated.

What I found is bad... we allowed the whole codebase to be not strictly checked. In other words, the root tsconfig.json contains strict: false. I think this got undercover when we unified all the tsconfigs in one using the composite build.

Packages to be fixed:

  • binding-coap
  • binding-modbus
  • browser-bundle
  • binding-file
  • binding-mqtt
  • cli
  • binding-netconf
  • core
  • binding-opcua
  • examples
  • binding-websockets
  • td-tools
  • binding-http
  • binding-mbus
  • binding-fujitsu
  • binding-firestore
  • binding-firestore-browser-bundle
@relu91 relu91 added bug Something isn't working core Issues with the core library binding-http Issues related to http protocol binding labels May 16, 2022
@danielpeintner
Copy link
Member

Mhh, this is really bad. I quickly checked and there are many issues / warning 😌.
However, I suggest to clean-up the entire repo and all packages.. maybe tackle it package by package.. step by step

@relu91
Copy link
Member Author

relu91 commented May 17, 2022

I suggest to clean-up the entire repo and all packages.. maybe tackle it package by package.. step by step

yeah, I agree. I'll add some checkboxes to keep track of the progress

This was referenced May 19, 2022
Merged
Merged
relu91 added a commit to relu91/thingweb.node-wot that referenced this issue May 20, 2022
@relu91
fix(td-tools): fixing build errors caused by eclipse-thingweb#758
0bb7453 
Signed-off-by: reluc <relu.cri@gmail.com>
relu91 added a commit to relu91/thingweb.node-wot that referenced this issue May 20, 2022
@relu91
fix(core): building errors caused by eclipse-thingweb#758
3f5604c 
Signed-off-by: reluc <relu.cri@gmail.com>
relu91 added a commit to relu91/thingweb.node-wot that referenced this issue Jun 8, 2022
@relu91
fix: compilation errors due to a benevolent tsconfig
c792091 
see eclipse-thingweb#758

Signed-off-by: reluc <relu.cri@gmail.com>
relu91 added a commit that referenced this issue Jun 10, 2022
@relu91
Merge pull request #767 from relu91/fix_758
1d2ea3b 
First steps in fixing #758
relu91 added a commit to relu91/thingweb.node-wot that referenced this issue Jun 30, 2022
@relu91
fix(cli): fix compilation errors due to eclipse-thingweb#758
0a10750 
Signed-off-by: reluc <relu.cri@gmail.com>
danielpeintner added a commit that referenced this issue Jul 6, 2022
@danielpeintner
Merge pull request #794 from relu91/fix_cli_ts
a5af4f0 
fix CLI compilation errors due to #758
@danielpeintner danielpeintner mentioned this issue Jul 6, 2022
Merged
@relu91 relu91 mentioned this issue Jul 31, 2023
Closed
14 tasks
@danielpeintner danielpeintner mentioned this issue Aug 1, 2023
Merged
@relu91 relu91 mentioned this issue Aug 1, 2023
Merged
@danielpeintner danielpeintner mentioned this issue Aug 2, 2023
Merged
@relu91 relu91 mentioned this issue Aug 3, 2023
Merged
@relu91
Copy link
Member Author

relu91 commented Aug 3, 2023

@JKRhb and @egekorkan since we are having a good sprint here, do you have time to tackle binding-coap and binding-mqtt ?

@relu91 relu91 mentioned this issue Aug 3, 2023
Merged
@JKRhb JKRhb mentioned this issue Aug 9, 2023
Merged
This was referenced Aug 11, 2023
Merged
Merged
@relu91
Copy link
Member Author

relu91 commented Sep 6, 2023

Binding netconf solved with #1071

@relu91
Copy link
Member Author

relu91 commented Sep 6, 2023 •
edited
Loading

With the final merge of #1059 we should now have the global strict set to true. PR coming soon.

@relu91 relu91 mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding-http Issues related to http protocol binding bug Something isn't working core Issues with the core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use only base tsconfig strict relu91/thingweb.node-wot
2 participants
@relu91 @danielpeintner