Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(binding-mbus): enable strict type checking #1059

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

danielpeintner
Copy link
Member

another one of #758

@LennyHEVS @Chxresubles can you take a look?
We are enabling strict checking for all node-wot packages

@danielpeintner danielpeintner requested a review from relu91 as a code owner August 11, 2023 14:21
@danielpeintner danielpeintner marked this pull request as draft August 11, 2023 14:21
@danielpeintner danielpeintner marked this pull request as ready for review September 6, 2023 10:07
@danielpeintner
Copy link
Member Author

I tried to update the code, please have a look...

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since mbus code is pretty similar structurally to Modbus I noticed some dissimilarities. I think we can align the two implementations, but feel free to prove me wrong.

packages/binding-mbus/src/mbus-connection.ts Outdated Show resolved Hide resolved
packages/binding-mbus/src/mbus-connection.ts Outdated Show resolved Hide resolved
packages/binding-mbus/src/mbus-connection.ts Outdated Show resolved Hide resolved
packages/binding-mbus/src/mbus-connection.ts Outdated Show resolved Hide resolved
@danielpeintner
Copy link
Member Author

Since mbus code is pretty similar structurally to Modbus I noticed some dissimilarities. I think we can align the two implementations

I wasn't aware that those two bindings are so similar. With my latest commit be3d6de I tried to align the code. Please have another look.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 46.66% and project coverage change: -0.26% ⚠️

Comparison is base (0e6e117) 75.38% compared to head (4cc0978) 75.12%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   75.38%   75.12%   -0.26%     
==========================================
  Files          80       80              
  Lines       15443    15498      +55     
  Branches     1477     1485       +8     
==========================================
+ Hits        11641    11643       +2     
- Misses       3766     3819      +53     
  Partials       36       36              
Files Changed Coverage Δ
packages/binding-mbus/src/mbus-connection.ts 70.55% <39.39%> (-3.76%) ⬇️
packages/binding-mbus/src/mbus-client.ts 63.22% <66.66%> (+1.15%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
@relu91
Copy link
Member

relu91 commented Sep 6, 2023

And with this, we fix #758.

@relu91 relu91 merged commit d1d2abd into eclipse-thingweb:master Sep 6, 2023
@relu91 relu91 mentioned this pull request Sep 6, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants