-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(binding-mbus): enable strict type checking #1059
chore(binding-mbus): enable strict type checking #1059
Conversation
I tried to update the code, please have a look... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since mbus code is pretty similar structurally to Modbus I noticed some dissimilarities. I think we can align the two implementations, but feel free to prove me wrong.
I wasn't aware that those two bindings are so similar. With my latest commit be3d6de I tried to align the code. Please have another look. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 75.38% 75.12% -0.26%
==========================================
Files 80 80
Lines 15443 15498 +55
Branches 1477 1485 +8
==========================================
+ Hits 11641 11643 +2
- Misses 3766 3819 +53
Partials 36 36
☔ View full report in Codecov by Sentry. |
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
And with this, we fix #758. |
another one of #758
@LennyHEVS @Chxresubles can you take a look?
We are enabling strict checking for all node-wot packages