-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ts strict checking for binding modbus #1050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
Have some understanding problems w.r.t. some error messages. See below
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
- Coverage 75.63% 75.49% -0.15%
==========================================
Files 80 80
Lines 15324 15385 +61
Branches 1460 1469 +9
==========================================
+ Hits 11591 11615 +24
- Misses 3699 3735 +36
- Partials 34 35 +1
|
I tried already several times to activate the GitHub integration but I do not know "what" blocks it? Shall I open a ticket on Eclipse side? |
FYI: I opened https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3545 EDIT: Has been approved already .. cool. Let's see how the next PRs/commits look like |
@danielpeintner do you think we can merge it even if we have redcrosses in codecov? |
We are now seeing these kind of "errors" in all our PRs now. I think we need to properly configure it and maybe show it as a warning or so. Anyhow, w.r.t. this PR I think we can merge as is |
Yet another down.
Relates to #758.