Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ts strict checking for binding modbus #1050

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Aug 3, 2023

Yet another down.

Relates to #758.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

Have some understanding problems w.r.t. some error messages. See below

packages/binding-modbus/src/modbus-connection.ts Outdated Show resolved Hide resolved
packages/binding-modbus/src/modbus-connection.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #1050 (dbf9979) into master (db4b2c1) will decrease coverage by 0.15%.
Report is 3 commits behind head on master.
The diff coverage is 67.85%.

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
- Coverage   75.63%   75.49%   -0.15%     
==========================================
  Files          80       80              
  Lines       15324    15385      +61     
  Branches     1460     1469       +9     
==========================================
+ Hits        11591    11615      +24     
- Misses       3699     3735      +36     
- Partials       34       35       +1     
Files Changed Coverage Δ
...ckages/binding-modbus/src/modbus-client-factory.ts 40.00% <0.00%> (-0.82%) ⬇️
packages/binding-modbus/src/modbus-connection.ts 83.20% <63.63%> (-2.08%) ⬇️
packages/binding-modbus/src/modbus-client.ts 86.77% <84.61%> (-0.27%) ⬇️

... and 3 files with indirect coverage changes

@danielpeintner
Copy link
Member

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

I tried already several times to activate the GitHub integration but I do not know "what" blocks it?

image

Shall I open a ticket on Eclipse side?

@danielpeintner
Copy link
Member

danielpeintner commented Aug 11, 2023

Shall I open a ticket on Eclipse side?

FYI: I opened https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3545

EDIT: Has been approved already .. cool. Let's see how the next PRs/commits look like

@relu91
Copy link
Member Author

relu91 commented Aug 11, 2023

@danielpeintner do you think we can merge it even if we have redcrosses in codecov?

@danielpeintner
Copy link
Member

@danielpeintner do you think we can merge it even if we have redcrosses in codecov?

We are now seeing these kind of "errors" in all our PRs now. I think we need to properly configure it and maybe show it as a warning or so.

Anyhow, w.r.t. this PR I think we can merge as is

@relu91 relu91 merged commit 8a80992 into eclipse-thingweb:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants