Update the v0.9.0-release branch with the latest tested working content #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove definition of `max` macro. Use OMR_MAX instead
Fix if defined() formatting and add OSX
…haracterCodingException Add missing throws CharacterCodingException
…TOEMappingforZTPF Disable Compiler ATOE Mapping for zTPF
Following 4 recognized methods have been long deprecated: 1. com_ibm_jit_JITHelpers_hashCodeImpl 2. java_lang_Object_hashCodeImpl 3. java_lang_System_currentTimeMillis [X86 only] 4. java_lang_Integer_rotateLeft [X86 only] Cleaning-up code related them. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
Code cleanup related to TR::X86PrivateLinkage::buildVFTCall, removing two deprecated parameters. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
WIP: Re-enable toLowerCase/toUpperCase acceleration
…onversion Revert "WIP: Re-enable toLowerCase/toUpperCase acceleration"
Modify API call so that caseConversionHelper recieves underlying arrays and length of string. Closes: eclipse-openj9#1934 Signed-off-by: Daniel Hong <daniel.hong@live.com>
Remove unused String constructors accepting one integer and returning an empty String with an appropriate capacity. Closes: eclipse-openj9#777 Signed-off-by: Daniel Hong <daniel.hong@live.com>
The ReduceSynchronizedFieldLoad codegen path did not check the load node's isSignExtendedTo64BitAtSource flag. As a result, a 32-bit value without sign extension can lead to program crashes. This commit fixes this issue by performing a sign extension on the loaded 32-bit field. Signed-off-by: Nigel Yu <yunigel@ca.ibm.com>
Adjust formatting to be consistent and update comments to indicate that an exception will always be pending at that point so no explicit action is required. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
- during compilation, the per-method TR::Options should be used instead of the global one - mostly happens at the Optimizer and Code Generation stage Signed-off-by: Harry Yu <harryyu1994@gmail.com>
- comp()->getOptions()->getOption(TR_XXX) is equivalent to comp()->getOptions(TR_XXX) - therefore simplify all similar instances Signed-off-by: Harry Yu <harryyu1994@gmail.com>
-XX:+DisableExplicitGC -> -Xdisableexplicitgc -XX:-DisableExplicitGC -> -Xenableexplicitgc Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
sun.misc.VM.booted() invoked in Thread.completeInitialization() to set sun.misc.VM.booted. This is needed to support IBM charset provider. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Pull Request eclipse-openj9#2169 removed VMThread reclamation logic; therefore passing rematerializeVMThread to TR_OutlinedInstructions is no longer needed. Removing it. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
Map -XX:[+-]DisableExplicitGC to OpenJ9-equivalent
OMR PR 2640 introduced TR_OutlinedInstructionsGenerator, which uses RAII to hide the management of the instruction stream manipulations. OpenJ9 now adopts it. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
When building using OMR_CROSS_CONFIGURE the tools and environment that the OMR tools will be built with must be specified since they cannot be detected by autoconf. Signed-off-by: Younes Manton <ymanton@ca.ibm.com>
Re-enable toLowerCase/toUpperCase acceleration
j9vm_cs.nls file update in TVT pass 2. Signed-off-by: Lei Pan <pleinb@cn.ibm.com>
Clean up deprecated recognized method inlining
Cleanup deprecated code related to buildVFTCall
Fix VM check for atomic-free. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Clang does not consider uintptr_t and uint64_t to be equivalent. Issue: eclipse-openj9#36 Signed-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>
Previously, if-defined preprocessor directives were only handling LINUX and WINDOWS. Issue: eclipse-openj9#36 Signed-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>
Atomic-free JNI work
The `usingCompressedReferences` variable is misleading as it does not imply compressed references are actually used. What this variable actually means is that the value we are storing into the object via compare and swap is a compressed reference. Recognized CAS sequences are reduced at lower trees phase [1] where the last two arguments being the expected value and the new value are lowered into compressed objects since under compressed references objects on heap are always compressed. For concurrent scavenge we need a read barrier on the expected value hence the read barrier under compressed references need not rely on the use of the `usingCompressedReferences` variable which means something totally different. We take this opportunity to first fix the bug and to improve the meaning of some of the variables in the modified function so it is not confusing for future readers. [1] https://github.com/eclipse/openj9/blob/8a36fcd5f23005bf5028d28b60fd61aa325940a1/runtime/compiler/codegen/J9CodeGenerator.cpp#L675-L683 Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Remove deferredVMAccessRelease
Increase semaphore count when retrying wait loop termination, to account for possible missing target directories. This is tested by TestAttachErrorHandling.test_startupShutdownRobustness(). Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Rework getJimModules()
* Minor formatting adjustment * Minor fix to ensure JNI_ERR is returned in all error cases Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
Validate zTPF Memory Reserve Factor during Xmx Validation. z/TPF doesn't have mmap and has a relatively small usable memory footprint compared to linux. When specifying an Xmx for the z/TPF platform there is a higher chance of specifying a higher amount then made available for the process. This update does a quick check during validation instead of waiting for the runtime to detect it an run dump agents related to OOM. Signed-off-by: James D Johnston <jjohnst@us.ibm.com>
The changes are to resolve all script issues detected when compiling JDK11 on Windows. Signed-off-by: CHENGJin <jincheng@ca.ibm.com>
Removed `destroy()` and `stop(Throwable)` from JAVA11 in `Thread.java` Signed-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>
Implement vectorized String.indexOf() on Z
Remove unused TR_AMD64currentTimeMillis on X86
Properly register assumptions on mergedWithOSRGuard
[ci skip] Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
…ment Validate zTPF Memory Reserve Factor during Xmx Validation
Signed-off-by: hangshao <hangshao@ca.ibm.com>
Ensure JNI_ERR returned for all failure cases
Improve attach API shutdown robustness
…olvesForDDRandConstgen Fix unresolve omrsig_handler for j9ddrgen and constgen executables.
Optimized prolog/epilog for private linkage on X86
Remove deprecated outlined new on X86
findNativeMethodFrame had two identical implementations, and is so trivial that it need not be a function call. Put it in VMHelpers.hpp instead. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Add one additional check in getExtractLocation().
Remove Thread.destroy() and Thread.stop(Throwable) from JAVA11
Unexclude jvmtitest ta001
…_JDK11 Fix various script issues with Windows JDK11
Configure z/TPF to disable Guarded Storage
Optimize findNativeMethodFrame
DanHeidinga
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for creation of rc2, capture the latest tested working content. I'll push the omr side directly once this is merged.