Remove definition of max macro. Use OMR_MAX instead
#2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note both files need a copyright update. |
Clang warns (and errors) on headers used in cpp files that define max as it conflicts with std::max. Change all uses of `max` to `OMR_MAX` in MethodMetaData.c and delete the define to address clang warnings. issue: eclipse-openj9#36 Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
|
Fixed copyright dates. Some day I'll get that right the first time |
|
jenkins test sanity win,plinux jdk8 |
|
jenkins test sanity plinux jdk8 |
pshipton
approved these changes
Jun 29, 2018
|
The windows test failures are jvmti tests: #2129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang warns (and errors) on headers used in cpp files that
define max as it conflicts with std::max. Change all uses
of
maxtoOMR_MAXin MethodMetaData.c and delete thedefine to address clang warnings.
issue: #36
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com