Improve attach API shutdown robustness #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase semaphore count when retrying wait loop termination, to account for possible missing target directories. This is tested by TestAttachErrorHandling.test_startupShutdownRobustness(). Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
Is test_startupShutdownRobustness an excluded test? Ideally it should be included as part of this PR, which likely means fixing #2047 at the same time. |
|
jenkins test all xlinux jdk8 |
|
The test is excluded in the OpenJ9 test suite, but is still running in the internal builds. |
pshipton
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase semaphore count when retrying wait loop termination,
to account for possible missing target directories.
This is tested by TestAttachErrorHandling.test_startupShutdownRobustness().
I ran the test 100 times. There were a few failures, all due to
#2047 which is a separate issue.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com