Clean up deprecated recognized method inlining #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dvictor
changed the title
0dvictor
force-pushed
the
cleanup
branch
2 times, most recently
from
286838b to
00cbb56
Compare
|
I'm having trouble following the logic for the currentTimeMillis removal - where is the point that makes it clearly dead? |
|
The code is not used under any scenarios and will crash JVM if it kicks in.
|
|
@0dvictor sorry I didn't get back to this one - can you rebase so I can run the build? |
|
Rebased. |
|
Jenkins test sanity |
|
Jenkins test sanity |
Following 4 recognized methods have been long deprecated: 1. com_ibm_jit_JITHelpers_hashCodeImpl 2. java_lang_Object_hashCodeImpl 3. java_lang_System_currentTimeMillis [X86 only] 4. java_lang_Integer_rotateLeft [X86 only] Cleaning-up code related them. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
|
There were Travis CI failures caused by out-of-dated OMR; hence I've rebased and re-launched Travis CI. All checks have passed now, could you re-launch sanity tests? @andrewcraik |
|
Jenkins test sanity |
|
Windows failures are due to #2129 |
andrewcraik
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 4 recognized methods have been long deprecated:
Cleaning-up code related them.
Signed-off-by: Victor Ding dvictor@ca.ibm.com