17.11 : Also checking line end when block structure is filtered #74478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release/dev17.11 to main
…changes Revert "Remove semantic model keep-alive code in completion (#73844)"
…solete attributes during early attribute binding: this isn't good, because it will cause us to throw out the bound attribute data we found during early binding. Depending on the order we bind constructors in, this can cause a race condition in the binding of overload resolution priority. Thankfully, this was racy enough that it failed a couple of times during CI, and I was able to explicitly reproduce the failure by pulling on attributes on one constructor or the other.
Move determination of language for an LSP request into the serialized queue to avoid race
* Avoid more large string constant fields * Make initializers run in correct order
* Fix modification of readonly locals through ref fields * Extend tests * Improve check * Add query tests
Also checking line end when block structure is filtered
…74411) This method showed up when investigating a recent regression in allocations due to a change in lightbulb behaviors. Although this method hasn't changed recently, it is one of the easiest ways to claw back some memory during this scenario. Locally, opening the vs-platform solution with this change reduces allocations under GetAnalyzerTypeNameMap from about 1.9% (63 MB) to about 0.1% (5 MB)
Formatting In progress In progress In progress In progress Host side' git pus Host side' git pus Host side' git pus Host side' git pus Host side Remote side Accessibility Tests Cast In progress' UI thread Tests Make private Make private Docs Simplify Clear the items Docs fix Reversinos Reversinos revert revert revert revert
Simplify HostAnalysisScope storage
Dispose per-instance services created by factories
This folder is used for build logs produced when environment variable MSBuildDebugEngine=1.
Ignore MSBuild_Logs folder
…state after a match
Also checking line end when block structure is filtered
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of ##74413