Cleanup in VS generator UI code. #74448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jul 18, 2024
| @@ -9,83 +9,73 @@ | |||
| using Microsoft.VisualStudio.Imaging; | |||
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Jul 18, 2024
| @@ -9,83 +9,73 @@ | |||
| using Microsoft.VisualStudio.Imaging; | |||
| using Microsoft.VisualStudio.Imaging.Interop; | |||
|
|
|||
| namespace Microsoft.VisualStudio.LanguageServices.Implementation.SolutionExplorer | |||
| namespace Microsoft.VisualStudio.LanguageServices.Implementation.SolutionExplorer; | |||
There was a problem hiding this comment.
FSNs and primary constructors.
CyrusNajmabadi
commented
Jul 18, 2024
| @@ -33,11 +33,11 @@ internal abstract class BaseItem : | |||
| { | |||
| public virtual event PropertyChangedEventHandler PropertyChanged { add { } remove { } } | |||
|
|
|||
| private readonly string _name; | |||
| protected readonly string Name; | |||
There was a problem hiding this comment.
part of the equality contract the derived tuypes check.
CyrusNajmabadi
commented
Jul 18, 2024
| @@ -123,7 +123,7 @@ private BulkObservableCollection<BaseItem> CreateDiagnosticAndGeneratorItems(Pro | |||
|
|
|||
| collection.AddRange( | |||
| AnalyzerReference.GetGenerators(language) | |||
| .Select(g => new SourceGeneratorItem(projectId, g, AnalyzerReference))); | |||
| .Select(g => new SourceGeneratorItem(projectId, SourceGeneratorIdentity.Create(g, AnalyzerReference), AnalyzerReference.FullPath))); | |||
There was a problem hiding this comment.
moved SGItem to be pure data.
CyrusNajmabadi
commented
Jul 18, 2024
|
|
||
| ruleSetDocument.Save(pathToRuleSet); | ||
| } | ||
| public override int GetHashCode() |
There was a problem hiding this comment.
equals/gethashcode are used in next PR as part of proper items in a observable-collectoin and virtualizing-tree-view.
ToddGrun
reviewed
Jul 18, 2024
src/VisualStudio/Core/Impl/SolutionExplorer/AnalyzerItem/AnalyzerItem.cs
Show resolved
Hide resolved
Formatting In progress In progress In progress In progress Host side' git pus Host side' git pus Host side' git pus Host side' git pus Host side Remote side Accessibility Tests Cast In progress' UI thread Tests Make private Make private Docs Simplify Clear the items Docs fix Reversinos Reversinos revert revert revert revert
CyrusNajmabadi
force-pushed
the
generatorCleanup
branch
from
d10efa4
to
bedf640
Compare
ToddGrun
reviewed
Jul 18, 2024
src/VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/CpsDiagnosticItemSourceProvider.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 18, 2024
src/VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/DiagnosticItem.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 18, 2024
src/VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/DiagnosticItem.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 18, 2024
...VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/LegacyDiagnosticItemSourceProvider.cs
Show resolved
Hide resolved
|
ok. will ping once this goes in and i meerge this into the other pr. |
jasonmalinowski
approved these changes
Jul 18, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out cleanup code from #74444