Simplify HostAnalysisScope storage #74055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
sharwell
changed the title
Starting with dotnet#28918, this type only ever exists in the context of a single analyzer, so we can remove the maps it contains and simplify calls into it.
sharwell
changed the title
ToddGrun
reviewed
Jun 21, 2024
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticStartAnalysisScope.cs
Show resolved
Hide resolved
ToddGrun
approved these changes
Jul 2, 2024
|
@dotnet/roslyn-compiler for reviews |
jjonescz
approved these changes
Jul 3, 2024
src/Compilers/Core/Portable/DiagnosticAnalyzer/DiagnosticStartAnalysisScope.cs
Show resolved
Hide resolved
|
@dotnet/roslyn-compiler for second review |
333fred
approved these changes
Jul 3, 2024
| @@ -19,102 +19,100 @@ namespace Microsoft.CodeAnalysis.Diagnostics | |||
| /// </summary> | |||
| internal sealed class AnalyzerAnalysisContext : AnalysisContext | |||
There was a problem hiding this comment.
Man, this type itself is starting to feel a bit redundant now...
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with #28918, this type only ever exists in the context of a single analyzer, so we can remove the maps it contains and simplify calls into it.