Fix issue with ForAttributeWithMetadataName being in an inconsistent state after a match. #74468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
commented
Jul 19, 2024
| @@ -338,29 +338,34 @@ bool matchesAttributeName(string currentAttributeName, bool withAttributeSuffix) | |||
| return false; | |||
|
|
|||
| seenNames.Push(currentAttributeName); | |||
|
|
|||
| foreach (var (aliasName, symbolName) in localAliases) | |||
| try | |||
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Jul 19, 2024
| } | ||
| finally | ||
| { | ||
| seenNames.Pop(); |
There was a problem hiding this comment.
early exits in the foreach code (a return true;) was causing us to not pop the vlaues we'd pushed onto this stack, leaving it in an inconsistent state.
In the test case this manifested as us going "we've already seen an attribute with this alias name, so we shouldn't look at it again" when we hit the second attribute.
I considered changing to have a single value that is retruned at the end, after hte pop. but i prefer this as it is more future proof, and clearly ensures that any sort of exiting will always leave things consistent.
…state after a match
CyrusNajmabadi
force-pushed
the
fawmnEarlyExit
branch
from
98bbe93
to
ef711e8
Compare
chsienki
approved these changes
Jul 19, 2024
jaredpar
approved these changes
Jul 21, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#105137