Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle duplicate connections to LocalPeers #378

Merged
merged 7 commits into from
Nov 15, 2023
Merged

fix: handle duplicate connections to LocalPeers #378

merged 7 commits into from
Nov 15, 2023

Conversation

gmaclennan
Copy link
Member

Fixes #374

@gmaclennan gmaclennan self-assigned this Nov 14, 2023
@gmaclennan gmaclennan linked an issue Nov 14, 2023 that may be closed by this pull request
LocalPeers needs to handle multiple connections per device #374
Closed
@gmaclennan gmaclennan marked this pull request as draft November 14, 2023 04:50
@gmaclennan gmaclennan marked this pull request as ready for review November 14, 2023 08:11
@gmaclennan gmaclennan requested a review from achou11 November 14, 2023 08:11
achou11
achou11 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes generally make sense! Added some non-blocking suggestions

src/local-peers.js Outdated Show resolved Hide resolved
src/local-peers.js Outdated Show resolved Hide resolved
src/local-peers.js Outdated Show resolved Hide resolved
src/local-peers.js Outdated Show resolved Hide resolved
src/local-peers.js Outdated Show resolved Hide resolved
src/local-peers.js Outdated Show resolved Hide resolved
@gmaclennan @achou11
Apply suggestions from code review
c4e18f7 
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
@gmaclennan
Copy link
Member Author

Fixes generally make sense! Added some non-blocking suggestions

Thanks for the suggestions, once tests pass I'll merge.

@gmaclennan gmaclennan merged commit 1909409 into main Nov 15, 2023
7 checks passed
@gmaclennan gmaclennan deleted the fix/local-peers branch November 15, 2023 13:00
This was referenced Nov 16, 2023
Closed
Merged
gmaclennan added a commit that referenced this pull request Nov 20, 2023
@gmaclennan
Merge branch 'main' into feat/initial-download
ca60188 
* main:
  chore: pin more hyper deps (#381)
  chore: extract and test construction of icon url (#366)
  chore: fix release workflow configuration (#379)
  chore: remove unused/unneeded deps (#376)
  chore: remove authstore (#377)
  fix: handle duplicate connections to LocalPeers (#378)
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Jul 25, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Jul 31, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 achou11 approved these changes

Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalPeers needs to handle multiple connections per device
2 participants
@gmaclennan @achou11