integrate icon plugin into MediaServer #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
Nov 10, 2023
Not sure how this PR would fix it, as I directly address in #370 (which re-enables it) |
also removes the projectPublicId constructor opt from both IconApi and BlobApi. unnecessary given that it's only used by the getMediaBaseUrl opt, so makes more sense to just handle it there.
achou11
force-pushed
the
ac/media-server-icons
branch
from
a8f755a to
f132e4a
Compare
Sorry, I got the blobs api confused with the icon api Test still fails though |
gmaclennan
added a commit
that referenced
this pull request
Nov 14, 2023
* fix/local-peers: new tests for duplicate connections fixed fake timers implementation for tests send invite to non-existent peer fix stream close before channel open fix: handle duplicate connections to LocalPeers fix: fix writing to blob store when also calculating content hash (#370) integrate icon plugin into MediaServer (#369) chore: Add debug logging (#373)
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #329
Changes grew a little in scope to account for some refactoring opportunities that I saw, namely:
projectPublicIdconstructor opt fromBlobApiandIconApiin favor of using the id when defining thegetMediaBaseUrl()opt