Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix writing to blob store when also calculating content hash #370

Merged
merged 5 commits into from
Nov 13, 2023
Merged

fix: fix writing to blob store when also calculating content hash #370

merged 5 commits into from
Nov 13, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 9, 2023

Closes #368

Honestly a super naïve attempt but hoping it does the main thing.

@achou11 achou11 requested a review from gmaclennan November 9, 2023 19:08
gmaclennan
gmaclennan approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that does just what we need. I've been meaning to do some cleanup of this code, so I added that here - I felt like the existing code was a little hard to understand because of the writeFile abstraction, and was inefficient because of serial writes

@gmaclennan
Copy link
Member

Also switched to streamx since that's what we're using elsewhere for streams

@achou11 achou11 mentioned this pull request Nov 13, 2023
Merged
@achou11 achou11 merged commit 4a18a9c into main Nov 13, 2023
7 checks passed
@achou11 achou11 deleted the fix/blob-api-write-file branch November 13, 2023 16:14
gmaclennan added a commit that referenced this pull request Nov 14, 2023
@gmaclennan
Merge branch 'main' into fix/local-peers
97df1c0 
* main:
  fix: fix writing to blob store when also calculating content hash (#370)
  integrate icon plugin into MediaServer (#369)
gmaclennan added a commit that referenced this pull request Nov 14, 2023
@gmaclennan
Merge branch 'fix/local-peers' into feat/initial-download
6174ce0 
* fix/local-peers:
  new tests for duplicate connections
  fixed fake timers implementation for tests
  send invite to non-existent peer
  fix stream close before channel open
  fix: handle duplicate connections to LocalPeers
  fix: fix writing to blob store when also calculating content hash (#370)
  integrate icon plugin into MediaServer (#369)
  chore: Add debug logging (#373)
This was referenced Nov 16, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlobApi writes hash contents instead of blob contents to BlobStore
2 participants
@achou11 @gmaclennan