Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused/unneeded deps #376

Merged
merged 5 commits into from
Nov 15, 2023
Merged

chore: remove unused/unneeded deps #376

merged 5 commits into from
Nov 15, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 13, 2023

just some housekeeping. one thing i wasn't too sure about was removing fastify from dev deps, since we already have it as a direct dep.

@achou11 achou11 requested a review from gmaclennan November 13, 2023 16:38
gmaclennan
gmaclennan previously requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes fastify (and any dep) should only be in one of dependencies or devDependencies. In fastify's case it's a production dependency, so can remote from devDeps.

Otherwise looks good.

@achou11 achou11 dismissed gmaclennan’s stale review November 15, 2023 15:50

Addressed blocking comment

@achou11 achou11 merged commit a48230b into main Nov 15, 2023
7 checks passed
@achou11 achou11 deleted the chore/remove-deps branch November 15, 2023 15:50
This was referenced Nov 16, 2023
Closed
Merged
gmaclennan added a commit that referenced this pull request Nov 20, 2023
@gmaclennan
Merge branch 'main' into feat/initial-download
ca60188 
* main:
  chore: pin more hyper deps (#381)
  chore: extract and test construction of icon url (#366)
  chore: fix release workflow configuration (#379)
  chore: remove unused/unneeded deps (#376)
  chore: remove authstore (#377)
  fix: handle duplicate connections to LocalPeers (#378)
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achou11 @gmaclennan