Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEO Paired False in OpenPilot Setting #112

Closed
WaliedA opened this issue Jul 4, 2017 · 4 comments
Closed

NEO Paired False in OpenPilot Setting #112

WaliedA opened this issue Jul 4, 2017 · 4 comments

Comments

@WaliedA
Copy link

WaliedA commented Jul 4, 2017

We have been getting NEO Paired = False in OpenPilot Setting, we also figured out the comma points are not redeemed in the account while using NEO. Only Chffr is redeemed.

We are using NEO in a non supported car with no connection to CANH ot CANL only power and ignition
@pjlao307
Copy link
Contributor

pjlao307 commented Jul 4, 2017

You won't get comma points unless the video includes CAN messages on the neo.

@geohot
Copy link
Contributor

geohot commented Jul 4, 2017

Hmm, you should, but only 1 per minute.

@WaliedA
Copy link
Author

WaliedA commented Jul 4, 2017

So I have connected it to Range Rover Sport, If I connect the CANh and CANl would it count the comma point, keeping in mind car has no ACC/LKAS

@energee
Copy link
Contributor

energee commented Jul 14, 2017 •
edited
Loading

It should give you 2 points when wired to CAN on an unsupported vehicle but I've seen some mixed behavior when only connected to one CAN. Seems to inconsistently show up in drive explorer, most but not all of the time after being uploaded. Try connecting to CAN and post the results.

rbiasini pushed a commit that referenced this issue Sep 25, 2018
Squashed 'opendbc/' changes from af7fff8..42f8c12
906b55a 
42f8c12 Adds Chinese Odyssey DBC (#110)
7b87882 Syntax and encoding fixes (#111)
f85e646 Update mercedes e350 dbc (#112)

git-subtree-dir: opendbc
git-subtree-split: 42f8c12
DavidWAbrahams pushed a commit to jeankalud/openpilot that referenced this issue Sep 26, 2018
OP 0.5.4
5fd6b81 
Squashed commit of the following:

commit 1391e0c
Merge: 5b53cd4 a422246
Author: David Abrahams <you@example.com>
Date:   Wed Sep 26 04:52:42 2018 +0000

    Merge remote-tracking branch 'op/devel' 0.5.4 into cruise_devel

commit a422246
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:13:41 2018 -0700

    openpilot v0.5.4 release

commit e5b2ec4
Merge: 97f1ee4 906b55a
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:04:00 2018 -0700

    Merge opendbc subtree

commit 906b55a
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:04:00 2018 -0700

    Squashed 'opendbc/' changes from af7fff8..42f8c12

    42f8c12 Adds Chinese Odyssey DBC (commaai#110)
    7b87882 Syntax and encoding fixes (commaai#111)
    f85e646 Update mercedes e350 dbc (commaai#112)

    git-subtree-dir: opendbc
    git-subtree-split: 42f8c12

commit 97f1ee4
Merge: 2d450bc 5c0935d
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:03:58 2018 -0700

    Merge panda subtree

commit 5c0935d
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:03:58 2018 -0700

    Squashed 'panda/' changes from f2292e4..5253ab0

    5253ab0 bump panda
    6277139 GM Volt: allowing 300 max steer
    63b7926 Hyundai safety: temporarily disabled button spam check to avoid camera faults
    53aef76 GM: passive on LKA-only cars (commaai#135)
    01b5235 bumped panda version
    1c0ffd1 Hyundai safety: simplifications
    56794d6 Hyundai Safety Auto-Detect which CAN bus Camera is on (commaai#134)

    git-subtree-dir: panda
    git-subtree-split: 5253ab0

commit 2d450bc
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date:   Fri Sep 21 19:41:44 2018 -0700

    Increase Volt's steering limit (commaai#351)

    * Increase Volt's steering limit

    * Merge panda subtree

commit 96c9238
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date:   Fri Sep 21 19:40:52 2018 -0700

    GM refactor (commaai#374)

commit 5b53cd4
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 03:17:44 2018 +0000

    ACC: syntax fix

commit d1d642e
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 03:15:49 2018 +0000

    ACC: Syntax fix

commit f5d3e51
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 00:15:57 2018 +0000

    ACC: If disabled, disengage traditional cruise control

commit 5ad11b2
Author: David Abrahams <you@example.com>
Date:   Thu Sep 20 23:30:29 2018 +0000

    ACC: disable on brakes or slowing below min speed

commit 14b7ead
Author: wocsor <37704329+wocsor@users.noreply.github.com>
Date:   Thu Sep 20 19:06:15 2018 -0400

    Add XSE trim to fingerprints (commaai#372)

commit 402faab
Author: Ted Slesinski <ted@slesinski.org>
Date:   Wed Sep 19 20:59:18 2018 -0400

    Docker environment breaking (commaai#369)

    * Fixes matplotlib dependency

    * Use version 2.1.2

commit d56e44b
Author: David Abrahams <you@example.com>
Date:   Wed Sep 19 18:06:44 2018 +0000

    ACC: Don't auto-engage if vRel < 0

commit d359f70
Author: David Abrahams <you@example.com>
Date:   Wed Sep 19 17:08:03 2018 +0000

    ACC: Don't autoresume if there is a slow car in front

commit de79a07
Author: Ted Slesinski <ted@slesinski.org>
Date:   Tue Sep 18 00:39:58 2018 -0400

    Add support for accord hybrid (commaai#361)

commit 4b2c137
Author: wocsor <37704329+wocsor@users.noreply.github.com>
Date:   Mon Sep 17 16:24:52 2018 -0400

    update CHR fingerprint (commaai#364)

    CHR 2016 fingerprint has more messages
mespiritu pushed a commit to mespiritu/openpilot that referenced this issue Apr 1, 2019
@arne182
Merge pull request commaai#112 from ShaneSmiskol/release2
3151153 
Added username and email logging when crash occurs
jonnyapp1eseed pushed a commit to jonnyapp1eseed/openpilot that referenced this issue Apr 17, 2019
@ErichMoraga
Merge pull request commaai#112 from commaai/devel
3da63eb 
Catching up to 0.5.9
@pd0wm pd0wm closed this as completed Jun 2, 2019
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 10, 2019
@adeebshihadeh @rbiasini
Update mercedes e350 dbc (commaai#112)
f85e646 
* OpenDBC updates

* OpenDBC updates

* fix mb e350 filename

* removed question mark

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* cruise control

* use openpilot names

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* clean up mercedes dbc

* OpenDBC updates

* OpenDBC updates

* invert steering angle

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates
rafcabezas pushed a commit to rafcabezas/openpilot that referenced this issue Oct 31, 2019
@tb205gti @BogGyver
Disable LDW for 4 seconds after blinker transition from on to off (co…
0ef304e 
…mmaai#112)

If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz.
SippieCup pushed a commit to SippieCup/openpilot that referenced this issue Nov 14, 2019
@BogGyver
Promoting OP 0.6.5 to Devel (commaai#126)
801f0f0 
* fix ALCA module

* Update ALCA_module.py

* Promote panda fixes from alpha to devel (commaai#98)

* Fix for mock car crash

* fix ALCA module

* do not use

* radar_interface logic improvements

* remove radar logging

* radar_interface refactoring

* Log radar_interface CAN error, Process Comm Errors (commaai#95)

* Log radar_interface CAN error

* Add support for process comm error logging

* Improve Process Comm error logging

* Can and CommError throttling

* Update radar_interface.py

* fixing push per Raf's comments

* ALCA and radar_interface work (commaai#96) (commaai#97)

* do not use

* radar_interface logic improvements

* remove radar logging

* radar_interface refactoring

* Update radar_interface.py

* fixing push per Raf's comments

* fix process comm issue

* switch radard from lane_parser to model

* radar/ALCA changes

* fix lane width

* switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving

* cleanup some debug info to be able to restart ALCA research

* tweaks on safety_tesla.h for can bus isolation

* few more cleanups to safety_tesla.h

* fix start signal logic

* Increase LEXUS_IS safetyParam to 77 (commaai#841)

* use list comprehension (commaai#839)

* use list comprehension

* oops index range fix

* simplify encode/decode in dbc (commaai#840)

* simplify encode/decode

* 2019 Highlander Hybrid Limited Platinum (commaai#843)

fingerprint from ogdragonzypher on Discord

* Allow to lock safety mode to keep gm/tesla cars supported (commaai#844)

* Force subaru to assume the stock camera is connected (commaai#849)

* Revert to using the sum of the lane line probabilities instead of the the product

* Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836)

* Generalized core OP CRC support plus extra bits for Volkswagen MQB.

* Update ref to process_replay regression test

* Remove unneded use of replace, causing json to fail loading the alert

* Add supported car for 2019 Toyota Altis Hybrid (commaai#859)

* add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market)

* remove unnecessary comprehensions (commaai#863)

* Added fingerprint from Sienna XLE AWD (commaai#848)

* Added fingerprint from Sienna XLE AWD

* Update driver_monitor.py

* Update driver_monitor.py

* Update driver_monitor.py

* fix stupid merge issue

* Adds 2019 Lexus ES (non hybrid) (commaai#866)

* Adds 2019 Lexus ES (non hybrid)

* Updated test route

* merge issues

* Update README with now supported Subaru Harness

* Disable LDW for 4 seconds after blinker transition from on to off (commaai#112)

If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz.

* Disable HSO for 3 seconds after blinker has been active (commaai#111)

Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode)

* params learner to only learn @ cons speed

Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant

* Update to match new version of python in eons

* python 3 fixes for test client / server

* async/await server

* Don't log for action message as it's too often, and we throttle it internally.

* fix merge issue in thermald

* fixes and tweaks; code simplification

* Saving P,I,F parameters from pid controller (commaai#116)

Added separate save/load functions, try catch - and saving the right constants to the params file.

* Feature/tinklad throttling + linting (commaai#118)

* Throttle tinlkad's attemptToSendPendingMessages

* Remove get_git_remote from registration. It's defined in version already.

* tinklad linting

* tesla linting

* Prevent multiple readings of the pid params file (commaai#119)

..only load the pid values when we initiate the LoC

* missing V_PID_FILE constant (commaai#121)

* show cars in IC for non-radar users (commaai#120)

* bug fixes

* Fix issue where user info was being dropped on no connectivity (commaai#122)

* move pisParams, fix GPS logging

* Bugfix tinklad throttling (commaai#124)

* ALCA4 (still in dev)

* ALCA4 tuning

* ALCA4 alpha release

* ALCA4 tweak for turns

* ACC fix; LDW mite during ALCA

* ALCA polishing

* fix enter_canloader.py for python 3

* should_ldw changes

moved the should_ldw code closer together and added status messages for when LDW is active and inactive

* thermald and ALCA

* ALCA sinplified logic
rav4kumar pushed a commit to rav4kumar/openpilot that referenced this issue Jun 16, 2020
@sshane
Fix dynamic gas and RSOD (commaai#112)
7cac3e2 
* see if I can reproduce dynamic gas error

* Now attempt fix

* send commit as well

* disable LQR for Camry, fix dynamic gas RSOD

* update README.md

* deprecate awareness_factor

* deprecate awareness_factor

* fully remove

* add curvature_learner thanks to zorrobyte

* simplify curv learner

* Revert "simplify curv learner"

This reverts commit 6eab548.

* Revert "add curvature_learner thanks to zorrobyte"

This reverts commit a2d03bd.

* just in case
Coral-coder pushed a commit to Coral-coder/openpilot that referenced this issue Feb 20, 2023
@sunnyhaibin
mapd: Remove preloaded dependencies (commaai#112)
0fd1cfb
carleeno pushed a commit to carleeno/openpilot that referenced this issue Aug 2, 2024
@sunnyhaibin
Revert "mapd: Preload dependencies (commaai#111)" (commaai#112)
9a78c0a 
This reverts commit 0035126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@geohot @energee @pd0wm @pjlao307 @WaliedA