Skip to content

Commit 96c9238

Browse files
vntarasovrbiasini
authored andcommitted
GM refactor (commaai#374)
1 parent 14b7ead commit 96c9238

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

selfdrive/car/gm/carcontroller.py

+7-9
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,11 @@ def update(self, sendcan, enabled, CS, frame, actuators, \
9191
### STEER ###
9292

9393
if (frame % P.STEER_STEP) == 0:
94-
final_steer = actuators.steer if enabled else 0.
95-
apply_steer = final_steer * P.STEER_MAX
96-
97-
apply_steer = apply_std_steer_torque_limits(apply_steer, self.apply_steer_last, CS.steer_torque_driver, P)
98-
9994
lkas_enabled = enabled and not CS.steer_not_allowed and CS.v_ego > 3.
100-
101-
if not lkas_enabled:
95+
if lkas_enabled:
96+
apply_steer = actuators.steer * P.STEER_MAX
97+
apply_steer = apply_std_steer_torque_limits(apply_steer, self.apply_steer_last, CS.steer_torque_driver, P)
98+
else:
10299
apply_steer = 0
103100

104101
self.apply_steer_last = apply_steer
@@ -115,15 +112,16 @@ def update(self, sendcan, enabled, CS, frame, actuators, \
115112

116113
if self.car_fingerprint == CAR.VOLT:
117114
# no output if not enabled, but keep sending keepalive messages
118-
# threat pedals as one
115+
# treat pedals as one
119116
final_pedal = actuators.gas - actuators.brake
120117

121118
# *** apply pedal hysteresis ***
122119
final_brake, self.brake_steady = actuator_hystereses(
123120
final_pedal, self.pedal_steady)
124121

125122
if not enabled:
126-
apply_gas = P.MAX_ACC_REGEN # TODO: do we really need to send max regen when not enabled?
123+
# Stock ECU sends max regen when not enabled.
124+
apply_gas = P.MAX_ACC_REGEN
127125
apply_brake = 0
128126
else:
129127
apply_gas = int(round(interp(final_pedal, P.GAS_LOOKUP_BP, P.GAS_LOOKUP_V)))

0 commit comments

Comments
 (0)