-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llvm16 #185
Llvm16 #185
Commits on Sep 11, 2023
-
[DF] Reduce duration "helpers" unit test
by reducing the number of events by a factor 100 for: - ProgressHelper_Existence_ST - ProgressHelper_Existence_MT - ProgressHelper_existence_singleTTreeInput and by removing jitting in favor of compilation where possible. The coverage is the same as before.
Configuration menu - View commit details
-
Copy full SHA for d606722 - Browse repository at this point
Copy the full SHA d606722View commit details -
[DF] Reduce duration of concurrency unit test
by about two orders of magnitude (150 s --> 1s) by using a reasonable number of threads throughout the battery of tests (in some cases the machine could be heavily overcommitted) and by eliminating the RDF jitting, which happens sequentially.
Configuration menu - View commit details
-
Copy full SHA for d4f699a - Browse repository at this point
Copy the full SHA d4f699aView commit details -
[DF] Reduce duration of "simple" unit test
by a factor ~2x (100s -> 50s)by eliminating jitting in favor of fully compiled RDF instances where possible, i.e. w/o reducing test coverage.
Configuration menu - View commit details
-
Copy full SHA for 88d11e4 - Browse repository at this point
Copy the full SHA 88d11e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62deeb1 - Browse repository at this point
Copy the full SHA 62deeb1View commit details -
[DF][10484] Cleanup after exception during evt loop
This commit reorganizes the RLoopManager::Run function, encapsulating the cleanup of the RDF nodes in the destructor of a class in order to profit from RAII and perform all necessary operations even if the event loop is interrupted by an exception.
Configuration menu - View commit details
-
Copy full SHA for 6214280 - Browse repository at this point
Copy the full SHA 6214280View commit details -
[RF] Test cleanup after exception in an evt loop
Add a unit test for the cleanup happening after the event loop is interrupted by an exception. Moreover, adapt two existing unit tests to the new implementation of RLoopManager::Run. The two tests relied on a faulty behaviour of RDF, which allowed to trigger subsequent event loops by dereferencing RResultPtr's instances and trapping the exception thrown during the event loop in a try-catch block.
Configuration menu - View commit details
-
Copy full SHA for 8f3d1f3 - Browse repository at this point
Copy the full SHA 8f3d1f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a51c0b - Browse repository at this point
Copy the full SHA 8a51c0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b83c3d - Browse repository at this point
Copy the full SHA 3b83c3dView commit details -
[RF] Add function to clear Minuit status history in RooMinimizer
As requested in this forum post: https://root-forum.cern.ch/t/memory-leak-in-fits/56249/4
Configuration menu - View commit details
-
Copy full SHA for c0d9da9 - Browse repository at this point
Copy the full SHA c0d9da9View commit details -
[RF] Limit maximum number of thread blocks in RooFit CUDA code
The number of thread blocks in kernel calls should not be excessively large, it's sufficient if it's in the order of the number of streaming multiprocessors. In particular, this circumvents a problem with the NLL reduction kernels with grid sizes larger than 512. With this change, there are potentially less threads than events when summing likelihoods, so in the NLL reduction kernels, each thread also has to reduce a few elements in a loop. Closes root-project#13603.
Configuration menu - View commit details
-
Copy full SHA for 567cba8 - Browse repository at this point
Copy the full SHA 567cba8View commit details -
[RF] Consistent RooCmdArg names for all
RooFit::Import()
overloadsThere are different overloads of `RooFit::Import()` for importing different object types to RooFit dataset classes. However, they return a `RooCmdArg` that is named after the type of the imported object. That causes some inconsistencies. For example, if you import a map of `std::unique_ptr<RooDataHist>`, the name will be different than for `RooDataHist*` because there is a special overload for the latter. It is better to fixup this inconsistency, and then disentangle the different types in the functions that consume these `RooFit::Import()` command arguments. This caused some trouble when importing RooDataHists into a combined dataset, which is why this fix is coming now. These changes are covered by the tutorial tests.
Configuration menu - View commit details
-
Copy full SHA for 8181b7d - Browse repository at this point
Copy the full SHA 8181b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9d6616 - Browse repository at this point
Copy the full SHA b9d6616View commit details -
[RF] Support expressions with complex numbers in RooClassFactory
This is to enable support for expressions representing the complicated amplitudes in partial wave analysis.
Configuration menu - View commit details
-
Copy full SHA for e3f3a1f - Browse repository at this point
Copy the full SHA e3f3a1fView commit details -
[RF] Use
std::string
instead of C-style strings in RooClassFactoryThis should preserve backwards compatibility, because `const char*` implicitly casts to `std::string`.
Configuration menu - View commit details
-
Copy full SHA for b01408a - Browse repository at this point
Copy the full SHA b01408aView commit details -
[RF] Don't recompile when requesting the same class instance twice
If you call `makePdfInstance` or `makeFunctionInstance` twice in a row with the same arguments, the RooClassFactory should not have to recompile anything. This is particularly important to support the jupyter notebook workflow, where the same cell might be run several times. In fact, before this commit, calling the `makeClassInstance` function twice in a row with the same arguments resulted in a crash.
Configuration menu - View commit details
-
Copy full SHA for 0a0bcaa - Browse repository at this point
Copy the full SHA 0a0bcaaView commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4ebc357 - Browse repository at this point
Copy the full SHA 4ebc357View commit details -
[Math] Respawn genvector tests
because they accidentally dropped out from the building and testing process during the migration to CMake. Minimal changes to the code were applied to let them run, respecting the original coding style.
Configuration menu - View commit details
-
Copy full SHA for 4b2df16 - Browse repository at this point
Copy the full SHA 4b2df16View commit details -
[http] adjust timer interval depending on the load
If there are no requests are processed during last 500 attempts, timer switch to the slow mode with 100 ms period. But immediately switched back to fast mode if new if new requests are processed.
Configuration menu - View commit details
-
Copy full SHA for cb86a11 - Browse repository at this point
Copy the full SHA cb86a11View commit details -
[webwindow] let use http server processing thread for widgets
This is very special mode will be used only for the python, which creates special thread for events processing. And this thread is changing with the time
Configuration menu - View commit details
-
Copy full SHA for 8d1d9d4 - Browse repository at this point
Copy the full SHA 8d1d9d4View commit details -
[webgui] let use TWebCanvas also without connection
It is intermediate state when web window is shown, but no active connection is established. At such moment canvas->Update() was not updating objects - like invoking THStack::BuildPrimitives() to introduce all necessary histograms. Therefore create artificial batch connection which do exactly same job as active web window connection - but does not send any data. Also improve timer handling in TWebCanvas. Instead of enabling/disabling this timer just use fast or slow mode - changing intervals Instead
Configuration menu - View commit details
-
Copy full SHA for bc9d21a - Browse repository at this point
Copy the full SHA bc9d21aView commit details -
[webgui] always checks callbacks processing in web window
Internally web window has special checks for thread id - when it assigned. With external events processing such thread is not set
Configuration menu - View commit details
-
Copy full SHA for 73da3aa - Browse repository at this point
Copy the full SHA 73da3aaView commit details -
[webgui] immediately assign main thread in python case
In such special mode web canvas or any other web components created from the main python thread - which stored at the moment when web win manager created. Callback only from this thread are allowed - all other threads has to be ignored.
Configuration menu - View commit details
-
Copy full SHA for 70d03dc - Browse repository at this point
Copy the full SHA 70d03dcView commit details -
[pyroot] in case of web display update web canvas in EventInputHook
This function called regularly from interactive python session and can be used for proper update of the active canvas
Configuration menu - View commit details
-
Copy full SHA for 972cf90 - Browse repository at this point
Copy the full SHA 972cf90View commit details -
[webcanvas] correctly check first normal connection
Now first connection in list is batch connection, used for async update.
Configuration menu - View commit details
-
Copy full SHA for 03dd288 - Browse repository at this point
Copy the full SHA 03dd288View commit details -
[RF] Give example for multiple categories plot in rf501_simultaneouspdf
Also, throw an exception with a helpful error message if the user attempts to use `RooFit::Slice()` with a comma-separates list of category states, which is not supported. This addresses a question on the forum: https://root-forum.cern.ch/t/plotting-two-categories-of-simultaneous-fit-in-a-single-plot/56250
Configuration menu - View commit details
-
Copy full SHA for ea666a2 - Browse repository at this point
Copy the full SHA ea666a2View commit details -
Fix axis labels tilt Fix THStack update Support e1hist combination of draw options th1 render order of filled area and markers
Configuration menu - View commit details
-
Copy full SHA for 917b19c - Browse repository at this point
Copy the full SHA 917b19cView commit details -
[TMVA] Remove dependency on torch.onnx submodule
As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.
Configuration menu - View commit details
-
Copy full SHA for c1dbe06 - Browse repository at this point
Copy the full SHA c1dbe06View commit details
Commits on Sep 13, 2023
-
[rootx] Remove "core developers" from splash window:
We do not show this anymore, and this requires complex operations and - in its current implementation - a working ROOT build as part of the version update.
Configuration menu - View commit details
-
Copy full SHA for 9b2b237 - Browse repository at this point
Copy the full SHA 9b2b237View commit details -
[core,cmake,build] Define ROOT version in header:
This simplifies the release procedure: no more bootstrapping, no more running of scripts; the source is the source. Given that the source now has the authoritative version number for releases (unlike for dev branches, of course) the ROOT package version is now determined from that header, rather than git describe which is less reliable. The updated release procedure will appear at https://root.cern/for_developers/release_checklist/
Configuration menu - View commit details
-
Copy full SHA for 13b0706 - Browse repository at this point
Copy the full SHA 13b0706View commit details -
Configuration menu - View commit details
-
Copy full SHA for f45f2c2 - Browse repository at this point
Copy the full SHA f45f2c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c72f78 - Browse repository at this point
Copy the full SHA 7c72f78View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a2971 - Browse repository at this point
Copy the full SHA f4a2971View commit details -
[minuit2] pick up ROOT version from ROOTConfig-version.cmake:
build/version_number is gone.
Configuration menu - View commit details
-
Copy full SHA for 8ce465c - Browse repository at this point
Copy the full SHA 8ce465cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c43684 - Browse repository at this point
Copy the full SHA 5c43684View commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9c3558a - Browse repository at this point
Copy the full SHA 9c3558aView commit details -
[RF][PyROOT] Avoid boolean operators on numpy arrays in unit test
The `n_in_range` reference value in the unit test `roodataset_numpy.TestRooDataSetNumpy.test_ignoring_out_of_range` apparently doesn't get computed right on some 32 platforms. I can't reproduce the problem, but I'm sure it will be fixed by avoiding the use of the operators `&` and `|` with numpy arrays. Just doing a manual loop in Python should be more platform independent. Closes root-project#12162.
Configuration menu - View commit details
-
Copy full SHA for 2b3dd4f - Browse repository at this point
Copy the full SHA 2b3dd4fView commit details -
[Doc] Reformulate Doxy doc not to trigger a compiler warning
which is `root/net/net/src/TNetFile.cxx:19:29: warning: '/*' within block comment [-Wcomment]` on clang on macos 13.5.1
Configuration menu - View commit details
-
Copy full SHA for ca43bce - Browse repository at this point
Copy the full SHA ca43bceView commit details -
[math] Don't incl. "Math/Error.h" and "Math/Util.h" in Minuit2 headers
The "Math/Error.h" header is not shipped with standalone Minuit2. It is not a perfect solution to just ship it with Minuit2, because the Error.h header behaves differently depending on the `MATHCORE_STANDALONE` macro being defined or not. The code would only work correctly if the user defines the `MATHCORE_STANDALONE` herself in the user code that uses standalone Minuit2, which would be annoying. Instead, this commit proposes another solution to the problem: for all headers also used in Minuit2 standalone, MathCore moves the definitions of all functions that use `Math/Error.h` out of the header files in the cxx files. Like this, the `Math/Error.h` is only a build dependency of standalone Minuit2, and the user doesn't need to define the `MATHCORE_STANDALONE` macro for it to work. Including the "Math/Util.h" header needs to be avoided for similar reasons (it's about another preprocessor macro related to `veccore`).
Configuration menu - View commit details
-
Copy full SHA for 160d396 - Browse repository at this point
Copy the full SHA 160d396View commit details -
[tmva][pymva] Use .h5 file instead of .keras
Go back to use .h5 files instead of .keras due to a problem in Keras loading .keras files on MacOS ARM (see https://github.com/keras-team/keras/issues/18278 )
Configuration menu - View commit details
-
Copy full SHA for 7793c20 - Browse repository at this point
Copy the full SHA 7793c20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0139f28 - Browse repository at this point
Copy the full SHA 0139f28View commit details -
[tmva][pymva] Do not disable tensorflow eager execution on MacoS
Disbaling it causes an interference with multiprocessing and a restart of the process after it is endeded. This fixes the timeout of the PyKeras tests on MacOS. This commits apply also some small fixes/improvements on the deletetion of some TMVA objects.
Configuration menu - View commit details
-
Copy full SHA for 8b005a0 - Browse repository at this point
Copy the full SHA 8b005a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08e9192 - Browse repository at this point
Copy the full SHA 08e9192View commit details -
[tmva][sofie] Add in RSofieReader support for multiple inputs and cus…
…tom operators To add the custom operator the function Load is added in RSofieReader Fix also the Keras parsing tests to use RSofieReader Add also a function to print the output tensors in RModel
Configuration menu - View commit details
-
Copy full SHA for ead7963 - Browse repository at this point
Copy the full SHA ead7963View commit details -
Configuration menu - View commit details
-
Copy full SHA for 352c353 - Browse repository at this point
Copy the full SHA 352c353View commit details -
[tmva][pymva] Use less events on testPyKerasRegression
Reduce number of events to avoid timeout of the test. Do this separtly for MAcOSX, since we cannot disable there eager execution
Configuration menu - View commit details
-
Copy full SHA for 1c5d7af - Browse repository at this point
Copy the full SHA 1c5d7afView commit details
Commits on Sep 15, 2023
-
[RF] Fix skipping of zero weights in tests statistic caching
There was an evil hack in `RooAbsOptTestStatistic`: ```c++ _dataClone->cacheArgs(this,_cachedNodes,_normSet,!_funcClone->getAttribute("BinnedLikelihood")) ; ``` The final parameter determins if zero weights should be skipped when recalculating the caches. Indeed, for the NLL case, this corresponds to the BinnedLikelihood attrribute being present or not, but it broke the other test statistics for which zero weights should not be skipped at all. This commit suggests a safer way to manage this with a new `RooAbOptTestStatistic::_skipZeroWeights` flag. In particular, this change fixed a bug that got uncovered during a forum discussion: https://root-forum.cern.ch/t/failing-chi2-fit/56309/3
Configuration menu - View commit details
-
Copy full SHA for a7008eb - Browse repository at this point
Copy the full SHA a7008ebView commit details -
[RF] Make extended fit default of RooAbsPdf::fitChi2() same as in fitTo
It is confusing to the users that the chi2 fit is by default not extended, even if the pdf is extended. Because this is what happens in normal likelihood fits. This commit makes that behavior consistent and explains it in the release notes. Also, a new error message is added for the case you forcing a non extended fit on a pdf that must be extended, because this is guaranteed to give wrong results.
Configuration menu - View commit details
-
Copy full SHA for 1df034b - Browse repository at this point
Copy the full SHA 1df034bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e12da4 - Browse repository at this point
Copy the full SHA 2e12da4View commit details -
[RF] Don't recommend direct use of RooChi2Var in RooPlot documentation
The test statistic classes should not be used directly, but always via the `createNLL()` (or in this case `createChi2()`) wrapper.
Configuration menu - View commit details
-
Copy full SHA for 1fd6bfd - Browse repository at this point
Copy the full SHA 1fd6bfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 408feb3 - Browse repository at this point
Copy the full SHA 408feb3View commit details -
[RF] Explain behavior of Extended() command in fitTo() and chi2FitTo()
This commit improves the documentation of `RooAbsPdf::fitTo()` and `RooAbsReal::chi2FitTo()` by adding a more detailed explanation of the `Extended()` command argument.
Configuration menu - View commit details
-
Copy full SHA for b22c152 - Browse repository at this point
Copy the full SHA b22c152View commit details -
Configuration menu - View commit details
-
Copy full SHA for 807e256 - Browse repository at this point
Copy the full SHA 807e256View commit details -
[RF][HS3] Added methods to automatically transform variables
Also, renamed "bounds" to "edges" for data export.
Configuration menu - View commit details
-
Copy full SHA for 38a30c2 - Browse repository at this point
Copy the full SHA 38a30c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e9a07f - Browse repository at this point
Copy the full SHA 6e9a07fView commit details -
[RF][HS3] Allow for non-exact matching in unit tests - off by default
This is useful for debugging, but off by default.
Configuration menu - View commit details
-
Copy full SHA for b03e65a - Browse repository at this point
Copy the full SHA b03e65aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 282b41c - Browse repository at this point
Copy the full SHA 282b41cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d4ea7 - Browse repository at this point
Copy the full SHA 11d4ea7View commit details -
[RF] Use Minuit2 in
testHS3SimultaneousFit
The fit results of Minuit2 are less random, and therefore we can tighten the test tolerance.
Configuration menu - View commit details
-
Copy full SHA for 592b124 - Browse repository at this point
Copy the full SHA 592b124View commit details -
[RF] Avoid fitting empty dataset in
testRooAbsPdf
unit testsFitting empty datasets doesn't give you a well-defined likelihood, and Minuit2 would actually explicitly print errors that would cause the test to fail. It's better to actually simulate non-empty toy datasets for fitting. Then, the unit tests will also pass when Minuit2 will be the default in the future.
Configuration menu - View commit details
-
Copy full SHA for 75146cc - Browse repository at this point
Copy the full SHA 75146ccView commit details -
[RF] Fix inconsistency in
RooMinimizer
about minimizer typeThis is a potential problem: ```c++ setMinimizerType(type); _theFitter->Config().SetMinimizer(type, alg); ``` The call to `setMinimizerType()` will set a default minimizer if `type` is empty. This default minimizer is right now the same as in general ROOT, but if RooFit would have a different default, the default minimizer of the RooMinimizer and the internal `_theFitter` would become out of sync, as `SetMinimizer(type)` takes the ROOT default if type is empty, not the RooMinimizer default. The better approach is this: ```c++ setMinimizerType(type); _theFitter->Config().SetMinimizer(_cfg.minimizerType.c_str(), alg); ``` First, `setMinimizerType(type)` sets the minimizer type in `_cfg.minimizerType`, and then this information is taken to set the minimizer of the `ROOT::Fitter`.
Configuration menu - View commit details
-
Copy full SHA for 16bb01f - Browse repository at this point
Copy the full SHA 16bb01fView commit details -
[RF][HS3] Store reference norm. set of RooAddPdf also in an attribute
By storing the reference normalization set also in an attribute, one gets the JSON IO for the `_refCoefNorm` for free, because attributes are always covered by the JSON IO.
Configuration menu - View commit details
-
Copy full SHA for 6385744 - Browse repository at this point
Copy the full SHA 6385744View commit details -
[RF] Add flag to define RooExponential in the standard
exp(-c*x)
wayIn particular, this is used for the RooFit HS3 import and export.
Configuration menu - View commit details
-
Copy full SHA for a03076e - Browse repository at this point
Copy the full SHA a03076eView commit details -
[RF] Format code of RooExponential and RooLognormal
As these classes are changed quite a bit by the previous and next commits, it is a good time to format them now.
Configuration menu - View commit details
-
Copy full SHA for 9cb2aab - Browse repository at this point
Copy the full SHA 9cb2aabView commit details -
[RF] Add flag to define RooLognormal in the standard way
Add a flag to define the RooLognormal with `mu` and `sigma` instead of their exponentiated values. In particular, this is used for the RooFit HS3 import and export.
Configuration menu - View commit details
-
Copy full SHA for 4de48ca - Browse repository at this point
Copy the full SHA 4de48caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12d8a75 - Browse repository at this point
Copy the full SHA 12d8a75View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c1002 - Browse repository at this point
Copy the full SHA e1c1002View commit details
Commits on Sep 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8c9f8bf - Browse repository at this point
Copy the full SHA 8c9f8bfView commit details -
[RF] Remove multi-range chi-square fit logic from RooAbsPdf
Almost a year ago, I fixed the support for comma-separated normalization ranges for pdfs, e.g. `pdf.setNormRange("range1,range2")` was fixed also for RooAddPdfs. As a result, the logic for multi-range likelihood fits was removed from `createNLL()`, because the multi-range fit didn't have to be treated as a special case anymore. The same applies also to chi-square fits. In fact, the reason why the `RooChi2Var` constructor and `RooAbsReal::createChi2()` methods had a `RooAbsPdf` overload was *only* this workaround! For regular RooAbsReals, the workaround was not necessary, because there is no normalization. Therefore, quite a few functions were removed in this commit. The multi-range chi2 fit is now also validated by the multi-range fit unit test in `testRooAbsPdf`. This is a follow-up to PR root-project#11455 (commit fa10523 in particular), where the same change was already make for regular likelihoods.
Configuration menu - View commit details
-
Copy full SHA for 889beb3 - Browse repository at this point
Copy the full SHA 889beb3View commit details -
[RF] Avoid separate RooXYChi2Var constructors for pdfs and functions
It can be checked at runtime if a given `RooAbsReal` is a pdf or not. Like this, we also don't need a separate override of `createChi2(RooDataSet &)` in RooAbsPdf.
Configuration menu - View commit details
-
Copy full SHA for 1b892b1 - Browse repository at this point
Copy the full SHA 1b892b1View commit details -
[RF] Support
NumCPU()
andRange()
in createChi2() for RooDataSetsThis is achieved in the same was as in `createNLL()`, by forwarding the configuration options to the `RooAbsOptTestStatistic` base class.
Configuration menu - View commit details
-
Copy full SHA for c9bbb99 - Browse repository at this point
Copy the full SHA c9bbb99View commit details -
[RF] Bugfix in
RooDataSet::reduce()
by also copying the stored errorsAfter adding support for subrange fits with the `RooXYChi2Var`, it initially didn't work because the y-value errors were missing in the dataset. This is because `RooDataSet::reduce()` is not copying the errors over to the reduced dataset, which is a bug. Fortunately, there is a straighforward solution. To create the reduced `RooDataSet`, it now doesn't use some buggy private constructor (that is now removed), but instead the trusty `RooAbsData::emptyClone()` method, for which I fixed the problem with the errors not being copied already some time ago.
Configuration menu - View commit details
-
Copy full SHA for 6426d90 - Browse repository at this point
Copy the full SHA 6426d90View commit details -
[pyroot] Add dependency on dataframe for rtensor test.
This should fix some of the failures observed for builds without rdataframe
Configuration menu - View commit details
-
Copy full SHA for acc2849 - Browse repository at this point
Copy the full SHA acc2849View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0b9ee3 - Browse repository at this point
Copy the full SHA d0b9ee3View commit details
Commits on Sep 19, 2023
-
Add TCanvas::IsUpdated() method
It inform that Update() or UpdateAsync() methods were called. Will be used in iPython to implement graphics update functionality
Configuration menu - View commit details
-
Copy full SHA for 9fb6731 - Browse repository at this point
Copy the full SHA 9fb6731View commit details -
[ipython] implement Update of canvas drawing
Keep list of display handles for TCanvas and if Update called - try to update it. Works for jsroot and png display
Configuration menu - View commit details
-
Copy full SHA for 40842c7 - Browse repository at this point
Copy the full SHA 40842c7View commit details -
[rcanvas] add IsUpdated() flag, required for iPython
Fix problem with IsShown() - also should be set in batch mode Provide GetUID() method, which will be used in iPython
Configuration menu - View commit details
-
Copy full SHA for b3ae186 - Browse repository at this point
Copy the full SHA b3ae186View commit details -
[ipython] support RCnavas.Update()
Handle same as for TCanvas. Use RCanvas::GetUID() for canvas identifier.
Configuration menu - View commit details
-
Copy full SHA for 4f7854d - Browse repository at this point
Copy the full SHA 4f7854dView commit details -
[ipython] use TWebCanvas for canvas rendering
This class provides all necessary functionality for web-based display, including handling of stacks, stats, styles, colors and so on Adjust layout of the div element - use 'relative' position to preserve dimension of the JSROOT drawings.
Configuration menu - View commit details
-
Copy full SHA for dfd8a8a - Browse repository at this point
Copy the full SHA dfd8a8aView commit details -
[ipython] fix canvas width/height usage
Use GetWindowWidth()/GetWindowHeight() methods to get configured drawing dimension, do not swap width/height parameters
Configuration menu - View commit details
-
Copy full SHA for 0b8fc4b - Browse repository at this point
Copy the full SHA 0b8fc4bView commit details -
[webgui] use actual canvas size as pdf page size
When producing pdf document, set page size to maximal canvas size. Also include margins into page size to let normally embed complete canvas per page.
Configuration menu - View commit details
-
Copy full SHA for 0e78f9c - Browse repository at this point
Copy the full SHA 0e78f9cView commit details -
Preliminary 7.5.0 release for ROOT 6.30 Improve build legend functionality, provide as context menu command Fix toggling of hist draw options
Configuration menu - View commit details
-
Copy full SHA for 5df0ef8 - Browse repository at this point
Copy the full SHA 5df0ef8View commit details -
[jsroot] 7.5.pre 19/09/2023 with grayscale support
Add support of grayscale flag in the canvas
Configuration menu - View commit details
-
Copy full SHA for 98e9e74 - Browse repository at this point
Copy the full SHA 98e9e74View commit details -
Provide correct TCanvas::Draw and TPad::Draw for web canvas
Instead direct call of Paint() call UpdateAsync() Prevent Paint() when calling TCanvas::SetGrayscale
Configuration menu - View commit details
-
Copy full SHA for 8b7aa49 - Browse repository at this point
Copy the full SHA 8b7aa49View commit details -
[cmake] Replace FindOracle.cmake:
Nicer to distribute a BSD licensed version. The file `COPYING-CMAKE-SCRIPTS` is missing virtually worldwide, not even CMake includes it: https://gitlab.kitware.com/search?search=COPYING-CMAKE-SCRIPTS&nav_source=navbar&project_id=541&group_id=415&search_code=true&repository_ref=master
Configuration menu - View commit details
-
Copy full SHA for 57a5c9a - Browse repository at this point
Copy the full SHA 57a5c9aView commit details
Commits on Sep 20, 2023
-
[PyROOT] Make building with Python 2 optional
In preparation for a future removal of Python 2 support, add the `pyroot-python2` cmake build option (OFF by default). Users who really need Python 2 support can still get it, but warn them that it will be removed in a future ROOT release.
Configuration menu - View commit details
-
Copy full SHA for f7594a3 - Browse repository at this point
Copy the full SHA f7594a3View commit details -
[RF] Implement
Offset("bin")
also for RooDataSet fitsFully implement the `Offset("bin")` feature also for RooDataSet, both with CPU/CUDA BatchMode and the legacy tests statistics. This is done now by introducing a new element in the computation graph: an "offset pdf" that is created as a RooHistPdf from the observed data, and it is used to get the counterterm in each bin. It was validated with the `rf614` tutorial that this binwise offsetting is indeed fixing the convergense problems that the simple offsetting by the initial NLL value can't fix. Closes root-project#11965.
Configuration menu - View commit details
-
Copy full SHA for afd622c - Browse repository at this point
Copy the full SHA afd622cView commit details -
Configuration menu - View commit details
-
Copy full SHA for acd7618 - Browse repository at this point
Copy the full SHA acd7618View commit details -
[RF] Fix logic error in RooAbsPdf where Offset() was ignored in fitTo()
There was a little bug in `fitTo()` when the new modular test statistics got implemented in fe6935b. If the `ModularL` command is not passed, the offsetting flag should be forwarded to `createNLL()`, because only for the new test statistics the offsetting is done in the minimizer only.
Configuration menu - View commit details
-
Copy full SHA for a680f0a - Browse repository at this point
Copy the full SHA a680f0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c4e1af - Browse repository at this point
Copy the full SHA 1c4e1afView commit details -
[RF] Remove
RooFitCommon
library and usegSystem->TempDirectory()
The RooFitCommon library only contained one single function to create a temporary directory `/tmp/roofit/` that was not even platform independed. This commit suggests to use `gSystem->TempDirectory()` instead, and prefix the temporary files with `roofit_` so there is no need for creating another subdirectory.
Configuration menu - View commit details
-
Copy full SHA for 1a7f63f - Browse repository at this point
Copy the full SHA 1a7f63fView commit details -
[RF] Don't preprocess const-term optimization flag in
fitTo()
We can avoid the const-term-optimization in BatchMode or `codegen` simply by overriding the relevant function in the wrapper classes.
Configuration menu - View commit details
-
Copy full SHA for a23595b - Browse repository at this point
Copy the full SHA a23595bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb64189 - Browse repository at this point
Copy the full SHA fb64189View commit details -
[RF] Avoid code duplication in likelihood and chi2 fitting
The function that steered the chi2 minimization had almost the exact same implementation as the one steering the likelihood fits. It would be better is the chi2 fits also use the same function as the likelihood fits, which is implemented in this PR.
Configuration menu - View commit details
-
Copy full SHA for e58055c - Browse repository at this point
Copy the full SHA e58055cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 256dd33 - Browse repository at this point
Copy the full SHA 256dd33View commit details -
[RF] Fix all typos in RooFit source code
This was done with the help of this very useful tool: https://github.com/crate-ci/typos
Configuration menu - View commit details
-
Copy full SHA for e8bdfaf - Browse repository at this point
Copy the full SHA e8bdfafView commit details -
[RF] Add config flag to set minimizer in
stressRooFit/HistFactory
This config parameter was already present for `stressRooStats`, and this commit also adds it for `stressRooFit` and `stressHistFactory`. The default minimizer is hardcoded to `Minuit`, not `Minuit2`. Furthermore, the code is modernized a bit, for example by using raw string literals and `int` instead of `Int_t`.
Configuration menu - View commit details
-
Copy full SHA for cdc6830 - Browse repository at this point
Copy the full SHA cdc6830View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd562e1 - Browse repository at this point
Copy the full SHA bd562e1View commit details -
[RF] Slighlty loosen arbitrary precision parameter in
testHistFactory
This is to make the test also pass when using Minuit2, where the post fit parameters differ by a tiny bit, pushing one of the precision parameters over the edge by 3 percent. To have a bit of a margin, the relevant precision constants are increased by 10 percent.
Configuration menu - View commit details
-
Copy full SHA for eb622bf - Browse repository at this point
Copy the full SHA eb622bfView commit details -
[RF] Always use Minuit1 for contour plot tutorials
The contour implementation in Minuit2 doesn't work for these RooFit tutorials yet.
Configuration menu - View commit details
-
Copy full SHA for 8a1d41f - Browse repository at this point
Copy the full SHA 8a1d41fView commit details -
[RF] Loosen comparision precision in
testHypoTestInvResult
For the estimated error on the upper limit, we need to loosen the tolerance because it is determined on-the-fly with a fit, and not read as a data member like the comment in the test said before. Withg the default minimizer changing from Minuit to Minuit2, the results are slightly different and caused this test to fail.
Configuration menu - View commit details
-
Copy full SHA for 1dcd853 - Browse repository at this point
Copy the full SHA 1dcd853View commit details -
[math] Make Minuit2 the default minimizer in ROOT Math if available
Most people prefer Minuit2 nowadays, especially RooFit users, as some of the more complicated fits don't converge with the old Minuit implementation. In case ROOT was built without Minuit2 enabled, the default falls back to `Minuit`. Also, since there is a "default default" already hardcoded in `MinimizerOptions.cxx`, it is not necessary to specify another "default default" in the default `.rootrc`. The corresponding line is commented out.
Configuration menu - View commit details
-
Copy full SHA for 6866a57 - Browse repository at this point
Copy the full SHA 6866a57View commit details -
[cmake] Option
roofit_multiprocess
requires optionminuit2
The RooFit gradient multiprocessing depends on Minuit2 at compile time. Therefore, building with `roofti_multiprocess=ON` should imply `minuit2=ON`, giving a warning if the user defined `minuit2=OFF`. Then, Minuit2 should only be added as a dependency to RooFitCore if `roofit_multiprocess` is switched on.
Configuration menu - View commit details
-
Copy full SHA for 3acc0e6 - Browse repository at this point
Copy the full SHA 3acc0e6View commit details
Commits on Sep 21, 2023
-
[mathmore] Remove license-incompatible KelvinFunctions.
Part of ROOT-10992
Configuration menu - View commit details
-
Copy full SHA for f54c828 - Browse repository at this point
Copy the full SHA f54c828View commit details -
Do not evaluate dependent immediate invocations
We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375 until instantiation. We should also not consider them referenced from a non-consteval context. Fixes: llvm/llvm-project#55601 ``` template<typename T> class Bar { consteval static T x() { return 5; } public: Bar() : a(x()) {} private: int a; }; Bar<int> g(); ``` Is now accepted by clang. Previously it errored with: `cannot take address of consteval function 'x' outside of an immediate invocation Bar() : a(x()) {}` Differential Revision: https://reviews.llvm.org/D132031 --- Fixes root-project#13698, a problem with the new C++ headers from the new macOS SDK.
Configuration menu - View commit details
-
Copy full SHA for 6627da7 - Browse repository at this point
Copy the full SHA 6627da7View commit details -
[RF] Include
gsl_integration.h
in RooFitMore instead of copy-pastingInclude `gsl_integration.h` in RooFitMore instead of copy-pasting code from gsl. The linking is done in the same was as in `math/mathmore/CMakeLists.txt`. This should add no additional dependency compilcations, because RooFitMore already linked against MathMore, which requires GSL to be present.
Configuration menu - View commit details
-
Copy full SHA for 85a962f - Browse repository at this point
Copy the full SHA 85a962fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6245f4f - Browse repository at this point
Copy the full SHA 6245f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb567b4 - Browse repository at this point
Copy the full SHA fb567b4View commit details -
[jsroot] dev 21/09/2023 with fixes
1. TText/TLatex scaling to pad size 2. Handle TAxis with ndiv = 0 3. TGraph B draw option - proper bar width 4. Correctly use fixed label font size in TLegend, not always autoscale 5. Adjust columns width in TLegend to content 6. Correctly store defs when create image Fixes root-project#13693
Configuration menu - View commit details
-
Copy full SHA for 14338c8 - Browse repository at this point
Copy the full SHA 14338c8View commit details -
[Build] Fix implicit comp. warning on MacOS
when using llvm 15. The warning was "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]"
Configuration menu - View commit details
-
Copy full SHA for e188c8f - Browse repository at this point
Copy the full SHA e188c8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1831ce6 - Browse repository at this point
Copy the full SHA 1831ce6View commit details -
[Build] Remove flags causing warnings on MacOS
when llvm 15 is used: -single_module and -bind_at_load. Once removed, they also do not cause problems to macos 11 and 12.
Configuration menu - View commit details
-
Copy full SHA for 1d5baf0 - Browse repository at this point
Copy the full SHA 1d5baf0View commit details
Commits on Sep 22, 2023
-
[cmake] Turn everything with incompatible licenses off by default:
The default should be a ROOT binary that respects its license; any build that creates GPLed binaries should be an active decision. Affected are uses of fftw3, gsl, Pythia 8, and unuran (all GPL), as well as Pythia 6 which does not seem to have a license.
Configuration menu - View commit details
-
Copy full SHA for ebe6694 - Browse repository at this point
Copy the full SHA ebe6694View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4f8133 - Browse repository at this point
Copy the full SHA f4f8133View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8730c47 - Browse repository at this point
Copy the full SHA 8730c47View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0cc580 - Browse repository at this point
Copy the full SHA a0cc580View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6570c5d - Browse repository at this point
Copy the full SHA 6570c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af5160 - Browse repository at this point
Copy the full SHA 8af5160View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f2b5f - Browse repository at this point
Copy the full SHA 26f2b5fView commit details -
[RF] Introduce new
EvalBackend()
option for createNLL() and fitTo()The new `EvalBackend()` option will replace the `BatchMode()` option, which is kept for backwards compatibility. However, a warning is printed when one passes the `BatchMode()` option. There are also versions of this new option that don't use string arguments, like `EvalBackend::Cuda()`, such that one can ensure at compile-time that a valid backend is used. this is helpful for unit tests, but not necessarily meant for the end user.
Configuration menu - View commit details
-
Copy full SHA for b272e50 - Browse repository at this point
Copy the full SHA b272e50View commit details -
[RF] Clean up
createNLL()
andfitTo()
docs and interfaces* Remove duplicated explanations of likelihood options from `fitTo()`. Instead, just link to `createNLL()`. * Improve documentation with explicit explanations of input and output parametrs. * Rename the `virtual` overloads of `fitTo()` and `createNLL()` that are taking only a RooLinkedList to `fitToImpl()` and `createNLLImpl()`. This avoids confusing doxygen with different overloads, and thus ensures that everytime we are referencing `createNLL()` and `fitTo()` in the docs, it will link to the highest-level user interface: the templated functions that can either take a single RooLinkedList or an arbitrary number of command arguments. * Explicitly write in the docs which functions need to be overridden when you want to customize likelihood creation or fitting behaviour. This will be useful for the few RooFit-based frameworks that actually do such a thing. * Replace `///` with `/**` to denote doxygen comment blocks. This is done because otherwise, doxygen did not detect correctly in some circumstances what is the scope of the comment block.
Configuration menu - View commit details
-
Copy full SHA for 9c6ed73 - Browse repository at this point
Copy the full SHA 9c6ed73View commit details -
[RF] Explain new
EvalBackend()
command argument in documentationAdd explanation on all the possible `EvalBackend()` choices for the likelihood: * legacy * cpu * cuda * codegen * codegen_no_grad
Configuration menu - View commit details
-
Copy full SHA for ece77ec - Browse repository at this point
Copy the full SHA ece77ecView commit details -
[RF] Implement the
EvalBackend("codegen_no_grad")
optionThis is done by adding a new constructor flag to the RooFuncWrapper whether the gradient should be compiled or not.
Configuration menu - View commit details
-
Copy full SHA for dae23db - Browse repository at this point
Copy the full SHA dae23dbView commit details
Commits on Sep 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b9d6ebc - Browse repository at this point
Copy the full SHA b9d6ebcView commit details
Commits on Sep 24, 2023
-
[TMVA] Do not run CNN tutorial if imt not specified
if imt is not specified, this tutorial should not be run as a test.
Configuration menu - View commit details
-
Copy full SHA for 1046dc6 - Browse repository at this point
Copy the full SHA 1046dc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc9d47b - Browse repository at this point
Copy the full SHA dc9d47bView commit details
Commits on Sep 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ceef062 - Browse repository at this point
Copy the full SHA ceef062View commit details -
[hist] Fix license for TGraphSmooth (NFC):
After consultation with Christian Stratowa, the intent was to use the same license as that of ROOT. Given the commit 041f9ed which sets the (c) to Fons+Rene, the copyright for Christian must end around that time that Christian has donated the code to Fons&Rene. Use consistent header for .h and .cxx.
Configuration menu - View commit details
-
Copy full SHA for fd2a14f - Browse repository at this point
Copy the full SHA fd2a14fView commit details -
[win32gdk] Remove unused relocatable; gcompat.h:
They are GPLed (unlike the rest); our build has `#undef ENABLE_RELOCATABLE` in `graf2d/win32gdk/gdk/src/iconv/config.h`. gcompat.h is not included anywhere. So there is just no reason to keep these.
Configuration menu - View commit details
-
Copy full SHA for f4a23f7 - Browse repository at this point
Copy the full SHA f4a23f7View commit details -
[jsroot] 7.5.pre 22/09/2023 with TProfile3D support
1. Support TProfile3D 2. Support scaling of special fill patterns
Configuration menu - View commit details
-
Copy full SHA for b832604 - Browse repository at this point
Copy the full SHA b832604View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297dbde - Browse repository at this point
Copy the full SHA 297dbdeView commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 548422f - Browse repository at this point
Copy the full SHA 548422fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cae93d9 - Browse repository at this point
Copy the full SHA cae93d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd8807 - Browse repository at this point
Copy the full SHA fdd8807View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6905629 - Browse repository at this point
Copy the full SHA 6905629View commit details -
[RF][HS3] Don't automatically set
BinnedLikelihood
on HF model importThe JSON import of HistFactory models was always setting the "BinnedLikelihood" attribute to trigger the binned likelihood optimization in the fit. That's generally a good thing, however it can create backwards compatibility issues. For older HistFactory models that don't use the binned likelihood optimization by default, it comes as a surprise to the user that the definition of the likelihood is suddenly different. This commit suggests to not hardcode the `BinnedLikelihood` attribute in the HistFactory JSON IO, but instead rely on the the regular JSON IO of RooAbsArg attributes to make sure that the attribute is only set in the imported workspace if it was also set in the original workspace. Other changes in this commit: * Some RooAbsArg names in the HS3 HistFactory import are also changed to reflect the old HistFactory implementation * Variables in the code are renamed to avoid one-letter variable names
Configuration menu - View commit details
-
Copy full SHA for 30177a3 - Browse repository at this point
Copy the full SHA 30177a3View commit details -
[RF][HS3][HF] Backwards compatible way of dealing with bin widths
The bin width modifiers are handled separately from the other modifiers in the HistFactory JSON IO. However, do detect them, we can't just check for the RooBinWidthFunction type here, because prior to ROOT 6.26, the multiplication with the inverse bin width was done in a different way (like a normfactor with a RooRealVar, but it was stored in the dataset). Fortunately, the name was similar, so we can match the modifier name.
Configuration menu - View commit details
-
Copy full SHA for d7baa44 - Browse repository at this point
Copy the full SHA d7baa44View commit details
Commits on Sep 27, 2023
-
[pythia8] Fix license of TPythia8Decayer (NFC):
as per request by Peter Hristov, ALICE.
Configuration menu - View commit details
-
Copy full SHA for e251a3a - Browse repository at this point
Copy the full SHA e251a3aView commit details -
[cmake] Make unfold optional so it can be disabled:
It is GPL licensed and ROOT binaries must not have it enabled.
Configuration menu - View commit details
-
Copy full SHA for 3d87d7d - Browse repository at this point
Copy the full SHA 3d87d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14d9b02 - Browse repository at this point
Copy the full SHA 14d9b02View commit details -
1. Fix AXIS draw option - do not draw hist title 2. Fix scaling of custom labels - factor 0.6666 as in TGaxis:1504
Configuration menu - View commit details
-
Copy full SHA for ce56b72 - Browse repository at this point
Copy the full SHA ce56b72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb4d23 - Browse repository at this point
Copy the full SHA 8eb4d23View commit details -
[webcanvas] fix first connection index
Only first client allowed to change some values in the canvas. But now first connection has index 1 - while index 0 is for batch.
Configuration menu - View commit details
-
Copy full SHA for d25bf79 - Browse repository at this point
Copy the full SHA d25bf79View commit details -
[webcanvas] highlight active pad only optionally, off by default
Can be changed in the options menu Make looking similar as with native ROOT
Configuration menu - View commit details
-
Copy full SHA for 5af4b57 - Browse repository at this point
Copy the full SHA 5af4b57View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d820e - Browse repository at this point
Copy the full SHA d5d820eView commit details -
[canvas] protect TPad::DrawFrame if gPad == nullptr
If by chance gPad is nullptr, method will crash
Configuration menu - View commit details
-
Copy full SHA for 0d355cf - Browse repository at this point
Copy the full SHA 0d355cfView commit details -
[webcanvas] use only first frame in the pad
Any others (or duplication) will be excluded from the web drawings
Configuration menu - View commit details
-
Copy full SHA for cbb4cfe - Browse repository at this point
Copy the full SHA cbb4cfeView commit details -
[jsroot] 7.5.pre 27/09/2023 with axis/palette fixes
1. Allow negative labels offsets on axis 2. Provide extra gaps for labels as it done in ROOT 3. Copy Z axis attributes to palette before drawing 4. Shrink axis labels 5. Small fix in col drawing
Configuration menu - View commit details
-
Copy full SHA for aa3bff2 - Browse repository at this point
Copy the full SHA aa3bff2View commit details -
[math] Early return of minimum state when using simplex with no params
This avoids the problems when running simplex with zero parameters reported in root-project#6775.
Configuration menu - View commit details
-
Copy full SHA for 6e556ce - Browse repository at this point
Copy the full SHA 6e556ceView commit details
Commits on Sep 28, 2023
-
[jsroot] 7.5.pre 28/09/2023 with TPaletteAxis fixes
1. Properly redirect context menu commands to histogram Z axis 2. When moving palette - send updates back to the server 3. Improve HierarchyPainter Draw/Expand/Unexpand context menu commands
Configuration menu - View commit details
-
Copy full SHA for ef2ff08 - Browse repository at this point
Copy the full SHA ef2ff08View commit details -
Append to the
xml_veto
list instead of (re-)creating itPrevent running xml tests when xml is disabled, suppressing the following test failures: ``` TEST FAILURES: 971:tutorial-xml-DOMParsePerson 972:tutorial-xml-DOMRecursive 973:tutorial-xml-SAXHandler ```
Configuration menu - View commit details
-
Copy full SHA for 41a40b3 - Browse repository at this point
Copy the full SHA 41a40b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a345367 - Browse repository at this point
Copy the full SHA a345367View commit details -
[RF] Update to latest xRooFit (root-project#13717)
* update xRooFit to latest version * declare ROOT::Experimental::XRooFit namespace for ROOT's copy of xRooFit * fix namespace alias * address PR comments * [RF] Improvements to `xroofit` documentation structure * Add a new `xroofit` group to the RooFit documentation * Add semicolons behind the `NAMESPACE` macros. They have no effect on the C++ compilier, but macros without trailing semicolons confuse doxygen * Add the `xRooNode` and `xRooNLLVar` classes to the `xroofit` documentation group. Other xroofit classes might also go there, but I don't know which ones should really be public. So I only added these two to give and example. * Move RooBrowser documentation to xRooBrowser. Now that xRooFit is considered part as the experimental user interface, this is fine to do. Like this, doxygen can associate the actual xRooBrowser implementation with the docs. * Rename `RooFit::Detail::XRooFit` namespace to `ROOT::Experimental::XRooFit` instad of using namespace alias. Again, this is done to not confuse doxygen. To build the documentation quickly, edit the `documentation/doxygen/makeinput.sh` directory and comment out all subdirectories except for `roofit`. Call `make` in the doxygen directory. Type `y` if it should ask you to overwrite some files in the end. The xRooFit documentation will end up in the `~/rootdoc/html/group__xroofit.html` directory. * address some typos
Configuration menu - View commit details
-
Copy full SHA for 090ccec - Browse repository at this point
Copy the full SHA 090ccecView commit details -
[webgui] Allows direct callbacks processing in python
When python non-interactive session runs, there is no any possibility to call callbacks in main thread. Therefore let allow process callbacks directly from the place where data queue is filled.
Configuration menu - View commit details
-
Copy full SHA for 91177c3 - Browse repository at this point
Copy the full SHA 91177c3View commit details -
[pyroot] set external events processing only in non interactive mode
In interactive python mode processing events always runs from main thread and performed regularly - no special settings are required then
Configuration menu - View commit details
-
Copy full SHA for 2fbeb5f - Browse repository at this point
Copy the full SHA 2fbeb5fView commit details -
[pyroot] make Mac and Linux events handling similar
In non-interactive mode one have to run events from special thread, in interactive it should be enough to use input hook
Configuration menu - View commit details
-
Copy full SHA for 06b86c3 - Browse repository at this point
Copy the full SHA 06b86c3View commit details -
[http] show warning about changing main thread only when gDebug > 0
It is intended behavior that processing thread may change in python. Therefore display such message only if debug is enabled
Configuration menu - View commit details
-
Copy full SHA for 5898c8f - Browse repository at this point
Copy the full SHA 5898c8fView commit details -
[CMake] Use
find_package(XRootD)
and notXROOTD
(case sensitivity)With this change, the reproducer provided in root-project#12631 works for me, while it indeed fails to find `xrootd` in the configuration step without this commit. Closes root-project#12631.
Configuration menu - View commit details
-
Copy full SHA for 733d246 - Browse repository at this point
Copy the full SHA 733d246View commit details
Commits on Sep 29, 2023
-
[geom] Don't use
-fabi-version=6
when compiling geom/vecgeom with G……CC (root-project#13751) The `-fabi-version=6` flag was added to the compilation of `geom/vecgeom` in ded69d0 without any explanation. But recently, it caused some compilation problems with `std::unique-ptr` in newer GCC versions. Simple reproducer: ```c++ #include <memory> int main() { std::unique_ptr<int>(nullptr); } ``` Compile with `g++ -fabi-version=6 -o test test.cpp`, using GCC 13.2. So the implementation of `std::unique_ptr` in the standard library version that comes with gcc 13.2.1 is incompatible with that (super old) gcc abi version. Since it's not clear why this flag is there to begin with, I suggest to remove it so it doesn't cause further problems. The ABI version 6 is very old anyway (it came with GCC 4.7 in 2012). Closes root-project#12315.
Configuration menu - View commit details
-
Copy full SHA for a86bf73 - Browse repository at this point
Copy the full SHA a86bf73View commit details -
Switched to using the VDT::VDT imported target to set up the build of ROOTVecOps, RooBatchCompute and TMVA. Then made all the necessary changes in SearchInstalledSoftware.cmake to make that work.
Configuration menu - View commit details
-
Copy full SHA for 5473c5c - Browse repository at this point
Copy the full SHA 5473c5cView commit details -
Made the test build against the build directory set CMAKE_PREFIX_PATH…
… correctly. So that headers/libraries in the build directory could be found correctly.
Configuration menu - View commit details
-
Copy full SHA for 62dcea6 - Browse repository at this point
Copy the full SHA 62dcea6View commit details -
Revert "[pyroot] make Mac and Linux events handling similar"
This revert is in place because python scripts now hang whenever the ROOT module is imported on macos 12, 13 and 14. This reverts commit 06b86c3.
Configuration menu - View commit details
-
Copy full SHA for 4a58864 - Browse repository at this point
Copy the full SHA 4a58864View commit details -
Revert "[CMake] Use
find_package(XRootD)
and notXROOTD
(case sen……sitivity)" This reverts commit 733d246.
Configuration menu - View commit details
-
Copy full SHA for 2a9b7df - Browse repository at this point
Copy the full SHA 2a9b7dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27e3ee1 - Browse repository at this point
Copy the full SHA 27e3ee1View commit details -
[core] Add rpath on MacOS in compiledata.sh
The generated compiler invocation in TSystem::CompileMacro doesn't add the `-rpath` option. The output of `root-config --libs` contains that option on MacOS, so we should also have it here. Extend the flags passed to the compiler defined in `compiledata.sh` so it gets generated at configuration time. This should fix errors seen in MacOS 14 when loading a shared library obtained via ACLiC. Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Configuration menu - View commit details
-
Copy full SHA for 26bb17c - Browse repository at this point
Copy the full SHA 26bb17cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4838068 - Browse repository at this point
Copy the full SHA 4838068View commit details -
[graf2d] Remove asimagexml, pixmap from AfterImage: incompat license
They were used by load_xml2ASImage to load xml to asimage. Almost not used.
Configuration menu - View commit details
-
Copy full SHA for 8c2b448 - Browse repository at this point
Copy the full SHA 8c2b448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76f7346 - Browse repository at this point
Copy the full SHA 76f7346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95487cd - Browse repository at this point
Copy the full SHA 95487cdView commit details -
[webcanv] reduce debug output when exec many lines
Happens when moving complete TGraph.
Configuration menu - View commit details
-
Copy full SHA for 0c4a255 - Browse repository at this point
Copy the full SHA 0c4a255View commit details -
[webcanv] correctly mark pad as having special objects
Also when special objects appears in graph or hist list of primitives
Configuration menu - View commit details
-
Copy full SHA for da798de - Browse repository at this point
Copy the full SHA da798deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 759b659 - Browse repository at this point
Copy the full SHA 759b659View commit details -
[CMake] Remove N-1 identical link statements
of the libxxhash.a library when building libCore.so
Configuration menu - View commit details
-
Copy full SHA for c5b00f0 - Browse repository at this point
Copy the full SHA c5b00f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c633080 - Browse repository at this point
Copy the full SHA c633080View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6b118c - Browse repository at this point
Copy the full SHA c6b118cView commit details
Commits on Sep 30, 2023
-
[Testing] Significantly reduce duration of legacy tutorials
ran every time by the CI and testing TThread, without reducing coverage.
Configuration menu - View commit details
-
Copy full SHA for eedc1da - Browse repository at this point
Copy the full SHA eedc1daView commit details -
[tmva] Remove direct dataframe dependency
libTMVA does not need to depend explicitly on RDataFrame. It is used only in the template function AsTensor and in the header files of the BatchGenerator used from Python remove lib dependency
Configuration menu - View commit details
-
Copy full SHA for 40cfc5b - Browse repository at this point
Copy the full SHA 40cfc5bView commit details -
[tmva] Veto tutorial/keras on macos
Do not run in CI the tutorial/keras on macos because we cannot disable eager execution on tensorflow. This causes timeout in the tutorials
Configuration menu - View commit details
-
Copy full SHA for 1e39844 - Browse repository at this point
Copy the full SHA 1e39844View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76e4705 - Browse repository at this point
Copy the full SHA 76e4705View commit details -
Add unittest for TDirectoryFile destructor
With the reproducer described in root-project#13691. The test *must* link to some library that is not automatically ignored when loading PCMs in TCling::RegisterModule in order to trigger the segfault.
Configuration menu - View commit details
-
Copy full SHA for 3a9d2ca - Browse repository at this point
Copy the full SHA 3a9d2caView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf6278 - Browse repository at this point
Copy the full SHA aaf6278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b3b5a3 - Browse repository at this point
Copy the full SHA 6b3b5a3View commit details -
[TMVA] Remove Keras Regression test from the battery
on Macos because it always fails due to the slowness of the tool on the platform.
Configuration menu - View commit details
-
Copy full SHA for bfb6ff0 - Browse repository at this point
Copy the full SHA bfb6ff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0a848 - Browse repository at this point
Copy the full SHA 1a0a848View commit details
Commits on Oct 1, 2023
-
[cmake] Only add a move_header_XYZ target if there are headers:
ninja rightfully said: ``` ninja explain: output core/newdelete/move_header_core_newdelete of phony edge with no inputs doesn't exist ninja explain: core/newdelete/move_header_core_newdelete is dirty ninja explain: move_headers is dirty ``` which likely triggered MSBUILD to re-run the move-headers target (during roottest). This might fix it, and in general gets rid of useless "rebuilds" of move_headers.
Configuration menu - View commit details
-
Copy full SHA for 2aa4742 - Browse repository at this point
Copy the full SHA 2aa4742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b2e909 - Browse repository at this point
Copy the full SHA 7b2e909View commit details -
[base] TROOT: rely on etc/gitinfo.txt rather than RGitCommit.h:
This prevents TROOT.cxx from being rebuilt everytime the commit changes. Instead, use gitinfo.txt
Configuration menu - View commit details
-
Copy full SHA for 5be58e5 - Browse repository at this point
Copy the full SHA 5be58e5View commit details -
[config,proofd] Rely on
etc/gitinfo.txt
to determine version info:This isn't needed at compiletime; using the text file prevents rebuilding / having to maintain `RGitCommit.h`.
Configuration menu - View commit details
-
Copy full SHA for da1a28a - Browse repository at this point
Copy the full SHA da1a28aView commit details -
[cmake,foundation] Do not generate
RGitCommit.h
butetc/gitinfo.txt
:Deprecate the use of `RGitCommit.h`: it triggers rebuilds where the git info is in fact not needed at compiletime; all uses are replaced by parsing `gitinfo.txt`. Instead, create `etc/gitinfo.txt` even if the source directory is not a git repo. This only works for releases (even `ROOT_PATCH_VERSION`), where the tag and the branch can be determined from the version numbers.
Configuration menu - View commit details
-
Copy full SHA for 52ac8a0 - Browse repository at this point
Copy the full SHA 52ac8a0View commit details -
[build] Do not include
etc/gitinfo.txt
in source tarball:It can be generated at buildtime.
Configuration menu - View commit details
-
Copy full SHA for fe92f17 - Browse repository at this point
Copy the full SHA fe92f17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d856d2 - Browse repository at this point
Copy the full SHA 2d856d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1a88a5 - Browse repository at this point
Copy the full SHA f1a88a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3739d59 - Browse repository at this point
Copy the full SHA 3739d59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 744dcde - Browse repository at this point
Copy the full SHA 744dcdeView commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 035f893 - Browse repository at this point
Copy the full SHA 035f893View commit details -
[math] Support TComplex arithmetic operations with any possible type
Generalize the arithmetic operator overloads of TComplex to general arithmetic types with templates. I'm using some `enable_if` for arithmetic types only, so we can be sure that nothing unexpected will happen for non-arithmetic types that implement arithmetic operators with `double` themselves. Closes root-project#13730.
Configuration menu - View commit details
-
Copy full SHA for fa46203 - Browse repository at this point
Copy the full SHA fa46203View commit details -
[hist] Comment out unused variables in
THbookFile.cxx
This will fix some warnings seen in the nightlies: https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/job/root-asan/lastBuild/LABEL=ROOT-centos8,SPEC=asan,V=master/parsed_console/
Configuration menu - View commit details
-
Copy full SHA for 3c1c78a - Browse repository at this point
Copy the full SHA 3c1c78aView commit details
Commits on Oct 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d2f549b - Browse repository at this point
Copy the full SHA d2f549bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06a9a55 - Browse repository at this point
Copy the full SHA 06a9a55View commit details -
Fix potential crash of the rreader test on Windows (root-project#13782)
* Fix potential crash of the rreader test on Windows Delete the `TFile` pointers, preventing a potential crash in `TROOT::CloseFiles()` when trying to call the `Close()` method on `TWebSocket`/`TWebFile` via the interpreter `CallFunc_Exec` on Windows (visble with LLVM 16) * Use `std::unique_ptr` instead of deleting the pointers (thanks Jonas)
Configuration menu - View commit details
-
Copy full SHA for 6ee27eb - Browse repository at this point
Copy the full SHA 6ee27ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b4557 - Browse repository at this point
Copy the full SHA 94b4557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ac8f0a - Browse repository at this point
Copy the full SHA 6ac8f0aView commit details -
Add the
TWebFile::Close(Option_t *option)
methodThis is needed to properly close and delete the socket when closing the file in `TROOT::CloseFiles()`, preventing a potential issue when trying to close the socket afterwards
Configuration menu - View commit details
-
Copy full SHA for 3e9c971 - Browse repository at this point
Copy the full SHA 3e9c971View commit details -
[cling] Emit const variables only once (root-project#13614)
Otherwise they are emitted as internal and we get double-construction and -destruction on the same memory address due to the way we promote internal declarations in KeepLocalGVPass. According to upstream tests, the de-duplication doesn't work on Windows (yet), but I think this problem is severe enough to fix it on the other platforms sooner rather than later. Fixes root-project#13429
Configuration menu - View commit details
-
Copy full SHA for 2dc5786 - Browse repository at this point
Copy the full SHA 2dc5786View commit details -
[metacling] Lock TCling::CheckClassTemplate
Public interface creating an interpreter transaction, needs locking.
Configuration menu - View commit details
-
Copy full SHA for 0fd78c1 - Browse repository at this point
Copy the full SHA 0fd78c1View commit details -
[df] Clarify usage of OnPartialResult callbacks
* Change name of the RLoopManager data member that stores callbacks registered via RResultPtr::OnPartialResult. * Be more specific in the docs.
Configuration menu - View commit details
-
Copy full SHA for e76de54 - Browse repository at this point
Copy the full SHA e76de54View commit details -
[df] Avoid clearing sample callbacks after event loop
Sample callbacks can be registered by an RAction or an RDefinePerSample instance. In both cases, the lifetime of the callback is tied to the lifetime of the object itself. Avoid eager clearing of the callbacks so to not interfer with the normal functioning.
Configuration menu - View commit details
-
Copy full SHA for eb911c6 - Browse repository at this point
Copy the full SHA eb911c6View commit details -
[df] Add test for cloning actions with DefinePerSample
This is a reproducer test for some sporadic CI failures, e.g. ```python ========================================================================== FAILURES =========================================================================== _______________________________________________________ TestDefinePerSample.test_definepersample_simple _______________________________________________________ self = <check_definepersample.TestDefinePerSample object at 0x13e0c6190>, connection = <Client: 'tcp://127.0.0.1:55253' processes=2 threads=2, memory=4.00 GiB> def test_definepersample_simple(self, connection): """ Test DefinePerSample operation on three samples using a predefined string of operations. """ df = Dask.RDataFrame(self.maintreename, self.filenames, daskclient=connection) # Associate a number to each sample definepersample_code = """ if(rdfsampleinfo_.Contains(\"{}\")) return 1; else if (rdfsampleinfo_.Contains(\"{}\")) return 2; else if (rdfsampleinfo_.Contains(\"{}\")) return 3; else return 0; """.format(*self.samples) df1 = df.DefinePerSample("sampleid", definepersample_code) # Filter by the sample number. Each filtered dataframe should contain # 10 entries, equal to the number of entries per sample samplescounts = [df1.Filter("sampleid == {}".format(id)).Count() for id in [1, 2, 3]] for count in samplescounts: > assert count.GetValue() == 10 E AssertionError check_definepersample.py:62: AssertionError -------------------------------------------------------------------- Captured stderr setup -------------------------------------------------------------------- RDataFrame::Run: event loop was interrupted 2023-09-08 14:51:57,002 - distributed.worker - WARNING - Compute Failed Key: dask_mapper-a92ac090-9407-4849-921a-d187ceffd3ed Function: dask_mapper args: (EmptySourceRange(exec_id=ExecutionIdentifier(rdf_uuid=UUID('5d67c0a7-58f4-488d-8e44-bb5aa0fac480'), graph_uuid=UUID('69353465-0a90-4eef-b101-a1eb93f0c13a')), id=0, start=0, end=50)) kwargs: {} Exception: "RuntimeError('C++ exception thrown:\\n\\truntime_error: Graph was applied to a mix of scalar values and collections. This is not supported.')" ``` Which is due to Dask assigning two tasks to the same worker for the test with the DefinePeSample calls. The Count operation would fail to report the correct amount of entries due to the fact that the DefinePerSample callback was previously deleted at the end of every event loop, specifically at the end of the first task's event loop. Consequently, when the second task starts and it picks up the same RDataFrame to clone the action, the DefinePerSample would never be actually called.
Configuration menu - View commit details
-
Copy full SHA for d56150a - Browse repository at this point
Copy the full SHA d56150aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eed7ec - Browse repository at this point
Copy the full SHA 7eed7ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07872d9 - Browse repository at this point
Copy the full SHA 07872d9View commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0983b37 - Browse repository at this point
Copy the full SHA 0983b37View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8941e7 - Browse repository at this point
Copy the full SHA e8941e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7729241 - Browse repository at this point
Copy the full SHA 7729241View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2682b62 - Browse repository at this point
Copy the full SHA 2682b62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 167a2c6 - Browse repository at this point
Copy the full SHA 167a2c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d087ea8 - Browse repository at this point
Copy the full SHA d087ea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb06264 - Browse repository at this point
Copy the full SHA eb06264View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26e810b - Browse repository at this point
Copy the full SHA 26e810bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4547571 - Browse repository at this point
Copy the full SHA 4547571View commit details -
[cling] Adapt arguments for updated APIs
Forwarding data (differently) or passing trivial parameters.
Configuration menu - View commit details
-
Copy full SHA for d57c7c3 - Browse repository at this point
Copy the full SHA d57c7c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 550fbff - Browse repository at this point
Copy the full SHA 550fbffView commit details -
Configuration menu - View commit details
-
Copy full SHA for e771adb - Browse repository at this point
Copy the full SHA e771adbView commit details -
[cling] SubstDefaultTemplateArgumentIfAvailable
... takes an additional vector for canonical arguments.
Configuration menu - View commit details
-
Copy full SHA for ae0be65 - Browse repository at this point
Copy the full SHA ae0be65View commit details -
[cling] MultiLevelTemplateArgumentList
... takes a Decl and a boolean argument Final.
Configuration menu - View commit details
-
Copy full SHA for 5219855 - Browse repository at this point
Copy the full SHA 5219855View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae42517 - Browse repository at this point
Copy the full SHA ae42517View commit details -
[cling] Adapt and heavily simplify ClingJITLinkMemoryManager
Now we can just inherit from InProcessMemoryManager and override the deallocate() method.
Configuration menu - View commit details
-
Copy full SHA for 51e0c61 - Browse repository at this point
Copy the full SHA 51e0c61View commit details -
[cling] Lexer does not expose getLangOpts() anymore
Store a reference ourselves. Also Lexer::isIdentifierBodyChar() was renamed to Lexer::isAsciiIdentifierContinueChar().
Configuration menu - View commit details
-
Copy full SHA for cf48788 - Browse repository at this point
Copy the full SHA cf48788View commit details -
Configuration menu - View commit details
-
Copy full SHA for 974ec61 - Browse repository at this point
Copy the full SHA 974ec61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1641e9f - Browse repository at this point
Copy the full SHA 1641e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffed3db - Browse repository at this point
Copy the full SHA ffed3dbView commit details -
[cling] Remove PMBuilder members
These two fields don't exist anymore in LLVM 16.
Configuration menu - View commit details
-
Copy full SHA for 68615b5 - Browse repository at this point
Copy the full SHA 68615b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01234a2 - Browse repository at this point
Copy the full SHA 01234a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e12c7 - Browse repository at this point
Copy the full SHA a4e12c7View commit details -
[cling] Don't print name of EnumDecl if there is none
The function overload without PrintingPolicy is not available in LLVM 16, see https://reviews.llvm.org/D134813.
Configuration menu - View commit details
-
Copy full SHA for 968ae84 - Browse repository at this point
Copy the full SHA 968ae84View commit details -
[cling] Adapt to updated forgetDecl signature
The GlobalDecl parameter wasn't used since quite some time.
Configuration menu - View commit details
-
Copy full SHA for 351cd26 - Browse repository at this point
Copy the full SHA 351cd26View commit details -
[cling] Remove extension of legacy pass manager
adjustPassManager was only used for a few backends, such as AMDGPU and NVPTX, but not on the CPU architectures we care about. The DiscriminatorsPass was also removed upstream Clang, see commit llvm/llvm-project@2978d02681.
Configuration menu - View commit details
-
Copy full SHA for 78b7dcf - Browse repository at this point
Copy the full SHA 78b7dcfView commit details -
[cling] Update handling of ElaboratedType in GetFullyQualifiedType
In LLVM 16, we now get ElaboratedType far more often, but they don't have all namespace qualifiers we need. This fixes the build of the RooFitCore module, but many other places are likely affected as well.
Configuration menu - View commit details
-
Copy full SHA for ccc0332 - Browse repository at this point
Copy the full SHA ccc0332View commit details -
[cling] Update registration of atexit handlers
GenericLLVMIRPlatformSupport now declares atexit, which leads to a duplicate symbol error during startup and fails the transaction. Completely switch to the provided infrastructure and just override the helpers to register the functions with our Interpreter.
Configuration menu - View commit details
-
Copy full SHA for 3aafd3f - Browse repository at this point
Copy the full SHA 3aafd3fView commit details -
[cling] Handle UsingType in GetPartiallyDesugaredType
According to llvm/llvm-project@af27466c50, it is used to represent types pulled in with a using declaration, for example `using std::error_code; error_code x;`. This fixes the build of the ROOTTMVASofie module on macOS where this was causing `std::size_t` not be fully desugared to `unsigned long` at first to later end up with two identical classes in a list that must not have duplicates.
Configuration menu - View commit details
-
Copy full SHA for 2ecf3f2 - Browse repository at this point
Copy the full SHA 2ecf3f2View commit details -
[cling] Handle ElaboratedType in ReSubstTemplateArg
In LLVM 16, we get ElaboratedType's in TemplateArgument's and need to recurse into them. This fixes the handling of Double32_t in the test roottest-root-io-double32-make.
Configuration menu - View commit details
-
Copy full SHA for bc5fb71 - Browse repository at this point
Copy the full SHA bc5fb71View commit details -
[win64] Disable Cling optimizations
With the upgrade to LLVM 16, we again have test failures due to crashes and output ordering compared to the reference files. This reverts commit 47277df.
Configuration menu - View commit details
-
Copy full SHA for 77f54af - Browse repository at this point
Copy the full SHA 77f54afView commit details -
[TCling] Prepend drive letter to absolute path
This seems to be required with LLVM 16 on Windows and fixes roottest/root/meta/callfunc/assertUnload.C
Configuration menu - View commit details
-
Copy full SHA for 7d2314d - Browse repository at this point
Copy the full SHA 7d2314dView commit details -
[cling] Avoid unloading Decls not found in DeclContext
This fixes roottest/root/meta/tuple/exec_configtype_unload.C on Windows. Co-authored-by: Bertrand Bellenot <Bertrand.Bellenot@cern.ch>
Configuration menu - View commit details
-
Copy full SHA for 8ed973e - Browse repository at this point
Copy the full SHA 8ed973eView commit details -
[cling] Fix preprocessor option parsing
Exclude options::DXCOption to avoid confusing the parser with the second -E option.
Configuration menu - View commit details
-
Copy full SHA for f315199 - Browse repository at this point
Copy the full SHA f315199View commit details -
[cling] Expect normalized alias option offload_device_only
See also commit de84bfc during the previous LLVM upgrade...
Configuration menu - View commit details
-
Copy full SHA for 9a8f5f0 - Browse repository at this point
Copy the full SHA 9a8f5f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93be030 - Browse repository at this point
Copy the full SHA 93be030View commit details -
Update expected template names in TClingMethodInfoTests.cxx
LLVM now fully qualifies template template parameters when printing, since commit llvm/llvm-project@5fb3f43778 As pointed out in that message, this makes it consistent with type parameters, so add an additional test (Yd1) that would have already passed with LLVM 13.
Configuration menu - View commit details
-
Copy full SHA for bfc2ab7 - Browse repository at this point
Copy the full SHA bfc2ab7View commit details -
[cling] Remove elaborated keyword from output checks
LLVM 16 honors how the declarations were written, without the class or struct keywords.
Configuration menu - View commit details
-
Copy full SHA for f30e958 - Browse repository at this point
Copy the full SHA f30e958View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9844bd8 - Browse repository at this point
Copy the full SHA 9844bd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ac259a - Browse repository at this point
Copy the full SHA 6ac259aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d2c584 - Browse repository at this point
Copy the full SHA 1d2c584View commit details