[geom] Extended TGeoVGShape with extra solids #12315
Conversation
|
Starting build on |
agheata
force-pushed
the
vgconverter_addons
branch
from
2b3e188
to
0264f26
Compare
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
@agheata What do we need to do to solve: |
|
Build failed on mac11/cxx14. Failing tests: |
This is the intended behavior for this macro, i.e. it cannot work as intended if the VecGeom converter cannot be instantiated. However, I can make it issue a warning instead, and do raytracing using the unconverted shape. |
|
@pcanal actually my idea to transform the error into a warning does not work: without VecGeom support, the plugin mechanism already issues errors if I do: The return value looks wrong by the way, I would expect -1 in this case. Is there a way to check if a module was compiled without issuing errors? |
agheata
force-pushed
the
vgconverter_addons
branch
from
0264f26
to
4b8ce6a
Compare
|
Starting build on |
Added support for tesselated, ellipsoid, hyperboloid and cut tube. Added the macro tutorials/geom/tessellatedNav.C importing and raytracing a tessellated solid.
agheata
force-pushed
the
vgconverter_addons
branch
from
4b8ce6a
to
8e79588
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
|
@phsft-bot build just on windows10/cxx14 |
|
Starting build on |
|
@phsft-bot build just on ROOT-performance-centos8-multicore/cxx17 |
|
Starting build on |
Are you trying to test the failure mode or should we just not run the test if the build does not support it? |
The test should not run in inappropriate builds, @Axel-Naumann told me how to veto out the test if vecgeom is not enabled, and it seems to work, so we can merge this |
The `-fabi-version=6` flag was added to the compilation of `geom/vecgeom` in ded69d0 without any explanation. But recently, it caused some compilation problems with `std::unique-ptr` in newer GCC versions. Since it's not clear why this flag is there to begin with, I suggest to remove it so it doesn't cause further problems. Closes root-project#12315.
The `-fabi-version=6` flag was added to the compilation of `geom/vecgeom` in ded69d0 without any explanation. But recently, it caused some compilation problems with `std::unique-ptr` in newer GCC versions. Simple reproducer: ```c++ #include <memory> int main() { std::unique_ptr<int>(nullptr); } ``` Compile with `g++ -fabi-version=6 -o test test.cpp`, using GCC 13.2. So the implementation of `std::unique_ptr` in the standard library version that comes with gcc 13.2.1 is incompatible with that (super old) gcc abi version. Since it's not clear why this flag is there to begin with, I suggest to remove it so it doesn't cause further problems. The ABI version 6 is very old anyway (it came with GCC 4.7 in 2012). Closes root-project#12315.
…CC (#13751) The `-fabi-version=6` flag was added to the compilation of `geom/vecgeom` in ded69d0 without any explanation. But recently, it caused some compilation problems with `std::unique-ptr` in newer GCC versions. Simple reproducer: ```c++ #include <memory> int main() { std::unique_ptr<int>(nullptr); } ``` Compile with `g++ -fabi-version=6 -o test test.cpp`, using GCC 13.2. So the implementation of `std::unique_ptr` in the standard library version that comes with gcc 13.2.1 is incompatible with that (super old) gcc abi version. Since it's not clear why this flag is there to begin with, I suggest to remove it so it doesn't cause further problems. The ABI version 6 is very old anyway (it came with GCC 4.7 in 2012). Closes #12315.
…CC (root-project#13751) The `-fabi-version=6` flag was added to the compilation of `geom/vecgeom` in ded69d0 without any explanation. But recently, it caused some compilation problems with `std::unique-ptr` in newer GCC versions. Simple reproducer: ```c++ #include <memory> int main() { std::unique_ptr<int>(nullptr); } ``` Compile with `g++ -fabi-version=6 -o test test.cpp`, using GCC 13.2. So the implementation of `std::unique_ptr` in the standard library version that comes with gcc 13.2.1 is incompatible with that (super old) gcc abi version. Since it's not clear why this flag is there to begin with, I suggest to remove it so it doesn't cause further problems. The ABI version 6 is very old anyway (it came with GCC 4.7 in 2012). Closes root-project#12315.
Added support for tesselated, ellipsoid, hyperboloid and cut tube in the ROOT to VecGeom converter. Added the macro tutorials/geom/tessellatedNav.C importing and raytracing a tessellated solid.
This Pull request:
Completes solid conversion to VecGeom support
Changes or fixes:
Adding the macro tutorials/geom/tessellatedNav.C
Checklist:
This PR fixes #11271