Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TAxis::GetTimeOffset #13595

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Implement TAxis::GetTimeOffset #13595

merged 1 commit into from
Sep 11, 2023

Conversation

couet
Copy link
Member

@couet couet commented Sep 4, 2023

This PR implements TAxis::GetTimeOffset ss proposed here:
https://root-forum.cern.ch/t/no-taxis-gettimeoffset-method/55990

@couet couet requested a review from lmoneta as a code owner September 4, 2023 13:39
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Test Results

       10 files         10 suites   2d 2h 20m 2s ⏱️
  2 483 tests      543 ✔️   0 💤 1 940 ❌
23 771 runs  21 758 ✔️ 41 💤 1 972 ❌

For more details on these failures, see this check.

Results for commit dbfe30d.

@couet couet self-assigned this Sep 5, 2023
lmoneta
lmoneta approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@couet couet merged commit 3b83c3d into root-project:master Sep 11, 2023
7 of 14 checks passed
@couet couet deleted the gettimeoffset branch September 11, 2023 11:53
maksgraczyk pushed a commit to maksgraczyk/root that referenced this pull request Jan 12, 2024
@couet @maksgraczyk
Implement TAxis::GetTimeOffset (root-project#13595)
a7dcfb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta lmoneta approved these changes

Assignees

@couet couet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@couet @phsft-bot @lmoneta