Llvm16 #185

smuzaffar · 2023-08-04T07:35:49Z

No description provided.

smuzaffar · 2023-08-04T07:36:09Z

test parameters:

full_cmssw = true
pull_request = https://github.com/boostorg/numeric_conversion/commit/50a1eae942effb0… cms-externals/boost#5

cmsbuild · 2023-08-04T07:36:09Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/f215692b3d.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2023-08-04T07:36:54Z

please test for el8_ppc64le_gcc11

smuzaffar · 2023-08-04T08:47:14Z

please test for CMSSW_13_3_ROOT6_X

cmsbuild · 2023-08-04T10:14:43Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad3257/34071/summary.html
COMMIT: 2f4eb60
CMSSW: CMSSW_13_3_ROOT6_X_2023-08-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/185/34071/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
* The action "build-external+py3-hepdata-lib+0.12.0-129d5c7ef90edc5e88634b8e829c0e16" was not completed successfully because Failed to build py3-hepdata-lib. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.12.0-129d5c7ef90edc5e88634b8e829c0e16/log. Final lines of the log file:
full command: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/python3/3.9.14-f1bd82445f2982609f838e795adb062f/bin/python3 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/py3-pip/23.1.1-6ca7254dbe849f7b2c3aa4328a6e6ff7/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py prepare_metadata_for_build_wheel /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.12.0-129d5c7ef90edc5e88634b8e829c0e16/cmsdist-tmp/tmpynara45i
cwd: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.12.0-129d5c7ef90edc5e88634b8e829c0e16/cmsdist-tmp/pip-req-build-axb0itd8
Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

 Encountered error while generating package metadata.
> See above for output.

note: This is an issue with the package mentioned above, not pip.

smuzaffar · 2023-08-04T10:35:56Z

please test for CMSSW_13_3_ROOT6_X

smuzaffar · 2023-08-04T10:38:44Z

@vgvassilev , one of the externals hepdata failed to build with root llvm16 [a]. I have retsarted the tests to dropped hepdata to see what else fails

[a]

  Preparing metadata (pyproject.toml): started
  Running command Preparing metadata (pyproject.toml)
  input_line_1:1:2: fatal error: module file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.29.01-21b454f32e2b6b83ab0e4c2cf5c6bab1/build/lib/libc.pcm' not found: module file not found
  #include <new>
   ^
  input_line_1:1:2: note: imported by module 'std' in '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-21b454f32e2b6b83ab0e4c2cf5c6bab1/lib/std.pcm'
  Warning in cling::IncrementalParser::CheckABICompatibility():
    Failed to extract C++ standard library version.
  Replaced symbol at_quick_exit cannot be found in JIT!
  Failed to load module std
  <<< cling interactive line includer >>>: fatal error: module file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.29.01-21b454f32e2b6b83ab0e4c2cf5c6bab1/build/lib/libc.pcm' not found: module file not found
  <<< cling interactive line includer >>>: note: imported by module '_Builtin_intrinsics' in '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-21b454f32e2b6b83ab0e4c2cf5c6bab1/lib/_Builtin_intrinsics.pcm'
  Failed to load module _Builtin_intrinsics
  Failed to load module _Builtin_intrinsics
  Failed to load module std
  python3: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.29.01-21b454f32e2b6b83ab0e4c2cf5c6bab1/root-6.29.01/core/metacling/src/TCling.cxx:1292: void RegisterCxxModules(cling::Interpreter&): Assertion `clingInterp.getMacro("gROOT") && "Couldn't load gROOT macro?"' failed.
  error: subprocess-exited-with-error
  
  Ã— Preparing metadata (pyproject.toml) did not run successfully.
  â”‚ exit code: -6
  â•°â”€> See above for output.
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/python3/3.9.14-f1bd82445f2982609f838e795adb062f/bin/python3 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/py3-pip/23.1.1-6ca7254dbe849f7b2c3aa4328a6e6ff7/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py prepare_metadata_for_build_wheel /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.12.0-129d5c7ef90edc5e88634b8e829c0e16/cmsdist-tmp/tmpynara45i
  cwd: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-hepdata-lib/0.12.0-129d5c7ef90edc5e88634b8e829c0e16/cmsdist-tmp/pip-req-build-axb0itd8
  Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

cmsbuild · 2023-08-04T10:43:01Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad3257/34072/summary.html
COMMIT: 2f4eb60
CMSSW: CMSSW_13_3_X_2023-08-03-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/185/34072/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
* The action "build-external+py3-hepdata-lib+0.12.0-20f89cf20cd600cb1518a0d874d08f3c" was not completed successfully because Failed to build py3-hepdata-lib. Log file in /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_ppc64le_gcc11/external/py3-hepdata-lib/0.12.0-20f89cf20cd600cb1518a0d874d08f3c/log. Final lines of the log file:
full command: /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/el8_ppc64le_gcc11/external/python3/3.9.14-f1bd82445f2982609f838e795adb062f/bin/python3 /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/el8_ppc64le_gcc11/external/py3-pip/23.1.1-6ca7254dbe849f7b2c3aa4328a6e6ff7/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py prepare_metadata_for_build_wheel /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_ppc64le_gcc11/external/py3-hepdata-lib/0.12.0-20f89cf20cd600cb1518a0d874d08f3c/cmsdist-tmp/tmpllx13vnc
cwd: /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_ppc64le_gcc11/external/py3-hepdata-lib/0.12.0-20f89cf20cd600cb1518a0d874d08f3c/cmsdist-tmp/pip-req-build-ap_zgtk5
Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

 Encountered error while generating package metadata.
> See above for output.

note: This is an issue with the package mentioned above, not pip.

smuzaffar · 2023-08-04T10:45:23Z

please test for el8_ppc64le_gcc11

vgvassilev · 2023-08-04T10:46:15Z

@hahnjo, do you have any clue here?

cmsbuild · 2023-08-04T12:32:03Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad3257/34079/summary.html
COMMIT: 2f4eb60
CMSSW: CMSSW_13_3_X_2023-08-03-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/185/34079/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[ 75%] Built target DDRec
make[2]: Leaving directory '/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_ppc64le_gcc11/external/dd4hep/v01-23x-7c35cca5308ee17dc25510e92edd086c/build'
[ 75%] Built target DDEvePlugins
make[1]: Leaving directory '/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_ppc64le_gcc11/external/dd4hep/v01-23x-7c35cca5308ee17dc25510e92edd086c/build'
make: *** [Makefile:146: all] Error 2
error: Bad exit status from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.oLUA82 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+dd4hep+v01-23x-7c35cca5308ee17dc25510e92edd086c
Bad exit status from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.oLUA82 (%build)

cmsbuild · 2023-08-04T12:38:10Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad3257/34080/summary.html
COMMIT: 2f4eb60
CMSSW: CMSSW_13_3_ROOT6_X_2023-08-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/185/34080/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-23x-e8681283480e934baf138860e67c04f9/build/DDEve && /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02796/el8_amd64_gcc11/external/cmake/3.25.2-ad4f35b5a88cc925c835889f6a6fd837/bin/cmake -E cmake_symlink_library ../lib/libDDEvePlugins.so.1.23 ../lib/libDDEvePlugins.so.1.23 ../lib/libDDEvePlugins.so
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-23x-e8681283480e934baf138860e67c04f9/build'
[ 77%] Built target DDEvePlugins
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-23x-e8681283480e934baf138860e67c04f9/build'
make: *** [Makefile:146: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0KnryG (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+dd4hep+v01-23x-e8681283480e934baf138860e67c04f9
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0KnryG (%build)

cmsbuild · 2023-08-09T13:36:40Z

Pull request #185 was updated.

hahnjo · 2023-08-09T13:40:58Z

@hahnjo, do you have any clue here?

It turns out there was a patch missing / I was a bit over-enthusiastic to drop it as it was only partly replaced with an upstream solution. As a result, runtime modules were not installable / relocatable and libc.pcm wasn't found (with assertions enabled it bails out earlier than that, for the same reason).

I added back the patch with the latest push and fixed a couple other issues. @smuzaffar could you add back hepdata and restart testing, first on amd64? Sorry for testing the installation step of ROOT before!

smuzaffar · 2023-08-09T13:43:34Z

please test for CMSSW_13_3_ROOT6_X

Store a reference ourselves. Also Lexer::isIdentifierBodyChar() was renamed to Lexer::isAsciiIdentifierContinueChar().

These two fields don't exist anymore in LLVM 16.

The function overload without PrintingPolicy is not available in LLVM 16, see https://reviews.llvm.org/D134813.

The GlobalDecl parameter wasn't used since quite some time.

adjustPassManager was only used for a few backends, such as AMDGPU and NVPTX, but not on the CPU architectures we care about. The DiscriminatorsPass was also removed upstream Clang, see commit llvm/llvm-project@2978d02681.

In LLVM 16, we now get ElaboratedType far more often, but they don't have all namespace qualifiers we need. This fixes the build of the RooFitCore module, but many other places are likely affected as well.

GenericLLVMIRPlatformSupport now declares atexit, which leads to a duplicate symbol error during startup and fails the transaction. Completely switch to the provided infrastructure and just override the helpers to register the functions with our Interpreter.

According to llvm/llvm-project@af27466c50, it is used to represent types pulled in with a using declaration, for example `using std::error_code; error_code x;`. This fixes the build of the ROOTTMVASofie module on macOS where this was causing `std::size_t` not be fully desugared to `unsigned long` at first to later end up with two identical classes in a list that must not have duplicates.

In LLVM 16, we get ElaboratedType's in TemplateArgument's and need to recurse into them. This fixes the handling of Double32_t in the test roottest-root-io-double32-make.

With the upgrade to LLVM 16, we again have test failures due to crashes and output ordering compared to the reference files. This reverts commit 47277df.

This seems to be required with LLVM 16 on Windows and fixes roottest/root/meta/callfunc/assertUnload.C

This fixes roottest/root/meta/tuple/exec_configtype_unload.C on Windows. Co-authored-by: Bertrand Bellenot <Bertrand.Bellenot@cern.ch>

Exclude options::DXCOption to avoid confusing the parser with the second -E option.

See also commit de84bfc during the previous LLVM upgrade...

LLVM now fully qualifies template template parameters when printing, since commit llvm/llvm-project@5fb3f43778 As pointed out in that message, this makes it consistent with type parameters, so add an additional test (Yd1) that would have already passed with LLVM 13.

LLVM 16 honors how the declarations were written, without the class or struct keywords.

cmsbuild · 2023-10-04T10:01:02Z

Pull request #185 was updated.

cmsbuild added orp-pending pending-signatures externals-pending tests-pending labels Aug 4, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 4, 2023

smuzaffar mentioned this pull request Aug 4, 2023

Update ROOT and Cling to LLVM 16 root-project/root#13273

Merged

23 tasks

cmsbuild added the requires-external label Aug 4, 2023

smuzaffar mentioned this pull request Aug 4, 2023

[do not merge][root6] disable hepdata-lib to test root llvm16 cms-sw/cmsdist#8634

Closed

cmsbuild added tests-rejected and removed tests-started labels Aug 4, 2023

hahnjo force-pushed the llvm16 branch from 2f4eb60 to 9aa54dd Compare August 9, 2023 13:36

cmsbuild added tests-pending and removed tests-rejected labels Aug 9, 2023

cmsbuild removed the tests-pending label Aug 9, 2023

hahnjo and others added 25 commits October 4, 2023 11:15

[cling] Lexer does not expose getLangOpts() anymore

cf48788

Store a reference ourselves. Also Lexer::isIdentifierBodyChar() was renamed to Lexer::isAsciiIdentifierContinueChar().

[cling] Update for new FileNotFound callback

974ec61

[cling] Update InvocationOptions

1641e9f

[cling] Resource directory based on major version only

ffed3db

[cling] Remove PMBuilder members

68615b5

These two fields don't exist anymore in LLVM 16.

[cling] Set MSVolatile in LangOpts

01234a2

[cling] Misc adaptations for updated APIs

a4e12c7

[cling] Don't print name of EnumDecl if there is none

968ae84

The function overload without PrintingPolicy is not available in LLVM 16, see https://reviews.llvm.org/D134813.

[cling] Adapt to updated forgetDecl signature

351cd26

The GlobalDecl parameter wasn't used since quite some time.

[cling] Remove extension of legacy pass manager

78b7dcf

adjustPassManager was only used for a few backends, such as AMDGPU and NVPTX, but not on the CPU architectures we care about. The DiscriminatorsPass was also removed upstream Clang, see commit llvm/llvm-project@2978d02681.

[cling] Update handling of ElaboratedType in GetFullyQualifiedType

ccc0332

In LLVM 16, we now get ElaboratedType far more often, but they don't have all namespace qualifiers we need. This fixes the build of the RooFitCore module, but many other places are likely affected as well.

[cling] Handle ElaboratedType in ReSubstTemplateArg

bc5fb71

In LLVM 16, we get ElaboratedType's in TemplateArgument's and need to recurse into them. This fixes the handling of Double32_t in the test roottest-root-io-double32-make.

[win64] Disable Cling optimizations

77f54af

With the upgrade to LLVM 16, we again have test failures due to crashes and output ordering compared to the reference files. This reverts commit 47277df.

[TCling] Prepend drive letter to absolute path

7d2314d

This seems to be required with LLVM 16 on Windows and fixes roottest/root/meta/callfunc/assertUnload.C

[cling] Avoid unloading Decls not found in DeclContext

8ed973e

This fixes roottest/root/meta/tuple/exec_configtype_unload.C on Windows. Co-authored-by: Bertrand Bellenot <Bertrand.Bellenot@cern.ch>

[cling] Fix preprocessor option parsing

f315199

Exclude options::DXCOption to avoid confusing the parser with the second -E option.

[cling] Expect normalized alias option offload_device_only

9a8f5f0

See also commit de84bfc during the previous LLVM upgrade...

[cling] Remove expected space before array brackets in tests

93be030

[cling] Remove elaborated keyword from output checks

f30e958

LLVM 16 honors how the declarations were written, without the class or struct keywords.

[cling] Update expected error messages in tests

9844bd8

[cling] Update expected types in output checks

6ac259a

[cling] Expect additional error in Prompt/BlockComments.C

1d2c584

hahnjo force-pushed the llvm16 branch from 33f99fe to 1d2c584 Compare October 4, 2023 10:00

cmsbuild added tests-pending and removed tests-approved labels Oct 4, 2023

smuzaffar closed this Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Llvm16 #185

Llvm16 #185

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023 •

edited

Loading

cmsbuild commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

vgvassilev commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

cmsbuild commented Aug 9, 2023

hahnjo commented Aug 9, 2023

smuzaffar commented Aug 9, 2023

cmsbuild commented Oct 4, 2023

Llvm16 #185

Llvm16 #185

Conversation

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023 • edited Loading

cmsbuild commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

External Build

smuzaffar commented Aug 4, 2023

smuzaffar commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

External Build

smuzaffar commented Aug 4, 2023

vgvassilev commented Aug 4, 2023

cmsbuild commented Aug 4, 2023

External Build

cmsbuild commented Aug 4, 2023

External Build

cmsbuild commented Aug 9, 2023

hahnjo commented Aug 9, 2023

smuzaffar commented Aug 9, 2023

cmsbuild commented Oct 4, 2023

smuzaffar commented Aug 4, 2023 •

edited

Loading