Skip to content

Commit

Permalink
[win64] Disable Cling optimizations
Browse files Browse the repository at this point in the history
With the upgrade to LLVM 16, we again have test failures due to crashes
and output ordering compared to the reference files.

This reverts commit 47277df.
  • Loading branch information
hahnjo committed Aug 9, 2023
1 parent 36dc816 commit 9aa54dd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions core/metacling/src/TCling.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -1398,9 +1398,10 @@ TCling::TCling(const char *name, const char *title, const char* const argv[], vo

clingArgsStorage.push_back("-Wno-undefined-inline");
clingArgsStorage.push_back("-fsigned-char");
// The -O1 optimization flag has nasty side effects on Windows (32 bit)
// The -O1 optimization flag has nasty side effects on Windows (32 and 64 bit)
// See the GitHub issues #9809 and #9944
#if !defined(_MSC_VER) || defined(_WIN64)
// TODO: to be reviewed after the upgrade of LLVM & Clang
#ifndef _MSC_VER
clingArgsStorage.push_back("-O1");
// Disable optimized register allocation which is turned on automatically
// by -O1, but seems to require -O2 to not explode in run time.
Expand Down

0 comments on commit 9aa54dd

Please sign in to comment.