-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve constructor for PhotonIsolationCalculator #46289
Conversation
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42111
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
After the merge of #46276 there is a conflict |
3e9d291
to
7ad8600
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42115 |
Pull request #46289 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again. |
It is in general better to use a constructor rather than a setup method.
7ad8600
to
228bf6e
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42116 |
Pull request #46289 was updated. @jfernan2, @mandrenguyen can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
It is in general better to use a constructor rather than a setup method.
PR validation:
Compiles.