Pass pointer to EgammaRecHitIsolation::getEtSum

[Dr15Jones]

PR description:

The reference was having its address taken and then passed to an internal function which checked for null. UBSAN reported that some calling code of getEtSum was dereferencing a nullptr to pass to the routine.

C++ says references can never be assigned to a nullptr and the compiler/optimizer are allowed to use that. Therefore the internal routine being called CAN have the check for nullptr ignored which can lead to incorrect execution. Only by having getEtSum also take an address rather than a reference can the code be guaranteed to be what was expected.

PR validation:

Code compiles.

[Dr15Jones]

please test

[Dr15Jones]

@makortel FYI

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46271/42092

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• RecoEgamma/EgammaElectronAlgos (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)

@antoniovagnerini, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @cericeci, @jainshilpi, @jhgoh, @lgray, @missirol, @mmusich, @mtosi, @ram1123, @rociovilar, @rovere, @sameasy, @sobhatta, @trocino, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d278e1/41982/summary.html
COMMIT: 7575c77
CMSSW: CMSSW_14_2_X_2024-10-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46271/41982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 34 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 3436
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327880
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[antoniovagnerini]

+1

• spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1