Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes for HLT online DQM #46245

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 4, 2024

PR description:

This PR bundles together a couple of fixes for the HLT online DQM:

%MSG-w TrackProducerBase:  TrackRefitter:hltrefittedForPixelDQM  03-Oct-2024 22:56:25 CEST Run: 386554 Event: 2607599
BeamSpot is not valid
%MSG
%MSG-e TrackRefitter:  TrackRefitter:hltrefittedForPixelDQM  03-Oct-2024 22:56:25 CEST Run: 386554 Event: 2607599
BeamSpot is (0,0,0), it is probably because is not valid in the event
%MSG

I believe the issue is that the current hltrefittedForPixelDQM instance clones the one used for offline (refittedForPixelDQM) which ultimately clones the template with the offline parameters:

beamSpot = cms.InputTag("offlineBeamSpot"),

  • secondly, also looking at the HLT quick collection many of the plots are empty, I believe due the usage of deprecated trigger paths in input

The two issues are addressed at 3bf61e3 and 17e3bf7 respectively.

PR validation:

None, will need to be tested via DQM replay

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might backport to 14.1.x and 14.0.x for 2024 data-taking purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)
  • DQMOffline/Trigger (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mtosi, @rociovilar, @silviodonato, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

Pull request #46245 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

Pull request #46245 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2024

playback kindly provided by @nothingface0 looks good.

Pixel residuals:

Screenshot from 2024-10-04 14-43-41

Object Monitor:

Screenshot from 2024-10-04 14-44-26

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73dcff/41962/summary.html
COMMIT: 3c5e8fe
CMSSW: CMSSW_14_2_X_2024-10-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46245/41962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2024

+hlt

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 888aabb into cms-sw:master Oct 7, 2024
11 checks passed
@mmusich mmusich deleted the mm_refurbish_HLT_DQM branch October 7, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants