Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threshold of max number of pixel clusters for cosmic tracking #46283

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

sroychow
Copy link
Contributor

@sroychow sroychow commented Oct 7, 2024

PR description:

The rate of cosmic tracks have dropped since ERA G, see latest slides. After performing several tests, Tracker DPG concluded that it was related to the cut that is imposed for number of max. pixel clusters per event in Cosmic tracking, see slides. The average number of clusters in pixel has steadily increased and reaching 300(default value till now) is roughly correlated in time with the rate drop. We are increasing the threshold to 1000 in the configs for Cosmic tracking.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Not a backport. Backport will be done for 14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

A new Pull Request was created by @sroychow for master.

It involves the following packages:

  • RecoTracker/SpecialSeedGenerators (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor Author

sroychow commented Oct 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51fde6/42013/summary.html
COMMIT: 2706393
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46283/42013/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 332d911 into cms-sw:master Oct 7, 2024
11 checks passed
@@ -39,7 +39,7 @@ def makeSimpleCosmicSeedLayers(*layers):
MaxNumberOfStripClusters = cms.uint32(300),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casually looking in the online DQM configuration for the strip client, I noticed:

process.simpleCosmicBONSeeds.ClusterCheckPSet.MaxNumberOfStripClusters = 450
process.combinatorialcosmicseedfinderP5.MaxNumberOfStripClusters = 450

perhaps it should be considered in the offline reconstruction as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants