Change thresholds on LED and FEStatus Quality plots ECAL DQM

[abhih1]

PR description:

This PR does the following:

1. Disables all cuts on the LED Quality plot until the experts can tune the parameters.
2. Adds a cut on minimum no.of events to turn the FEStatus quality to RED, to reduce false alarm on transient issues.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the Master PR.
Backports are made to 14_0_X #45430

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45429/40880

[cmsbuild]

A new Pull Request was created by @abhih1 for master.

It involves the following packages:

• DQM/EcalMonitorClient (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-811ec3/40351/summary.html
COMMIT: 5c43000
CMSSW: CMSSW_14_1_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45429/40351/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 13 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3246798
• DQMHistoTests: Total failures: 99
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246679
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 199 log files, 163 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[nothingface0]

This variable seems to be unused.

[abhih1]

Yes, but if that's commented out it will complain about other variables like toleranceAmpRMSRatio_, which would need to be commented out here as well as the header and .py files. And since this is supposed to be a temporary disabling of the cuts and would need to be reused in the future, I left it untouched to keep the changes to a minimum.

[tjavaid]

+1

• P5 tests OK with its 14_0_X backport Change thresholds on LED and FEStatus Quality plots ECAL DQM [14_0_X] #45430 . (thanks @nothingface0)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1